This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2185-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/FPModes/InletPressureCheck.c
Revision Comment by Sean Nash on 11 December 2025, 11:32 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25745

  Add space between if and (.

Revision Comment by Sean Nash on 11 December 2025, 11:32 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25746

  Add space before ).

----------------------------------------
File: firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
Revision Comment by Sean Nash on 11 December 2025, 11:30 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25743

  Keep blank line here.

Revision Comment by Raghu Kallala on 11 December 2025, 07:21 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25727

  Remove handlePreGenPDefInletWaterState

Revision Comment by Raghu Kallala on 11 December 2025, 07:20 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25726

  Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

Revision Comment by Sean Nash on 11 December 2025, 11:31 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25744

  Be consistent on whether you have a blank line between break
  and next case.

Revision Comment by Raghu Kallala on 11 December 2025, 07:22 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25728

  Add blank line before return statement

Revision Comment by Raghu Kallala on 11 December 2025, 07:25 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25730

  Handle transition here after changing the flush logic
  
          transitionToGenPermeateDefeaturedMode();
          requestGenWaterDefStart();

Revision Comment by Raghu Kallala on 11 December 2025, 07:24 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25729

  Need to remove this handler

----------------------------------------
File: firmware/App/Monitors/WaterQualityMonitor.c
Revision Comment by Sean Nash on 11 December 2025, 11:10 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25742

  What are these coefficients for?  At least describe in
  comments, if not the names.

Revision Comment by Sean Nash on 11 December 2025, 11:10 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25741

  Remove extra blank line.

Revision Comment by Raghu Kallala on 11 December 2025, 07:18 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25725

  Call this in both Pre Gen: Verify Water and Gen Permeate

Revision Comment by Raghu Kallala on 11 December 2025, 07:13 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25723

  Put quadratic and linear terms in parentheses.

Revision Comment by Raghu Kallala on 11 December 2025, 07:16 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25724

  Greater than or equal to for low limit
  pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG
  
  Also give space before and after parentheses.

Revision Comment by Raghu Kallala on 11 December 2025, 08:23 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1#c25731

  Add a 1 second persistence on this alarm


---

ID: LEAHI-DD-FIRMWARE-LDT-2185-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2185-1

Title: LEAHI-DD-FIRMWARE-LDT-2185_(IO, FP) Water Treatment and Degassing IOFP Alpha Refinement Updates
Statement of Objectives:


State: Review

Author: Raghu Kallala
Moderator: Raghu Kallala
Reviewers: (10 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Jashwant Gantyada
     Sean Nash
     Vendor - TEL - Varshini Nagabooshanam
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho
     Vendor - TEL - Sameer Poyil