This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2936-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/FPModes/FlushConcentrate.c Revision Comment by Sean Nash on 01 December 2025, 13:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25346 Remove extra blank line. Reply by Raghu Kallala on 02 December 2025, 07:36 > Fixed. Reply by Sean Nash on 09 December 2025, 10:14 > I don't see fix Revision Comment by Sean Nash on 01 December 2025, 13:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25347 isFlushComplete looks like an output. Reply by Raghu Kallala on 02 December 2025, 07:37 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 13:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25348 concentateFlushTankFullTimer looks like an input. Reply by Raghu Kallala on 02 December 2025, 07:37 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 14:00 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25349 isFlushComplete in an output. pendingStartConcentrateFlushRequest appears to be an input and an output. Reply by Raghu Kallala on 02 December 2025, 07:37 > Fixed. ---------------------------------------- File: firmware/App/Modes/FPModes/ModeGenPermeate.c Revision Comment by Sean Nash on 01 December 2025, 20:52 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25351 Add blank line between declaration and rest of code in scope. Reply by Raghu Kallala on 02 December 2025, 07:51 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 20:53 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25352 Update inputs/outputs. Reply by Raghu Kallala on 02 December 2025, 07:52 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 20:53 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25353 Update inputs/outputs. Reply by Raghu Kallala on 02 December 2025, 07:52 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 20:54 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25354 Update inputs/outputs (throughout this unit). Reply by Raghu Kallala on 02 December 2025, 07:58 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 20:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25355 These divisions should have a divide by zero check. Reply by Raghu Kallala on 02 December 2025, 08:06 > Done in if condition, that block of code will be executed > only when the denominator value is greater than 10 Revision Comment by Vendor - TEL - Sameer Poyil on 03 December 2025, 06:19 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25444 Publish all other important data like conductivity and pressures Reply by Raghu Kallala on 03 December 2025, 08:38 > Published in the respective modules Revision Comment by Vendor - TEL - Sameer Poyil on 03 December 2025, 06:20 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25445 arrange static and global function properly , public on top and static on bottom Reply by Raghu Kallala on 03 December 2025, 10:34 > Resolved. Thanks Revision Comment by Vendor - TEL - Sameer Poyil on 03 December 2025, 06:23 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25446 do we need override function for high flow rate , low flow rate, conductivity, pressure etc ? Reply by Raghu Kallala on 03 December 2025, 08:42 > We might need to provide a possibility to override the > persistence time on alarm. To be clarified. Reply by Raghu Kallala on 04 December 2025, 10:16 > Checked with Eliza if they need it for alarm persistence > time. Not needed at this time, we can add them in future ---------------------------------------- File: AlarmDefs.h Revision Comment by Sean Nash on 05 December 2025, 14:58 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25600 I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong. Reply by Raghu Kallala on 09 December 2025, 10:03 > Fixed the ordering ---------------------------------------- File: MsgDefs.h Revision Comment by Vendor - TEL - Sameer Poyil on 26 November 2025, 21:02 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25323 Need to co-ordinate with drybicart message id since it is using 0x70 Reply by Raghu Kallala on 01 December 2025, 08:24 > Updated. Now using 0x71 Revision Comment by Sean Nash on 01 December 2025, 13:17 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25335 Remove extra blank line. Reply by Raghu Kallala on 02 December 2025, 08:09 > Updated. ---------------------------------------- File: firmware/App/Modes/FPModes/ModePreGenPermeate.c Revision Comment by Sean Nash on 04 December 2025, 08:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25512 Put space between if and ( for all conditions in this function. Reply by Raghu Kallala on 04 December 2025, 10:14 > Fixed. Revision Comment by Vendor - TEL - Sameer Poyil on 03 December 2025, 06:26 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25447 publish filter flush status , add other important data , inlet pressure etc Reply by Raghu Kallala on 03 December 2025, 08:37 > Done in individual units publish functions. Revision Comment by Vendor - TEL - Sameer Poyil on 03 December 2025, 06:29 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25448 add any override function if required Reply by Raghu Kallala on 03 December 2025, 08:36 > Handled in FPOperationModes and respective states of PreGen > have it. ---------------------------------------- File: firmware/App/Monitors/Conductivity.c Revision Comment by Vendor - TEL - Sameer Poyil on 26 November 2025, 19:05 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25319 not initialized in init function Reply by Raghu Kallala on 01 December 2025, 07:12 > Fixed Revision Comment by Sean Nash on 01 December 2025, 13:22 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25337 This is a lot of memory for an average with little value. Assume we want moving 3-sec average and samples are added in priority task every time (so 100/sec). Unlikely that we will have real samples at 100 Hz. Maybe 10 Hz. So recommend adding a new sample to the running average every 100 ms (every 10th time in priority task) so we can reduce the number of samples in the average from 300 to 30 to be more reasonable and save memory. Reply by Raghu Kallala on 02 December 2025, 07:06 > Modified. Thanks Revision Comment by Sean Nash on 04 December 2025, 08:59 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25513 I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )". Reply by Raghu Kallala on 04 December 2025, 10:10 > Fixed. thanks Revision Comment by Sean Nash on 01 December 2025, 13:29 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25341 roRejectionRatioTankFill is also an output. Reply by Raghu Kallala on 02 December 2025, 07:07 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 13:27 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25338 Declare local variables at top of scope (top of function in this case). Reply by Raghu Kallala on 02 December 2025, 07:09 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 13:28 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25340 Input is roRejectionRatio. Reply by Raghu Kallala on 02 December 2025, 07:15 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 13:27 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25339 Input is roRejectionRatioTankFill. Reply by Raghu Kallala on 02 December 2025, 07:15 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 13:29 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25343 roRRAvg is an input. Reply by Raghu Kallala on 02 December 2025, 07:15 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 13:30 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25344 roRRTankFillAvg is an input. Reply by Raghu Kallala on 02 December 2025, 07:12 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 13:30 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25345 Update inputs/outputs to include RR broadcast related variables. Reply by Raghu Kallala on 02 December 2025, 07:12 > Fixed. Revision Comment by Vendor - TEL - Sameer Poyil on 26 November 2025, 19:06 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25320 Not initialized ? who modifies this variable ? Reply by Raghu Kallala on 01 December 2025, 07:13 > Updated, missed to increment. ---------------------------------------- File: firmware/App/Monitors/Conductivity.h Revision Comment by Vendor - TEL - Sameer Poyil on 26 November 2025, 19:08 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25321 I do not see structure packing. is it not required ? Reply by Raghu Kallala on 02 December 2025, 10:12 > As everything is of size 32 bits, skipped it Reply by Vendor - TEL - Sameer Poyil on 02 December 2025, 23:42 > as a practice , we need to add a pragma pack for all > structure irrespective of the size as per Sean. Reply by Raghu Kallala on 03 December 2025, 10:38 > Resolved. Revision Comment by Vendor - TEL - Sameer Poyil on 26 November 2025, 19:10 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25322 comment should start with Capital letter ? Reply by Raghu Kallala on 01 December 2025, 07:15 > Fixed. Revision Comment by Vendor - TEL - Sameer Poyil on 03 December 2025, 17:58 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25503 Small letter used Reply by Raghu Kallala on 04 December 2025, 10:15 > Fixed. Thanks ---------------------------------------- File: firmware/App/Monitors/WaterQualityMonitor.c Revision Comment by Sean Nash on 01 December 2025, 13:19 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25336 Should be 2 blank lines before/after test banner. Reply by Raghu Kallala on 02 December 2025, 07:34 > Fixed. ---------------------------------------- File: firmware/App/Controllers/ROPump.c Revision Comment by Sean Nash on 01 December 2025, 21:07 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25356 Add space before ); Reply by Raghu Kallala on 02 December 2025, 07:42 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 21:08 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25357 This function has no output. dutyCyclePct is local. Reply by Raghu Kallala on 02 December 2025, 07:46 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 21:09 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25358 roPumpState is not an array. stopPumpRequest isn't referenced in this function. targetROPumpFlowRate is an input and an output and there are others. Reply by Raghu Kallala on 02 December 2025, 07:46 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 21:11 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25359 Update inputs/outputs. Reply by Raghu Kallala on 02 December 2025, 07:49 > Fixed. Revision Comment by Sean Nash on 01 December 2025, 21:12 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25360 Update inputs/outputs throughout this unit. Reply by Raghu Kallala on 02 December 2025, 07:49 > Fixed. ---------------------------------------- File: firmware/App/Modes/FPModes/FlushFilter.c Revision Comment by Sean Nash on 01 December 2025, 14:02 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25350 isFlushComplete looks like an output. Reply by Raghu Kallala on 02 December 2025, 07:42 > Fixed. ---------------------------------------- File: firmware/App/Modes/FPModes/FlushPermeate.c Revision Comment by Sean Nash on 09 December 2025, 10:16 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25663 Change comment from 3 to 5 minutes to match code. Reply by Raghu Kallala on 09 December 2025, 10:28 > Resolved Revision Comment by Sean Nash on 04 December 2025, 08:55 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1#c25511 Put first condition in () too. Reply by Raghu Kallala on 04 December 2025, 10:11 > Fixed. --- ID: LEAHI-DD-FIRMWARE-LDT-2936-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2936-1 Title: LEAHI-DD-FIRMWARE-LDT-2936_IOFP - Update M12 and Boost Pump logic in FW for Beta1 Statement of Objectives: State: Closed Summary: Author: Raghu Kallala Moderator: Raghu Kallala Reviewers: (7 active, 3 completed*) Sean Nash (*) Vinayakam Mani (*) Michael Garthwaite (*) Vendor - TEL - Jashwant Gantyada Vendor - TEL - Arpita Srivastava Vendor - TEL - Varshini Nagabooshanam Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Daniel Ho Vendor - TEL - Sameer Poyil