This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2977-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Sean Nash on 23 January 2026, 09:50 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1#c26585

  For long macros, consider moving doxygen comment from right
  side to line above with /// since right side won't line up with
  others.

  Reply by Michael Garthwaite on 23 January 2026, 12:09
  > fixed for both _TO_PWM macros

    Reply by Sean Nash on 23 January 2026, 12:45
    > When comment is above, use /// instead of ///<.  And add
    > blank lines before/after - doxygen seems to get confused
    > about where to apply the comment without clear separation.

      Reply by Michael Garthwaite on 23 January 2026, 12:51
      > fixed.

Revision Comment by Sean Nash on 23 January 2026, 09:49 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1#c26584

  I don't see this macro being used anywhere.

  Reply by Michael Garthwaite on 23 January 2026, 12:09
  > its been removed. looks like we send everything down as a
  > percentage now and the fluid pump driver will change it
  > counts.


---

ID: LEAHI-DD-FIRMWARE-LDT-2977-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2977-1

Title: LEAHI-DD-FIRMWARE-LDT-2977_IOFP - Update starting flow estimations based on recovery mode
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (8 active, 2 completed*)
     Sean Nash   (*)
     Raghu Kallala   (*)
     Vendor - TEL - Jashwant Gantyada
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Varshini Nagabooshanam
     Vinayakam Mani
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho
     Vendor - TEL - Sameer Poyil