This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-2998-1. Review Summary: No summary ---------------------------------------- File: DDDefs.h Revision Comment by Vinayakam Mani on 30 December 2025, 11:50 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26014 Please add the valve validations in the valves.c Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:47 > Added ---------------------------------------- File: firmware/App/Drivers/TemperatureSensors.c Revision Comment by Vinayakam Mani on 30 December 2025, 10:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26000 Please remove it. Reply by Vendor - TEL - Varshini Nagabooshanam on 02 January 2026, 14:09 > Removed Revision Comment by Vinayakam Mani on 30 December 2025, 10:22 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c25997 remove extra blank line ---------------------------------------- File: firmware/App/Modes/ModeGenDialysate.c Revision Comment by Vinayakam Mani on 30 December 2025, 11:09 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26005 These are redundant information from level and pressure module, we may remove them. Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:51 > Removed from .c and .h files Revision Comment by Dara Navaei on 30 December 2025, 14:54 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26029 Why are these items have been removed? If we no longer need these items then we should update the structure too. Reply by Vendor - TEL - Varshini Nagabooshanam on 02 January 2026, 14:01 > Yes, we need to update Dailin as well. I’ll make sure to > update it there. ---------------------------------------- File: firmware/App/Monitors/Level.c Revision Comment by Raghu Kallala on 21 January 2026, 07:25 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26499 These values should be retained for Beta 1.0 Reply by Vendor - TEL - Varshini Nagabooshanam on 21 January 2026, 11:29 > Updated Revision Comment by Dara Navaei on 30 December 2025, 11:15 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26006 This should be D98 function. Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:51 > Changed Revision Comment by Vinayakam Mani on 30 December 2025, 11:18 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26007 D98? Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:51 > Changed Revision Comment by Sean Nash on 21 January 2026, 12:38 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26515 An alarm is triggered in this function. Add to header. Reply by Vendor - TEL - Varshini Nagabooshanam on 21 January 2026, 13:11 > Added Revision Comment by Dara Navaei on 30 December 2025, 11:27 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26010 Does this function need to support the rest of the level sensors? (e.g. P25, D63, D98?) Reply by Vendor - TEL - Varshini Nagabooshanam on 02 January 2026, 14:03 > Currently, this function supports only D6 and P25. Separate > functions have been implemented for D63 and D98. Revision Comment by Vinayakam Mani on 05 January 2026, 10:32 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26068 Please introduce the test config for Beta1.9 changes across the files. This helps to continue work on Beta1.0 system without any issues. Reply by Vendor - TEL - Varshini Nagabooshanam on 05 January 2026, 15:05 > Added Revision Comment by Sean Nash on 05 January 2026, 10:12 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26058 Brief should mention function's name. Reply by Vendor - TEL - Varshini Nagabooshanam on 05 January 2026, 15:05 > Changed Revision Comment by Vinayakam Mani on 02 January 2026, 15:08 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26051 Use "getLevelStatus" Reply by Vendor - TEL - Varshini Nagabooshanam on 05 January 2026, 09:37 > Updated Revision Comment by Vinayakam Mani on 30 December 2025, 11:25 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26008 Please add up bicarb chamber level based on the D63 and D98 level sensor combinations? Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:50 > Added Reply by Vendor - TEL - Varshini Nagabooshanam on 02 January 2026, 14:08 > Added ---------------------------------------- File: firmware/App/Monitors/Level.h Revision Comment by Zoltan Miskolci on 06 January 2026, 09:33 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26106 This should be before high, it feels wrong to have the order of 0,1,3,2 instead of 0,1,2,3 (Empty, Low, Medium, High) Reply by Vendor - TEL - Varshini Nagabooshanam on 06 January 2026, 13:06 > Updated ---------------------------------------- File: firmware/App/Monitors/Temperature.c Revision Comment by Sean Nash on 05 January 2026, 10:03 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26056 A comment in filter function suggests this is not a fixed sample size for D4. Reply by Vendor - TEL - Varshini Nagabooshanam on 05 January 2026, 15:30 > Added Reply by Sean Nash on 06 January 2026, 09:14 > I think 50 samples is the max, so this is fine. Please > remove the TODO comment. Reply by Vendor - TEL - Varshini Nagabooshanam on 06 January 2026, 13:06 > Removed Revision Comment by Vinayakam Mani on 30 December 2025, 11:33 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26011 50 Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:47 > Added Revision Comment by Sean Nash on 05 January 2026, 10:04 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26057 With exception of D4 temperature, is there any reason why all other temperatures shouldn't be filtered the same way? Reply by Vendor - TEL - Varshini Nagabooshanam on 06 January 2026, 13:14 > D99 has been updated using the same approach applied to the > D4 temperature. Revision Comment by Vinayakam Mani on 30 December 2025, 11:36 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26012 Implement the filter logics using these variables. Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:47 > Added. Revision Comment by Vinayakam Mani on 30 December 2025, 11:41 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26013 Please add D99 temp average. Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:47 > Added. ---------------------------------------- File: firmware/App/Services/FpgaDD.c Revision Comment by Vinayakam Mani on 30 December 2025, 10:39 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c25998 Please remove RTDReadCnt, per HDD. Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:53 > I will update you by EOD Reply by Vendor - TEL - Varshini Nagabooshanam on 02 January 2026, 14:09 > I removed and confirmed with Noe Revision Comment by Vinayakam Mani on 30 December 2025, 10:41 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c25999 RTDReadCnt -> Should be defined here? Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:53 > I need to check with Noe and I will update you by EOD Reply by Vendor - TEL - Varshini Nagabooshanam on 02 January 2026, 14:09 > Yes, I updated Revision Comment by Vinayakam Mani on 30 December 2025, 11:01 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26002 freshDialysatePressurePostUltrafilter (instead of TMP)? Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:52 > Updated Revision Comment by Vinayakam Mani on 30 December 2025, 11:05 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26003 fresh dialysate temperature? Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:52 > Updated Revision Comment by Vinayakam Mani on 30 December 2025, 11:06 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1#c26004 Bicarb Chamber Low level sensor Reply by Vendor - TEL - Varshini Nagabooshanam on 30 December 2025, 14:52 > Updated --- ID: LEAHI-DD-FIRMWARE-LDT-2998-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-2998-1 Title: LEAHI-DD-FIRMWARE-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes (higher priority) Statement of Objectives: State: Closed Summary: Author: Vendor - TEL - Varshini Nagabooshanam Moderator: Vendor - TEL - Varshini Nagabooshanam Reviewers: (12 active, 3 completed*) Sean Nash (*) Vinayakam Mani (*) Raghu Kallala (*) Zoltan Miskolci Vendor - TEL - Arpita Srivastava Vendor - TEL - Jashwant Gantyada Nicholas Ramirez Tiffany Mejia Michael Garthwaite Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Behrouz NematiPour Daniel Ho Stephen Quong Vendor - TEL - Sameer Poyil