This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-3103-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BalancingChamber.c
Revision Comment by Sean Nash on 14 January 2026, 09:50 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26279

  Add spaces before/after +=.

  Reply by Vendor - TEL - Jashwant Gantyada on 15 January 2026, 14:18
  > done.

Revision Comment by Vendor - TEL - Jashwant Gantyada on 13 January 2026, 13:46 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26268

  Why are we checking only fresh side pressures and not spent
  side as well?

  Reply by Vendor - TEL - Jashwant Gantyada on 21 January 2026, 13:09
  > We will have to look at it as well. But for now, we are just
  > monitoring the fresh side pressure variation.

Revision Comment by Sean Nash on 14 January 2026, 10:53 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26290

  Where is the closed loop control?

  Reply by Vendor - TEL - Jashwant Gantyada on 15 January 2026, 14:19
  > We handle it in the checkSpentFillComplete() mentioned in
  > line 946.

Revision Comment by Sean Nash on 14 January 2026, 10:55 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26291

  I thought we were going to complete cycle when done (not based
  on time) and feed back error in cycle time to control D48 pump
  speed to reduce error going forward so we end up getting the
  target cycle time which will give us target flow rate.

  Reply by Vendor - TEL - Jashwant Gantyada on 15 January 2026, 14:18
  > Fixed it.

    Reply by Sean Nash on 21 January 2026, 12:44
    > Should we remove the condition instead of commenting it
    > out?

Revision Comment by Sean Nash on 02 February 2026, 10:55 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26914

  Add a blank line before return statement.

Revision Comment by Sean Nash on 02 February 2026, 10:55 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26915

  Remove blank line.

Revision Comment by Vendor - TEL - Jashwant Gantyada on 14 January 2026, 15:05 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26313

  Why are we adjusting/reducing the speed of D48 by a factor of
  50%?

  Reply by Vendor - TEL - Jashwant Gantyada on 21 January 2026, 13:08
  > This is a testable value.

----------------------------------------
File: firmware/App/Modes/ModeGenDialysate.c
Revision Comment by Sean Nash on 02 February 2026, 10:51 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26912

  d48PumpSpeed is an input.

Revision Comment by Sean Nash on 14 January 2026, 10:51 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26285

  Is this an initial guess for pump control?

  Reply by Vendor - TEL - Jashwant Gantyada on 15 January 2026, 14:20
  > Yes. will tune them based on the test results.

----------------------------------------
File: firmware/App/Modes/ModeGenDialysate.h
Revision Comment by Sean Nash on 14 January 2026, 09:46 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26278

  Shouldn't this kind of function be in the pump controller unit?
  Assuming such functions already exist in the controller, so why
  do we need these?

  Reply by Vendor - TEL - Jashwant Gantyada on 15 January 2026, 14:21
  > changed the name to differentiate between driver level and
  > controller level functions.

----------------------------------------
File: firmware/App/Controllers/Valves.c
Revision Comment by Sean Nash on 02 February 2026, 10:52 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1#c26913

  Why is this commented out?


---

ID: LEAHI-DD-FIRMWARE-LDT-3103-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1

Title: LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Statement of Objectives:


State: Review

Author: Vinayakam Mani
Moderator: Vinayakam Mani
Reviewers: (10 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Jashwant Gantyada
     Sean Nash
     Vendor - TEL - Varshini Nagabooshanam
     Raghu Kallala
     Michael Garthwaite
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho
     Vendor - TEL - Sameer Poyil