This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-3222-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Valves.c
Revision Comment by Sean Nash on 03 February 2026, 16:38 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3222-1#c26998

  I don't think valve needs to be initialized here.  The for loop
  initializes it.

Revision Comment by Sean Nash on 03 February 2026, 16:41 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3222-1#c27000

  I don't think mask or pos require initialization either.

Revision Comment by Vendor - TEL - Sameer Poyil on 03 February 2026, 17:01 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3222-1#c27008

  is it possible to use the function u32ArrayOverride() here ?

Revision Comment by Sean Nash on 03 February 2026, 16:46 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3222-1#c27002

  Are we sure about the reversing of states here?  If we had this
  backward, I would think the Systems team would have had a much
  bigger complaint.  
  The description of their issue suggests that the 8 BC valves
  were correctly commanded to requested state except for the one
  they separately commanded earlier.  
  If we had this backward, I would think they would have said
  that all 8 valves did the wrong thing.

Revision Comment by Vendor - TEL - Sameer Poyil on 03 February 2026, 17:02 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3222-1#c27009

  This function also not using u32ArrayOverride()


---

ID: LEAHI-DD-FIRMWARE-LDT-3222-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3222-1

Title: LEAHI-DD-FIRMWARE-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
Statement of Objectives:


State: Review

Author: Vendor - TEL - Arpita Srivastava
Moderator: Vendor - TEL - Arpita Srivastava
Reviewers: (10 active, 0 completed*)
     Vendor - TEL - Jashwant Gantyada
     Vendor - TEL - Varshini Nagabooshanam
     Sean Nash
     Vinayakam Mani
     Raghu Kallala
     Michael Garthwaite
     Dara Navaei
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho
     Vendor - TEL - Sameer Poyil