This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-3978-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/Heaters.c
Revision Comment by Vinayakam Mani on 23 April 2026, 14:56 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28636

  instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

----------------------------------------
File: firmware/App/Monitors/Level.c
Revision Comment by Vinayakam Mani on 23 April 2026, 14:38 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28629

  Is this macro still being used? if not, delete it.

Revision Comment by Vinayakam Mani on 23 April 2026, 14:39 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28630

  Change this to LEVEL_T enum.

Revision Comment by Vinayakam Mani on 23 April 2026, 14:41 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28631

  Space inside parenthesis.

Revision Comment by Vinayakam Mani on 23 April 2026, 14:43 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28632

  space inside array index.

Revision Comment by Vinayakam Mani on 23 April 2026, 14:47 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28634

  Remove empty line

Revision Comment by Vinayakam Mani on 23 April 2026, 14:45 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28633

  Space before LVL_STATE_LOW

----------------------------------------
File: firmware/App/Monitors/Level.h
Revision Comment by Vinayakam Mani on 23 April 2026, 14:49 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1#c28635

  lower? and change the D98 level sensor comment as well.


---

ID: LEAHI-DD-FIRMWARE-LDT-3978-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3978-1

Title: LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
Statement of Objectives:


State: Review

Author: Vendor - TEL - Sameer Poyil
Moderator: Vendor - TEL - Sameer Poyil
Reviewers: (3 active, 0 completed*)
     Sean Nash
     Vinayakam Mani
     Dara Navaei