This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-4183-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/DryBiCart.c
Revision Comment by Vinayakam Mani on 09 June 2026, 14:14 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29683

  As suggested earlier in other code review, split this function
  into few init functions and call it here.

Revision Comment by Vinayakam Mani on 09 June 2026, 14:23 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29688

  function adjusts the volume of acid and bicarb based on the
  target conductivity of bicarb and dialysate solution?

Revision Comment by Vinayakam Mani on 09 June 2026, 14:20 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29686

  Add alarm message.

Revision Comment by Vinayakam Mani on 09 June 2026, 14:16 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29684

  Remove the commented code and add the comment for below
  function

Revision Comment by Vinayakam Mani on 09 June 2026, 14:52 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29695

  Do we need to call updateDryBicartOperation() here to determine
  the appropriate state.

Revision Comment by Vinayakam Mani on 09 June 2026, 15:09 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29696

  Can we keep getBicarbMixControlInterval( removing drybicart)
  from the function name?

Revision Comment by Vinayakam Mani on 09 June 2026, 15:11 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29697

  Same as above.

Revision Comment by Vinayakam Mani on 09 June 2026, 15:13 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29698

  Can we split the functions into two files: 1) DryBicart.c/h -
  Manages drybicart fill, supply, drain &  depressurizing states
  and 2) MixingControl: for acid/bicarb open/close loop
  functionality?

Revision Comment by Vinayakam Mani on 09 June 2026, 15:19 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29700

  declare a local variable to get these function values and use
  the variables here?

Revision Comment by Vinayakam Mani on 09 June 2026, 15:18 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29699

  remove blank space before =

Revision Comment by Vinayakam Mani on 09 June 2026, 15:33 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29703

  Update Inputs and outputs.

Revision Comment by Vinayakam Mani on 09 June 2026, 15:29 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29702

  fix the typo.

Revision Comment by Vinayakam Mani on 09 June 2026, 15:48 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29706

  Does this supposed to be 14 or 17 PSI (based on manifold) for
  B2.1 hardware?

Revision Comment by Vinayakam Mani on 09 June 2026, 15:41 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29705

  Is this code updated for B2.1 fill implementation?

Revision Comment by Vinayakam Mani on 09 June 2026, 15:56 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29707

  Check pressure limit.

Revision Comment by Vinayakam Mani on 09 June 2026, 15:59 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29708

  This function is not checking the level anymore and may be move
  the functionality at end of fill water end state and transition
  to next chamber fill state directly,

Revision Comment by Vinayakam Mani on 09 June 2026, 16:05 
https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2#c29709

  fix the typo in 'persistence' across the file.


---

ID: LEAHI-DD-FIRMWARE-LDT-4183-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-4183-2

Title: LEAHI-DD-FIRMWARE-LDT-4183_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 2/1:
Statement of Objectives:


State: Review

Author: Vendor - TEL - Sameer Poyil
Moderator: Vendor - TEL - Sameer Poyil
Reviewers: (4 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Sean Nash
     Vinayakam Mani
     Dara Navaei