This is a list of all comments for LEAHI-DD-FIRMWARE-LDT-618-2. Review Summary: No summary ---------------------------------------- File: firmware/App/Services/TDInterface.c Revision Comment by Sean Nash on 04 December 2025, 16:36 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25542 Even though we are giving the type a name at the bottom of the enum, we typically still want to give the enum a name up top here. See other enums throughout code for examples. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 17:35 > Updated Revision Comment by Sean Nash on 04 December 2025, 16:34 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25541 Typically we name this last one starting with "NUM_OF_" to help differentiate from the real enums (i.e. this one is just a count). Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 17:35 > Updated Revision Comment by Sean Nash on 04 December 2025, 16:37 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25543 In comments, we don't need to call attention to the fact that these can be overridden. Their primary purpose is to be the TD supplied treatment parameters. The fact that they can be overridden by Dialin is just an extra. Just write a normal comment. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 17:35 > Changed the comments Revision Comment by Sean Nash on 04 December 2025, 16:40 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25544 These are treatment parameters that happen to be overrideable. Change comment to "Initialize treatment parameters from TD." Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 17:37 > Changed Revision Comment by Dara Navaei on 04 December 2025, 14:14 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25523 Please use getU32override function and then typecast it. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 15:55 > Noted. Revision Comment by Sean Nash on 04 December 2025, 16:43 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25545 Add blank line before return statement. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 17:37 > Updated Revision Comment by Dara Navaei on 04 December 2025, 14:14 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25524 Please use getU32override function and then typecast it. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 15:55 > Noted. Revision Comment by Sean Nash on 04 December 2025, 16:43 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25546 Add blank line before return statement. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 17:37 > Updated Revision Comment by Sean Nash on 03 December 2025, 08:58 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25464 Add one more blank line here. Should be 2 blank lines above and 2 below this banner. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 16:03 > Updated Revision Comment by Sean Nash on 03 December 2025, 09:04 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25465 details should have specific lines (e.g. Inputs and Outputs). Generic function description should be in the brief section above. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 16:03 > Changed this section and rewritten Revision Comment by Sean Nash on 03 December 2025, 09:05 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25466 Add a space between if and (. Revision Comment by Sean Nash on 03 December 2025, 09:24 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25470 Should use existing override payload structure (the one with the index) located in TestSupport.h. Add an enum in this unit for the 5 DD treatment parameters so you can interpret the index field of the message payload to find the specific parameter that is being overridden. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 16:05 > Noted. Revision Comment by Sean Nash on 03 December 2025, 09:06 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25467 Add space between if and (. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 16:05 > Updated Revision Comment by Dara Navaei on 04 December 2025, 14:24 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25527 ( TRUE == isTestingActivated() ) && ( ovType != OVERRIDE_INVALID ) && ( ovType < NUM_OF_OVERRIDE_TYPES ) conditions are not needed because the override functions check them already. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 16:02 > Yeah, I removed this. Revision Comment by Dara Navaei on 04 December 2025, 14:29 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25528 You don't need the if statement. The override function will check it automatically. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 15:57 > Done. ---------------------------------------- File: firmware/App/Services/TDInterface.h Revision Comment by Sean Nash on 03 December 2025, 08:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25462 Remove extra blank line. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 16:05 > Removed Revision Comment by Sean Nash on 03 December 2025, 08:57 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25463 Remove extra blank line. Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 16:05 > Removed ---------------------------------------- File: MsgDefs.h Revision Comment by Dara Navaei on 04 December 2025, 14:30 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2#c25529 There are a few available messages at the top. Like MSG_ID_AVAILABLE_1. Could you please use one them? Reply by Vendor - TEL - Varshini Nagabooshanam on 04 December 2025, 15:59 > Yes, I used MSG_ID_AVAILABLE_2. --- ID: LEAHI-DD-FIRMWARE-LDT-618-2 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-618-2 Title: LEAHI-DD-FIRMWARE-LDT-618_DD: Add ability to override individual treatment parameters. Statement of Objectives: State: Closed Summary: Author: Vendor - TEL - Varshini Nagabooshanam Moderator: Vendor - TEL - Varshini Nagabooshanam Reviewers: (8 active, 2 completed*) Sean Nash (*) Dara Navaei (*) Vendor - TEL - Jashwant Gantyada Vendor - TEL - Arpita Srivastava Vinayakam Mani Michael Garthwaite Raghu Kallala Vendor - TEL - Sivvanarayana Kurapati Daniel Ho Vendor - TEL - Sameer Poyil