This is a list of all comments for LEAHI-DIALIN-LDT-2004-2.

Review Summary: No summary


----------------------------------------
File: leahi_dialin/dd/modules/conductivity_sensors.py
Revision Comment by Zoltan Miskolci on 26 January 2026, 12:23 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2004-2#c26681

  Can't we use the generic override?
  You just need to update 3 fields:
  
  msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST
  entity_name = 'DD Coductivity sensor model request'
  override_text = 'Sent'   or ''

  Reply by Michael Garthwaite on 26 January 2026, 12:29
  > fixed writing over the error count override.
  > 
  > Model ID isnt an override. Its a set as it does not revert
  > back to another value. FW will be looking for only 1 U32
  > instead of a TEST_OVERRIDE_PAYLOAD_T.
  > 
  > the generic override will cause the FW to always reject the
  > value since the payload size is not what is expected.

    Reply by Zoltan Miskolci on 26 January 2026, 15:11
    > It handles different size of payloads, and requests without
    > payload without having an issue, so I don't understand why
    > would it cause an issue.
    > you are sending a message with this msg id and this
    > payload, if the FW is expecting that, then it will work.
    > 
    > Should I rename the cmd_generic_override to like
    > cmd_generic_message_sender to be less confusing?

      Reply by Sean Nash on 26 January 2026, 22:43
      > If Michael is right, then f/w is not expecting an
      > override payload and so we shouldn't use the generic
      > override payload structure.

        Reply by Michael Garthwaite on 27 January 2026, 09:15
        > updated to use the generic override.
        > 
        > Both of you are correct, the generic override can be
        > used.
        > 
        > Since we pack the payload outside of the generic
        > override, for this situation we don't pack the reset
        > byte and therefore will stay as a U32 which satisfies
        > the FW constraint. The other concern I had was that the
        > FW would not reply back with a test ACK back to dialin
        > with this cmd, thus causing a timeout in the generic
        > override function. This is address as all messages in
        > the lookup table in FW will reply back with a test ACK.
        > 
        > Therefore im okay using the generic override method


---

ID: LEAHI-DIALIN-LDT-2004-2 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2004-2

Title: LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (6 active, 2 completed*)
     Zoltan Miskolci   (*)
     Sean Nash   (*)
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour
     Stephen Quong