This is a list of all comments for LEAHI-DIALIN-LDT-261-1.

Review Summary: No summary


----------------------------------------
File: leahi_dialin/ui/td_messaging.py
Revision Comment by Behrouz NematiPour on 27 May 2025, 02:56 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-261-1#c22092

  Please let's address all the hardcoded message IDs with Enums,
  I have two more comments, but let's do it all.

  Reply by Tiffany Mejia on 27 May 2025, 14:40
  > Fixed!

    Reply by Behrouz NematiPour on 28 May 2025, 14:18
    > Thanks
    > RESOLVED

Revision Comment by Behrouz NematiPour on 27 May 2025, 02:49 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-261-1#c22089

  Do we have an enum for this message defined?

  Reply by Tiffany Mejia on 27 May 2025, 14:05
  > This message is currently not implemented in the fw message
  > list. Sean Nash
  > 
  > Have made a temporary enum in dialin if its sufficient.

    Reply by Behrouz NematiPour on 28 May 2025, 14:17
    > That is sufficient. Thanks.
    > RESOLVED

Revision Comment by Behrouz NematiPour on 27 May 2025, 02:54 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-261-1#c22091

  Please remove all the default values for the function
  parameters to check for all the sent arguments, and ensure that
  when this function is called, no parameter is left as default,
  and all are set.
  Please check all the other functions as well.

  Reply by Tiffany Mejia on 27 May 2025, 14:40
  > Fixed!

    Reply by Behrouz NematiPour on 28 May 2025, 14:18
    > Thanks
    > RESOLVED

Revision Comment by Behrouz NematiPour on 27 May 2025, 02:52 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-261-1#c22090

  To be consistent better to change the name to:
  td_serial

  Reply by Tiffany Mejia on 27 May 2025, 14:39
  > Fixed!

    Reply by Behrouz NematiPour on 28 May 2025, 14:19
    > Thanks
    > RESOLVED

Revision Comment by Behrouz NematiPour on 27 May 2025, 02:48 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-261-1#c22088

  Do we have an enum for this message defined?

  Reply by Tiffany Mejia on 27 May 2025, 14:04
  > This message is currently not implemented in the fw message
  > list. [~snash]
  > 
  > Have made a temporary enum in dialin if its sufficient.

    Reply by Behrouz NematiPour on 28 May 2025, 14:19
    > Thanks
    > RESOLVED


---

ID: LEAHI-DIALIN-LDT-261-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-261-1

Title: LEAHI-DIALIN-LDT-261_Maintreatmentscreen SW Diagnosticsscreen
Statement of Objectives:


State: Closed

Summary: 

Author: Tiffany Mejia
Moderator: Tiffany Mejia
Reviewers: (5 active, 2 completed*)
     Dara Navaei   (*)
     Behrouz NematiPour   (*)
     Sean Nash
     jpaguio
     Vinayakam Mani
     Michael Garthwaite
     Daniel Ho