This is a list of all comments for LEAHI-DIALIN-LDT-2980-1.

Review Summary: No summary


----------------------------------------
File: leahi_dialin/fp/modules/temperatures.py
Revision Comment by Raghu Kallala on 20 January 2026, 11:00 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2980-1#c26457

  We should not allow overrides for newly added internal
  temperatures

  Reply by Zoltan Miskolci on 20 January 2026, 14:27
  > I didn't added any code for override.
  > I also can't stop anyone to send in an override command with
  > random numbers.
  > The allowing of override should be on the FW part, where
  > sending the override with (sensor_id, value, no reset)
  > should return false for those that are not accepted.

  Reply by Zoltan Miskolci on 21 January 2026, 08:35
  > Updated


---

ID: LEAHI-DIALIN-LDT-2980-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2980-1

Title: LEAHI-DIALIN-LDT-2980_Request: add ability to get the flowmeter measured internal temperature
Statement of Objectives:


State: Closed

Summary: 

Author: Zoltan Miskolci
Moderator: Zoltan Miskolci
Reviewers: (6 active, 3 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Raghu Kallala   (*)
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour
     Stephen Quong