This is a list of all comments for LEAHI-DIALIN-LDT-2998-1.

Review Summary: No summary


----------------------------------------
File: leahi_dialin/common/dd_defs.py
Revision Comment by Vinayakam Mani on 18 December 2025, 15:46 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2998-1#c25954

  Please move this to level sensor enum. this is not a
  conductivity sensor; it is a conductive Level sensor.

  Reply by Zoltan Miskolci on 18 December 2025, 16:19
  > Moved

----------------------------------------
File: leahi_dialin/dd/modules/levels.py
Revision Comment by Vinayakam Mani on 18 December 2025, 16:27 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2998-1#c25957

  like D63 level sensor, please add D98 level sensor throughout
  the units. Keep naming as D98_LEVEL ( instead of D98_COND)

  Reply by Zoltan Miskolci on 18 December 2025, 17:08
  > D98 has been renamed

Revision Comment by Vinayakam Mani on 18 December 2025, 16:29 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2998-1#c25958

  No reference of conductivity here. it should be a level sensor.

  Reply by Zoltan Miskolci on 18 December 2025, 17:08
  > Updated

----------------------------------------
File: leahi_dialin/dd/modules/temperature_sensors.py
Revision Comment by Vinayakam Mani on 18 December 2025, 16:24 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2998-1#c25956

  END_POS_FIELD_19?

  Reply by Zoltan Miskolci on 18 December 2025, 17:09
  > Fixed

----------------------------------------
File: leahi_dialin/dd/modules/valves.py
Revision Comment by Dara Navaei on 30 December 2025, 10:58 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2998-1#c26001

  Match with the firmware in LDT-2998.


---

ID: LEAHI-DIALIN-LDT-2998-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-2998-1

Title: LEAHI-DIALIN-LDT-2998_Update Dialin to support any B1.9 FW and/or HW changes (higher priority)
Statement of Objectives:


State: Review

Author: Zoltan Miskolci
Moderator: Zoltan Miskolci
Reviewers: (9 active, 0 completed*)
     Sean Nash
     Nicholas Ramirez
     Vendor - TEL - Varshini Nagabooshanam
     Tiffany Mejia
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei
     Behrouz NematiPour
     Stephen Quong