This is a list of all comments for LEAHI-DIALIN-LDT-3159-1.

Review Summary: No summary


----------------------------------------
File: leahi_dialin/common/msg_ids.py
Revision Comment by Sean Nash on 16 January 2026, 13:27 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3159-1#c26354

  DEF is short for de-featured?  Not clear, whatever it means.
  Maybe we shouldn't abbreviate.

  Reply by Zoltan Miskolci on 19 January 2026, 10:48
  > That's how it's called in the FW, I just copied it.
  > But yes, I suspect the Def is short for defeatured.

----------------------------------------
File: leahi_dialin/fp/filtration_purification.py
Revision Comment by Michael Garthwaite on 19 January 2026, 12:22 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3159-1#c26419

  This will always return 0 and delay init from completing by up
  to 0.5s as the user is not logged in at the time of init.

  Reply by Zoltan Miskolci on 20 January 2026, 10:21
  > Moved it into login request

Revision Comment by Sean Nash on 16 January 2026, 13:30 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3159-1#c26355

  Is this callback function coming from a received message?

  Reply by Zoltan Miskolci on 19 January 2026, 09:46
  > Based on it's code, doesn't look like it. That's why I
  > removed the publish to not mislead.

Revision Comment by Michael Garthwaite on 19 January 2026, 12:22 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3159-1#c26420

  The naming of this method is misleading as it sends the message
  to request defeatured status and it is retrieved in a separate
  callback. The 'get' implies that the value returned from this
  method is the defeatured status. The value returned is not the
  defeatured status but rather a T/F condition on if the FW
  replied back to dialin successfully.
  
  suggestion: cmd_request_defeatured_status()

  Reply by Zoltan Miskolci on 20 January 2026, 10:21
  > Renamed


---

ID: LEAHI-DIALIN-LDT-3159-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3159-1

Title: LEAHI-DIALIN-LDT-3159_[Request] A getter function to read the DD FW for the defeatureized state
Statement of Objectives:


State: Closed

Summary: 

Author: Zoltan Miskolci
Moderator: Zoltan Miskolci
Reviewers: (6 active, 3 completed*)
     Sean Nash   (*)
     Raghu Kallala   (*)
     Michael Garthwaite   (*)
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour
     Stephen Quong