This is a list of all comments for LEAHI-DIALIN-LDT-3160-1.

Review Summary: No summary


----------------------------------------
File: leahi_dialin/common/test_config_defs.py
Revision Comment by Raghu Kallala on 27 January 2026, 13:18 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26767

  Here is the latest list from fw
  
      TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW = 0,
  ///< Test configuration DD & FP enable Beta 1.0 hardware
      TEST_CONFIG_FIRST = TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW,
  ///< Test configuration first configuration.
      TEST_CONFIG_DD_DISABLE_BC_PRESSURE_ALARMS,
  ///< Test configuration DD disabling BC pressure alarms
      TEST_CONFIG_DD_ENABLE_DRY_BICARB,
  ///< Test configuration DD to use dry bicarb
      TEST_CONFIG_DD_ENABLE_4WIRE_RINSE_PUMP,
  ///< Test configuration DD enable 4-wire rinse pump.
      TEST_CONFIG_FP_SKIP_PRE_GEN_FLUSH,
  ///< Test configuration FP skip pre-gen flush
      TEST_CONFIG_DD_ENABLE_DIENER_1000_PUMP,
  ///< Test configuration to use diener 1000 pump for D48
      TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL,
  ///< Test configuration to switch to PWM control for D79
      TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL,
  ///< Test configuration DD enable spent chamber H fill
      TEST_CONFIG_DD_DISABLE_CONDUCTIVITY_ALARMS,
  ///< Test configuration to disable DD conductivity alarms
      TEST_CONFIG_FP_DISABLE_CONDUCTIVITY_ALARMS,
  ///< Test configuration to disable FP conductivity alarms
      TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL,
  ///< Test configuration to switch to open loop control for
  concentrate dosing
      TEST_CONFIG_DD_ENABLE_UF_TEMP_COMPENSATION,
  ///< Test configuration for enabling UF temperature
  compensation
      NUM_OF_TEST_CONFIGS
  ///< Number of test configuration.

Revision Comment by Vinayakam Mani on 27 January 2026, 11:32 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26752

  TEST_CONFIG_DD_ENABLE_DIENER_1000_PUMP

  Reply by Zoltan Miskolci on 27 January 2026, 11:34
  > renamed

Revision Comment by Vinayakam Mani on 27 January 2026, 11:35 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26754

  TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL.  On/Off control is
  default support.

  Reply by Zoltan Miskolci on 27 January 2026, 11:40
  > updated, thanks for the confirmation

Revision Comment by Vinayakam Mani on 27 January 2026, 11:37 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26755

  TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL

  Reply by Zoltan Miskolci on 27 January 2026, 11:40
  > updated

Revision Comment by Vinayakam Mani on 27 January 2026, 11:38 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26756

  ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB  => we can use
  only one of these. We can keep test config 2 ( may rename as
  ENABLE_DRY_BICARB) and 8 can be deleted.

  Reply by Zoltan Miskolci on 27 January 2026, 13:32
  > merged

Revision Comment by Vinayakam Mani on 27 January 2026, 11:42 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26759

  TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL

  Reply by Zoltan Miskolci on 27 January 2026, 13:32
  > renamed

Revision Comment by Vinayakam Mani on 27 January 2026, 11:44 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26760

  TEST_CONFIG_DD_ENABLE_UF_TEMP_COMP.  by default, temp
  compensation is disabled.

  Reply by Zoltan Miskolci on 27 January 2026, 13:32
  > renamed

Revision Comment by Vinayakam Mani on 27 January 2026, 11:48 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26761

  Please sync all of these with Firmware order of definitions.

  Reply by Zoltan Miskolci on 27 January 2026, 13:32
  > Updated based on FW

----------------------------------------
File: leahi_dialin/td/__init__.py
Revision Comment by Raghu Kallala on 28 January 2026, 09:00 
https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1#c26780

  why are we passing this exception?

  Reply by Zoltan Miskolci on 28 January 2026, 09:08
  > This was made for the UI team, but it slowing down the init
  > process and always throwing that error, that is not an error
  > and not affecting the SW VV and SYS teams. So removing them
  > to fasten the init process and to not have confusing messages


---

ID: LEAHI-DIALIN-LDT-3160-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3160-1

Title: LEAHI-DIALIN-LDT-3160_Beta Dialin Test Configs Needed
Statement of Objectives:


State: Closed

Summary: 

Author: Dara Navaei
Moderator: Dara Navaei
Reviewers: (8 active, 2 completed*)
     Vinayakam Mani   (*)
     Raghu Kallala   (*)
     Zoltan Miskolci
     Sean Nash
     Nicholas Ramirez
     Vendor - TEL - Varshini Nagabooshanam
     Tiffany Mejia
     Michael Garthwaite
     Behrouz NematiPour
     Stephen Quong