This is a list of all comments for LEAHI-DIALIN-LDT-3350-1. Review Summary: No summary ---------------------------------------- File: leahi_dialin/common/fp_defs.py Revision Comment by Dara Navaei on 02 February 2026, 16:38 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26934 Are these part of FPTemperatureSensorName class? Reply by Zoltan Miskolci on 03 February 2026, 14:13 > Yes, they are aliases that are used for example in Dialin's > temperature sensor module to decide which msg id to use for > the override. > Updating an alias's value when adding new entries to the enum > is easier then changing the last or first sensor type across > Dialin modules, which could be forgotten or missed. Revision Comment by Behrouz NematiPour on 02 February 2026, 16:32 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26931 same Reply by Behrouz NematiPour on 03 February 2026, 15:55 > Look in the td_defs.py for the same comment. Revision Comment by Behrouz NematiPour on 02 February 2026, 16:32 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26932 same Reply by Behrouz NematiPour on 03 February 2026, 15:55 > Look in the td_defs.py for the same comment. ---------------------------------------- File: leahi_dialin/common/dd_defs.py Revision Comment by Dara Navaei on 02 February 2026, 16:32 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26930 What is the use of this dictionary? Reply by Zoltan Miskolci on 03 February 2026, 14:11 > DialinEnum from_str function using it to match a strung to an > enum member. Converting the string to enum for cleaner code > in test cases. Revision Comment by Behrouz NematiPour on 02 February 2026, 16:32 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26928 Same here. Reply by Behrouz NematiPour on 03 February 2026, 15:55 > Look in the td_defs.py for the same comment. Revision Comment by Behrouz NematiPour on 02 February 2026, 16:32 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26929 same here Reply by Behrouz NematiPour on 03 February 2026, 15:55 > Look in the td_defs.py for the same comment. ---------------------------------------- File: leahi_dialin/common/td_defs.py Revision Comment by Nicholas Ramirez on 30 January 2026, 16:51 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26898 can you remove this Opode as MODE_TPAR is obsolete and update the rest of the enumeration Reply by Zoltan Miskolci on 30 January 2026, 16:55 > Removed Revision Comment by Behrouz NematiPour on 02 February 2026, 16:29 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26925 what are these? and do we need them? Reply by Zoltan Miskolci on 03 February 2026, 14:16 > It's a class containing all the enums of the def file. > Yes we need them as many other Framework and huge amount of > code are using them. Reply by Behrouz NematiPour on 03 February 2026, 15:52 > This is incorrect. > We should not create many objects for all the Enum classes > in an API, and we should not use memory that may not even > be in use. > We will keep it for now to unblock the rest of the team. Revision Comment by Behrouz NematiPour on 02 February 2026, 16:30 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26926 I thought we removed this. Reply by Zoltan Miskolci on 03 February 2026, 14:17 > Obviously not. > You were reminding me about backwards compatibility. This > variable and class ensures that even with this major refactor > to the enum structure, the current codebase remains working. Reply by Behrouz NematiPour on 03 February 2026, 15:51 > This design is incorrect, > For common codes, a proxy or a wrapper class should have > been implemented. > We will keep it for now to unblock the rest of the team. ---------------------------------------- File: build.sh Revision Comment by Dara Navaei on 02 February 2026, 16:49 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26940 Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else? Reply by Zoltan Miskolci on 03 February 2026, 14:25 > When building locally without all the parameters the > generated name throws an error during python pip install. > So this ensures that if no parameter is added, it uses the > default name which is compatible with pip install. > The " -+. " sequence is throwing an error. ---------------------------------------- File: leahi_dialin/common/__init__.py Revision Comment by Dara Navaei on 02 February 2026, 16:30 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26927 Is this the only import that is needed? Reply by Zoltan Miskolci on 03 February 2026, 14:09 > Yes ---------------------------------------- File: leahi_dialin/td/modules/events.py Revision Comment by Dara Navaei on 02 February 2026, 16:43 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1#c26937 Treatment Params have been removed from firmware. Reply by Zoltan Miskolci on 03 February 2026, 14:25 > removed commented out line --- ID: LEAHI-DIALIN-LDT-3350-1 https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3350-1 Title: LEAHI-DIALIN-LDT-3350_[Leahi-Dialin] Add from_str function to the enums Statement of Objectives: State: Review Author: Zoltan Miskolci Moderator: Zoltan Miskolci Reviewers: (8 active, 0 completed*) Nicholas Ramirez Sean Nash Tiffany Mejia Vinayakam Mani Michael Garthwaite Dara Navaei Behrouz NematiPour Stephen Quong