This is a list of all comments for LEAHI-DIALIN-LEAH-136-3. Review Summary: No summary ---------------------------------------- File: leahi_dialin/ro/reverse_osmosis.py Revision Comment by Sean Nash on 22 January 2025, 14:25 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21090 Wrong file name. Not treatment_delivery.py. I would actually prefer something like filtration_purification.py. Reply by Michael Garthwaite on 05 February 2025, 10:37 > Fixed. Thanks! Reply by Sean Nash on 05 February 2025, 12:30 > Do you disagree with name change? Reply by Michael Garthwaite on 06 February 2025, 10:00 > my bad. Now its fixed! I'll probably change the whole RO > directory to something like FP in a future update to stay > in sync with the naming of the subsystems ---------------------------------------- File: leahi_dialin/ro/modules/valves.py Revision Comment by Sean Nash on 22 January 2025, 14:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21100 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Revision Comment by Sean Nash on 22 January 2025, 14:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21101 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:57 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21131 Should be "...sends an RO valve data broadcast interval override command message." Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Reply by Sean Nash on 05 February 2025, 12:29 > I don't see fix. Reply by Michael Garthwaite on 06 February 2025, 09:58 > my bad. Now its fixed! Revision Comment by Sean Nash on 23 January 2025, 14:58 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21132 DG should be RO. Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/ro/modules/flow_sensors.py Revision Comment by Sean Nash on 22 January 2025, 14:51 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21095 Rename these per f/w refactoring changes. Revision Comment by Sean Nash on 22 January 2025, 14:51 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21096 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:41 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:46 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21121 Should be "Constructs and sends an RO flow sensor broadcast interval override command message." Reply by Michael Garthwaite on 05 February 2025, 10:41 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/ro/modules/conductivity_sensors.py Revision Comment by Sean Nash on 22 January 2025, 14:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21093 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 22 January 2025, 14:57 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21105 Try to remove references to spelled out "reverse osmosis" like this (throughout all RO classes). I would rephrase this as "Dialin API sub-class for RO conductivity sensor data access and override commands." Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 22 January 2025, 14:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21092 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:40 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21114 Should say "... published RO conductity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:36 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21109 These temperatures were moved to temperature sensors broadcast msg and should be captured in the temperatures class (when you create it) instead of here. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:40 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21113 Should say "... the RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Reply by Sean Nash on 05 February 2025, 12:24 > I don't see fix. Reply by Michael Garthwaite on 06 February 2025, 09:59 > my bad. Now its fixed! Revision Comment by Sean Nash on 22 January 2025, 14:59 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21106 DG should be RO. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:38 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21110 Should say "RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:40 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21112 Should say "... the RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:39 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21111 Should say "override RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:47 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21122 Since these temperatures will be broadcast by the Temperatures monitor f/w unit and captured by the temperatures RO Dialin class, I think this override command should also be moved to the temperatures class. Reply by Michael Garthwaite on 05 February 2025, 10:43 > method has been removed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:41 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21115 Should say "... the RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:42 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:41 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21116 Should say "override RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:42 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:41 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21117 Should say "... the RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:42 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:41 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21118 Should say "override RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:42 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:43 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21119 Should say "... the RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:42 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:43 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21120 Should say "override RO conductivity ..." here for specificity. Reply by Michael Garthwaite on 05 February 2025, 10:42 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/ro/modules/boost_pump.py Revision Comment by Sean Nash on 22 January 2025, 14:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21094 Rename these per f/w refactoring changes. Revision Comment by Sean Nash on 22 January 2025, 14:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21091 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 22 January 2025, 14:55 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21103 Handles published RO pump data messages (not blood). Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! Revision Comment by Sean Nash on 22 January 2025, 14:56 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21104 Change "measured blood flow" to "RO pump data". Reply by Michael Garthwaite on 05 February 2025, 10:43 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/ro/modules/levels.py Revision Comment by Sean Nash on 22 January 2025, 14:51 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21097 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:40 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:50 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21123 Should be "Constructs and sends an RO levels data broadcast interval override command message." Reply by Michael Garthwaite on 05 February 2025, 10:40 > Fixed. Thanks! ---------------------------------------- File: leahi_dialin/ro/modules/pressure_sensors.py Revision Comment by Sean Nash on 22 January 2025, 14:51 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21098 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Revision Comment by Sean Nash on 22 January 2025, 14:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21099 Rename these per f/w refactoring changes. Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:54 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21129 Not pressure and occlusion data. Just RO pressure data. Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:51 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21124 Should be "... sends a measured RO pressure override command message." Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Reply by Sean Nash on 05 February 2025, 12:27 > I don't see the fix. Reply by Michael Garthwaite on 06 February 2025, 09:59 > my bad. Now its fixed! Revision Comment by Sean Nash on 23 January 2025, 14:53 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21128 Not arterial pressure. Reply by Michael Garthwaite on 05 February 2025, 10:38 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:55 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21130 Remove "(measured))". Reply by Michael Garthwaite on 05 February 2025, 10:39 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:52 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21125 Remove "measured". Say "... pressure data broadcast ...". Reply by Michael Garthwaite on 05 February 2025, 10:40 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:53 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21126 Not blood flow. Reply by Michael Garthwaite on 05 February 2025, 10:40 > Fixed. Thanks! Revision Comment by Sean Nash on 23 January 2025, 14:53 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3#c21127 Not blood flow. Reply by Michael Garthwaite on 05 February 2025, 10:40 > Fixed. Thanks! --- ID: LEAHI-DIALIN-LEAH-136-3 https://devapps.diality.us/cru/LEAHI-DIALIN-LEAH-136-3 Title: LEAH-136-dial-ro-base-object Statement of Objectives: * Merge branch 'LEAH-142-dial-td-base-object' into LEAH-136-dial-ro-base-object * WIP on LEAH-136-dial-ro-base-object RO override modules * Merge branch 'LEAH-142-dial-td-base-object' into LEAH-136-dial-ro-base-object * Moving modules to folder updated naming and handlers * moved constants folder. Updated Ro valves * updated pathing for imports * Merge branch 'LEAH-142-dial-td-base-object' into develop fixed RO login message * WIP on develop fixed ro values override msg id * WIP on develop fixed ro boost pump overrides * fixed override. * WIP on develop fixed set pwm to not be an override * WIP on develop fixed boost pump pwm * WIP on develop fixed set pwm * WIP on develop documentation fixes * fixed boost pump import. fixed valve doc string * WIP on develop added init file for build script * updated boost pump documentation * Added flow sensor module. minor updates across other modules * added RO conductivity module. * fixed ro flow sensor registering an unknown method * updated RO valves with SPP valve. * fixed ro valve positioning * WIP on develop added flow sensors and conductivity to ro main module * Merge branch 'staging' into LEAH-136-dial-ro-base-object State: Closed Summary: Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (4 active, 2 completed*) Sean Nash (*) Tiffany Mejia (*) jpaguio Vinayakam Mani Dara Navaei Behrouz NematiPour