This is a list of all comments for LEAHI-RO-FIRMWARE-LDT-2116-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/PermeateTank.c Revision Comment by Vendor - TEL - Sameer Poyil on 24 November 2025, 10:17 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25259 is this year correct ? Reply by Raghu Kallala on 01 December 2025, 12:27 > Once Dara enable the copyright script, that will handle it Revision Comment by Vendor - TEL - Sameer Poyil on 18 November 2025, 19:56 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25184 comment start with capital letter. check all other places. Revision Comment by Raghu Kallala on 28 October 2025, 08:41 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24871 Safe to define a const and used it here instead of passing 700 Reply by Sean Nash on 29 October 2025, 10:07 > 750 now? Reply by Michael Garthwaite on 03 November 2025, 09:11 > set to 750 for all controlled flows. ---------------------------------------- File: firmware/App/Controllers/ROPump.c Revision Comment by Raghu Kallala on 28 October 2025, 08:53 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24873 Align comments spacing Reply by Michael Garthwaite on 03 November 2025, 09:11 > fixed. thanks! Revision Comment by Raghu Kallala on 28 October 2025, 08:43 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24872 TargetDutyCycle is F32 override Reply by Michael Garthwaite on 03 November 2025, 09:11 > fixed. Thanks! Revision Comment by Sean Nash on 21 October 2025, 08:43 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24753 Are these just temporarily being published for tuning? Reply by Michael Garthwaite on 03 November 2025, 09:12 > temporary. Reverted back to original publishing data. ---------------------------------------- File: firmware/App/Modes/FlushConcentrate.c Revision Comment by Sean Nash on 29 October 2025, 10:08 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24913 750? Reply by Michael Garthwaite on 03 November 2025, 09:11 > set to 750 for all controlled flows. Revision Comment by Sean Nash on 03 November 2025, 10:57 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24969 Remove blank line. Reply by Raghu Kallala on 22 November 2025, 12:52 > Fixed. Thanks Revision Comment by Sean Nash on 29 October 2025, 10:09 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24914 Space between if and (. Reply by Michael Garthwaite on 03 November 2025, 09:10 > fixed. Thanks! Revision Comment by Sean Nash on 29 October 2025, 10:10 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24916 Keep blank line between functions. Reply by Michael Garthwaite on 03 November 2025, 09:10 > fixed. Thanks! Revision Comment by Sean Nash on 29 October 2025, 10:09 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24915 Space between if and (. Reply by Michael Garthwaite on 03 November 2025, 09:10 > fixed. Thanks! ---------------------------------------- File: firmware/App/Modes/ModePreGenPermeate.c Revision Comment by Sean Nash on 03 November 2025, 10:58 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24970 Add blank line between declarations and rest of code. Revision Comment by Sean Nash on 03 November 2025, 11:00 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c24971 Consider doing this manual control in a function and call it from here. ---------------------------------------- File: firmware/App/Modes/ModeGenPermeate.c Revision Comment by Sean Nash on 21 November 2025, 08:47 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25210 Remove blank line. Reply by Raghu Kallala on 22 November 2025, 12:36 > Fixed. Thanks Revision Comment by Sean Nash on 20 November 2025, 09:29 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25205 Add blank line between declarations and code. Reply by Raghu Kallala on 22 November 2025, 12:36 > Fixed. Thanks Revision Comment by Sean Nash on 20 November 2025, 09:30 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25206 Add blank line between declarations and code. Reply by Raghu Kallala on 22 November 2025, 12:36 > Fixed. Thanks Revision Comment by Sean Nash on 20 November 2025, 09:30 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25207 Add blank line between declarations and code. Reply by Raghu Kallala on 22 November 2025, 12:37 > Fixed. Thanks Revision Comment by Sean Nash on 20 November 2025, 09:30 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25208 Remove blank line. Reply by Raghu Kallala on 22 November 2025, 12:37 > Fixed. Thanks Revision Comment by Sean Nash on 20 November 2025, 09:30 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25209 Remove blank line. Reply by Raghu Kallala on 22 November 2025, 12:37 > Fixed. Thanks ---------------------------------------- File: firmware/App/Monitors/Conductivity.c Revision Comment by Vendor - TEL - Sameer Poyil on 18 November 2025, 20:05 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25185 do not use magic numbers Reply by Raghu Kallala on 22 November 2025, 12:52 > Fixed. Thanks ---------------------------------------- File: firmware/App/Monitors/Conductivity.h Revision Comment by Vendor - TEL - Sameer Poyil on 01 December 2025, 09:19 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25332 Structure packing statement missing. add it even if not required Revision Comment by Vendor - TEL - Sameer Poyil on 08 December 2025, 18:46 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25642 comments should start with capital letter ---------------------------------------- File: firmware/App/Services/Messaging.c Revision Comment by Vendor - TEL - Sameer Poyil on 18 November 2025, 20:10 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25186 copy right file header missing Reply by Raghu Kallala on 24 November 2025, 10:13 > Resolved Thanks Revision Comment by Vendor - TEL - Sameer Poyil on 18 November 2025, 20:14 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25187 use complete word as in line 87 and 88 , PRESSURE Reply by Raghu Kallala on 24 November 2025, 10:08 > Will fix on Beta branch to avoid changes to Dialin Revision Comment by Vendor - TEL - Sameer Poyil on 18 November 2025, 20:16 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1#c25188 let RO comes first , MSG_ID_FP_RO_FILTERED_REJECTION_RATIO Reply by Raghu Kallala on 22 November 2025, 12:40 > Fixed. Thanks --- ID: LEAHI-RO-FIRMWARE-LDT-2116-1 https://devapps.diality.us/cru/LEAHI-RO-FIRMWARE-LDT-2116-1 Title: LEAHI-RO-FIRMWARE-LDT-2116_IOFP - Evaluate closing P39 during tank full state Statement of Objectives: State: Review Author: Michael Garthwaite Moderator: Michael Garthwaite Reviewers: (10 active, 0 completed*) Vendor - TEL - Jashwant Gantyada Vendor - TEL - Arpita Srivastava Vendor - TEL - Varshini Nagabooshanam Sean Nash jpaguio Vinayakam Mani Raghu Kallala Dara Navaei Daniel Ho Vendor - TEL - Sameer Poyil