This is a list of all comments for LEAHI-SW-LDT-261-2. Review Summary: No summary ---------------------------------------- File: sources/canbus/MessageGlobals.h Revision Comment by Behrouz NematiPour on 28 May 2025, 15:05 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22110 The BOOL in FW is 4 bytes (U32). Please update the length in the model as well. Reply by Behrouz NematiPour on 30 May 2025, 09:10 > RESOLVED. Revision Comment by Behrouz NematiPour on 28 May 2025, 15:19 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22111 Please add a TODO and a summary stating that "The payload is TBD (as indicated by the provided screen items)". Reply by Behrouz NematiPour on 30 May 2025, 09:11 > RESOLVED Revision Comment by Behrouz NematiPour on 28 May 2025, 15:22 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22112 Please add a TODO and a summary stating that "The payload is TBD (as indicated by the provided screen items)". Reply by Behrouz NematiPour on 30 May 2025, 09:12 > RESOLVED Revision Comment by Behrouz NematiPour on 28 May 2025, 15:38 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22113 Please update these to the following: {code} ​    {Gui::GuiActionType::ID_AdjustVersionsHDRsp                     ,3*1+2+4*1+4}, // variable length parameters    {Gui::GuiActionType::ID_AdjustVersionsDGRsp                     ,3*1+2+4*1+4}, // variable length parameters {code} We are also getting this fixed on the Denali. Reply by Behrouz NematiPour on 30 May 2025, 09:12 > RESOLVED ---------------------------------------- File: sources/gui/GuiGlobals.h Revision Comment by Behrouz NematiPour on 28 May 2025, 17:21 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22120 Please also complete the DD version request. We missed the DD one in the Model View. - Add any necessary plugins to the simulator as needed. - Add a section/component for it on the same page as the others (we do not separate TD,DD for now) Reply by Tiffany Mejia on 03 June 2025, 09:16 > Completed DD Version response model, please review Reply by Behrouz NematiPour on 05 June 2025, 10:06 > RESOLVED Revision Comment by Behrouz NematiPour on 28 May 2025, 15:57 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22115 Add TODO. - Here - Model class description Reply by Behrouz NematiPour on 05 June 2025, 10:08 > RESOLVED Revision Comment by Behrouz NematiPour on 28 May 2025, 14:48 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22107 Please change this to CRAPIZED. Use the Denali ID with either FF at the end or 0F. To avoid confusion about whether that is the implementation. Reply by Behrouz NematiPour on 30 May 2025, 09:14 > RESOLVED Revision Comment by Behrouz NematiPour on 28 May 2025, 14:49 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22108 Please change this to CRAPIZED. Use the Denali ID with either FF at the end or 0F. To avoid confusion about whether that is the implementation. Reply by Behrouz NematiPour on 30 May 2025, 09:20 > RESOLVED Revision Comment by Behrouz NematiPour on 28 May 2025, 14:52 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22109 Please briefly explain what is going to be done in the same line. E.g., not implemented in FW, subject to change. Reply by Behrouz NematiPour on 30 May 2025, 09:24 > RESOLVED ---------------------------------------- File: sources/model/hd/adjustment/settings/MAdjustTDSerialNumberResponse.h Revision Comment by Behrouz NematiPour on 28 May 2025, 17:15 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22119 - Please update to TD. - Update the message ID. Reply by Behrouz NematiPour on 05 June 2025, 10:07 > RESOLVED ---------------------------------------- File: sources/storage/Logger.cpp Revision Comment by Behrouz NematiPour on 28 May 2025, 17:31 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22121 Please refactor the _logFileNameHDSN to _logFileNameTDSN. Reply by Behrouz NematiPour on 30 May 2025, 09:25 > RESOLVED ---------------------------------------- File: sources/view/settings/VBluetooth.h Revision Comment by Behrouz NematiPour on 28 May 2025, 17:41 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22122 Please remove this include. This should be a leftover of the Denali project. Reply by Tiffany Mejia on 03 June 2025, 09:23 > fixed! Reply by Behrouz NematiPour on 05 June 2025, 09:59 > RESOLVED ---------------------------------------- File: sources/model/hd/adjustment/settings/MAdjustTDVersionsRequest.h Revision Comment by Behrouz NematiPour on 28 May 2025, 17:12 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22118 Please update to TD Reply by Tiffany Mejia on 03 June 2025, 09:21 > fixed! Reply by Behrouz NematiPour on 05 June 2025, 10:07 > RESOLVED ---------------------------------------- File: sources/model/hd/data/MTDAirTrapData.cpp Revision Comment by Behrouz NematiPour on 29 May 2025, 11:42 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22126 Out of curiosity, did you test the U32 to bool without any direct conversion during your development testing? Reply by Tiffany Mejia on 29 May 2025, 14:49 > No I did not, I forced testing as bool on the simulator. Reply by Behrouz NematiPour on 05 June 2025, 10:03 > I am resolving this. Please take a quick test on this > specific parameter for later development confidence. > RESOLVED ---------------------------------------- File: sources/model/hd/data/MTDAirTrapData.h Revision Comment by Behrouz NematiPour on 29 May 2025, 11:35 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22124 TD Reply by Tiffany Mejia on 03 June 2025, 09:22 > fixed! Reply by Behrouz NematiPour on 05 June 2025, 10:01 > RESOLVED Revision Comment by Behrouz NematiPour on 29 May 2025, 11:37 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22125 Please update the CAN ID ( AKA channel ) according to the following table from the following link (should be 0x100 since the DST is All/Broadcast): Also, on the other models. Channel Description 1 TD Alarm Broadcast 2 DD Alarm Broadcast 3 FP Alarm Broadcast 4 UI Alarm Broadcast 10 TD to DD 11 DD to TD 20 DD to FP 21 FP to DD 40 TD to UI 41 UI to TD 101 DD to UI 103 UI to DD 100 TD Broadcast 101 DD Broadcast 102 FP Broadcast 103 UI Broadcast 400 Dialin to TD 401 TD to Dialin 402 Dialin to DD 403 DD to Dialin 404 Dialin to FP 405 FP to Dialin https://easydialhdbs.sharepoint.com/:x:/r/sites/FCRProject/Shared%20Documents/General/06_Software%20Design/05_Software_Design/Leahi%20Message%20List.xlsx?d=w8e3cf6a72be24bb882c6098b124bb2c5&csf=1&web=1&e=ozZVi0&nav=MTJfJEEkMTokQiQyM197RTQwREIyRkItMjI5NS00MDM3LTk3MEItOTUzNTg4Qzg4NjUzfQ Reply by Tiffany Mejia on 03 June 2025, 09:22 > fixed! Reply by Behrouz NematiPour on 05 June 2025, 10:01 > RESOLVED Revision Comment by Behrouz NematiPour on 29 May 2025, 11:35 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22123 Please change this to U32. Reply by Tiffany Mejia on 03 June 2025, 09:22 > fixed! Reply by Behrouz NematiPour on 05 June 2025, 10:01 > RESOLVED ---------------------------------------- File: sources/model/hd/data/MTDBatteryData.h Revision Comment by Behrouz NematiPour on 29 May 2025, 11:46 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2#c22127 - TD - Channel Please add a TODO to ensure we address this later when the message is fully defined. Reply by Tiffany Mejia on 03 June 2025, 09:23 > fixed! Reply by Behrouz NematiPour on 05 June 2025, 10:00 > RESOLVED --- ID: LEAHI-SW-LDT-261-2 https://devapps.diality.us/cru/LEAHI-SW-LDT-261-2 Title: LEAHI-SW-LDT-261_ Statement of Objectives: State: Closed Summary: Author: Tiffany Mejia Moderator: Tiffany Mejia Reviewers: (4 active, 2 completed*) Dara Navaei (*) Behrouz NematiPour (*) Sean Nash Vinayakam Mani Michael Garthwaite Daniel Ho