This is a list of all comments for LEAHI-SW-LDT-627-1. Review Summary: No summary ---------------------------------------- File: DD_Conductivity/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 12:05 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22548 Please remove these Reply by Behrouz NematiPour on 01 July 2025, 13:06 > RESOLVED ---------------------------------------- File: DD_GenDialysate/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 12:26 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22550 Please change this to "floater". Reply by Behrouz NematiPour on 01 July 2025, 13:05 > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 12:38 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22551 I don't remember if I did, but have you tested if we have any problem with the direct conversion of the bool to an unsigned integer? shouldn't we convert it here with Qt conversion functions? Reply by Behrouz NematiPour on 30 June 2025, 17:42 > Found the code that we discussed for this conversion. > Please do the same here: > http://devapps.diality.us:8060/cru/LEAHI-SW-LDT-627-1#CFR-68014 Reply by Tiffany Mejia on 01 July 2025, 00:06 > It is already being done the same way. the int() handles > bool to integer conversion with no issues Reply by Behrouz NematiPour on 01 July 2025, 13:06 > Didn't notice. > RESOLVED ---------------------------------------- File: MainTreatmentData/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 15:23 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22586 Please add the reset and send button. Reply by Tiffany Mejia on 01 July 2025, 00:08 > They are not needed as they are handled by any change to any > slider/spinbox Reply by Behrouz NematiPour on 01 July 2025, 13:03 > As we discussed, and I posted the comment on another one, > please add these two regardless. Reply by Behrouz NematiPour on 03 July 2025, 12:34 > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 17:32 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22591 align Reply by Behrouz NematiPour on 01 July 2025, 13:04 > RESOLVED ---------------------------------------- File: TD_AirTrap/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 17:33 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22593 Please remove. Reply by Behrouz NematiPour on 01 July 2025, 13:02 > RESOLVED ---------------------------------------- File: TD_Battery/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 17:41 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22598 Bookmark for another comment. Reply by Behrouz NematiPour on 01 July 2025, 13:02 > RESOLVED ---------------------------------------- File: TD_Pressures/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 17:45 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22603 Add the reset and send buttons. Reply by Tiffany Mejia on 01 July 2025, 00:43 > I utilize the sliders and auto change of any of the > components so send and reset buttons are not needed. I can > demo Reply by Behrouz NematiPour on 01 July 2025, 12:56 > I know. > But imagine you want to send what has already been adjusted > without any slider change. > With your idea, you then have to move the slider to send a > message, which may not be the same as the previous one, > depending on your slider resolution and how difficult it is > to set to the same value. Reply by Behrouz NematiPour on 03 July 2025, 12:33 > fixed, > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 17:44 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22601 align the = Reply by Behrouz NematiPour on 01 July 2025, 13:00 > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 17:44 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22602 align the commas Reply by Behrouz NematiPour on 01 July 2025, 13:01 > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 17:46 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22604 Please do not wrap the lines. Align the .setText and parentheses. Reply by Behrouz NematiPour on 01 July 2025, 13:01 > Not exactly what I meant, but it is fine. > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 17:47 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22605 Please align the "(" so the MIN, MAX, DEF get aligned. Reply by Behrouz NematiPour on 01 July 2025, 13:02 > RESOLVED ---------------------------------------- File: TD_Ejector/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 17:43 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22600 align .value() Reply by Behrouz NematiPour on 01 July 2025, 13:02 > RESOLVED ---------------------------------------- File: TD_TreatmentStates/loader.py Revision Comment by Behrouz NematiPour on 30 June 2025, 17:49 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22607 Not needed, please remove. I had this in old versions, but it was unnecessary. Reply by Tiffany Mejia on 03 July 2025, 10:35 > fixed! Reply by Behrouz NematiPour on 03 July 2025, 12:30 > RESOLVED Revision Comment by Behrouz NematiPour on 30 June 2025, 17:48 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22606 align with the rest Reply by Behrouz NematiPour on 03 July 2025, 12:30 > will take care of it later. Revision Comment by Behrouz NematiPour on 30 June 2025, 17:51 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1#c22608 align 0s and .value/s Reply by Behrouz NematiPour on 01 July 2025, 12:51 > RESOLVED --- ID: LEAHI-SW-LDT-627-1 https://devapps.diality.us/cru/LEAHI-SW-LDT-627-1 Title: LDT-627 - Main Treatment Screen SW - Messaging Broadcast - Simulator Plugins Statement of Objectives: State: Closed Summary: Author: Tiffany Mejia Moderator: Tiffany Mejia Reviewers: (5 active, 2 completed*) Nicholas Ramirez (*) Behrouz NematiPour (*) Sean Nash Vinayakam Mani Michael Garthwaite Dara Navaei Daniel Ho