This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-1394-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/BloodFlow.c
Revision Comment by Sean Nash on 02 March 2026, 10:41 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1#c27681

  I think this whole function should be moved to the
  PeristalticPump.c driver unit.  We don't want
  controller/monitor level units directly accessing fpga
  registers - the drivers should be doing that.

  Reply by Vendor - TEL - Jashwant Gantyada on 02 March 2026, 13:32
  > removed and added.

Revision Comment by Sean Nash on 02 March 2026, 11:15 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1#c27682

  Converting U16 to U32.  Presumably, U16 will wrap back to zero
  when it gets to 65535.  We don't want our U32 to wrap, so we
  need to do something to handle this conversion properly.

  Reply by Vendor - TEL - Jashwant Gantyada on 02 March 2026, 13:32
  > handled accordingly.

----------------------------------------
File: firmware/App/Drivers/PeristalticPump.c
Revision Comment by Sean Nash on 02 March 2026, 13:58 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1#c27698

  Update I/O section here to include rotor revs accumulated and
  previous.

  Reply by Vendor - TEL - Jashwant Gantyada on 02 March 2026, 14:13
  > done.


---

ID: LEAHI-TD-FIRMWARE-LDT-1394-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1394-1

Title: LEAHI-TD-FIRMWARE-LDT-1394_Blood Flow Rate - TD - 04: DEV - Feature Implementation
Statement of Objectives:


State: Review

Author: Vendor - TEL - Jashwant Gantyada
Moderator: Vendor - TEL - Jashwant Gantyada
Reviewers: (2 active, 0 completed*)
     Sean Nash
     Dara Navaei