This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-1415-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Monitors/Pressures.c Revision Comment by Sean Nash on 26 January 2026, 13:28 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26685 Does ModeTxParams.h exist? Didn't we change this to a service? Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 12:53 > Once I get latest staging I will update this Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:05 > Updated Revision Comment by Sean Nash on 02 February 2026, 11:03 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26916 Shouldn't we be getting these defaults from the TxParams unit? Reply by Vendor - TEL - Varshini Nagabooshanam on 02 February 2026, 11:42 > Yes, we do and this is not required here so, I removed Revision Comment by Sean Nash on 26 January 2026, 13:30 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26686 Missing comment to right Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 11:26 > Added Reply by Sean Nash on 28 January 2026, 14:40 > Fix spelling in comment (membrane should not have a 'c' in > it). Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:04 > Sorry, Updated Revision Comment by Sean Nash on 26 January 2026, 13:31 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26687 When comment is too far to right to align with other comments, use the following comment format: /// comment... #define ... Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 11:26 > Updated Reply by Sean Nash on 28 January 2026, 14:41 > I don't see it. Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:05 > Updated Revision Comment by Sean Nash on 26 January 2026, 13:32 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26688 Why do I not see a similar variable for arterial and venous pressures? Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 11:22 > Added Reply by Sean Nash on 28 January 2026, 14:48 > You added them, but you're not really using them and you're > not using the tmp override either as far as I can see. Do > we need any of these? Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:05 > Yes we need to add Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 14:04 > I removed Revision Comment by Sean Nash on 29 January 2026, 13:23 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26845 Add space between = and (F32) Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 13:29 > Updated Revision Comment by Sean Nash on 26 January 2026, 13:48 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26689 Can we do the separate outer bounds inside the setPressureLimitsToOuterBounds() function? Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 11:26 > Updated Revision Comment by Sean Nash on 26 January 2026, 13:49 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26690 We need to set the current state to PRESSURE_LIMITS_STATE_STABLE here I think. Otherwise, how will we get to stable state? Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 12:52 > Updated Revision Comment by Sean Nash on 26 January 2026, 13:51 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26691 Why are we keeping any code where the STABILIZATION_2 state used to be? Shouldn't the entire case be deleted? Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 12:52 > Yes, deleted Revision Comment by Sean Nash on 26 January 2026, 13:53 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26693 Is there still a requirement to re-stabilize every 15 minutes (or some interval) in Leahi? It looks like Denali had such a requirement and it would jump back to STABILIZATION_2 state to do it. Since we don't have a STABILIZATION_2 state, we would need to jump back to STABILIZATION state instead. Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 12:52 > Updated Revision Comment by Sean Nash on 26 January 2026, 13:52 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26692 Fix indent on this case. Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 12:52 > Fixed Revision Comment by Sean Nash on 26 January 2026, 13:57 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26695 Why are we making this change? It doesn't look correct to have a LongCount capped with a ShortCount and SIZE. ---------------------------------------- File: AlarmDefs.h Revision Comment by Sean Nash on 26 January 2026, 13:24 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26683 Add the word "pressure" after TMP in comments. Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 11:23 > Added Revision Comment by Sean Nash on 26 January 2026, 13:25 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26684 TxLog property should be TRUE. NoDRcr property is FALSE in arterial/venous alarms - is there a reason why TMP is different? Priority should be HIGH. Rank should be somewhere around 200 (see if PRS specifies or ask Eliza what it should be). Reply by Vendor - TEL - Varshini Nagabooshanam on 28 January 2026, 11:23 > Yes, Updated Revision Comment by Sean Nash on 28 January 2026, 14:36 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26793 TMP low and high pressure alarms should be here I think. Revision Comment by Sean Nash on 29 January 2026, 13:17 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26843 Align | separators all the way to right end of these 2 rows. Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 13:29 > Updated ---------------------------------------- File: firmware/App/Drivers/PressureSensor.c Revision Comment by Sean Nash on 28 January 2026, 14:37 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26795 Align function name with others (1 more space before name). Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:06 > Updated Revision Comment by Sean Nash on 28 January 2026, 14:38 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26796 I would say inputs and outputs are "none". Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:06 > Added Revision Comment by Sean Nash on 28 January 2026, 14:38 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26798 Missing param. Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:06 > Added Reply by Sean Nash on 29 January 2026, 13:19 > Added param looks wrong. Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 14:04 > Sorry, updated Revision Comment by Sean Nash on 28 January 2026, 14:38 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26797 This function does not return next state. Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 12:07 > No, by mistake I copy pasted the same Revision Comment by Sean Nash on 29 January 2026, 14:14 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26856 Format for params is: param name description Add "psi" (name) between param and "Pressure value in PSI". Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 14:17 > Updated Reply by Vendor - TEL - Varshini Nagabooshanam on 29 January 2026, 14:25 > Updated ---------------------------------------- File: firmware/App/TDCommon.h Revision Comment by Sean Nash on 02 February 2026, 09:18 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1#c26900 I think this should be commented out before we merge to staging. Reply by Vendor - TEL - Varshini Nagabooshanam on 02 February 2026, 09:48 > Yes, Updated --- ID: LEAHI-TD-FIRMWARE-LDT-1415-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1415-1 Title: LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD Statement of Objectives: State: Review Author: Vendor - TEL - Varshini Nagabooshanam Moderator: Vendor - TEL - Varshini Nagabooshanam Reviewers: (10 active, 0 completed*) Vendor - TEL - Arpita Srivastava Vendor - TEL - Jashwant Gantyada Sean Nash Vinayakam Mani Michael Garthwaite Raghu Kallala Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Daniel Ho Vendor - TEL - Sameer Poyil