This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-2749-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Monitors/Bubbles.c
Revision Comment by Sean Nash on 29 January 2026, 10:55 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26815

  This is not necessary - bubbleDetectionEnabled[] above takes
  care of this.  Remove.

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:04
  > removed

Revision Comment by Sean Nash on 29 January 2026, 10:55 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26816

  Not needed.  Remove.

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:04
  > done.

Revision Comment by Sean Nash on 29 January 2026, 13:03 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26841

  Remove blank line.

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 13:49
  > removed.

Revision Comment by Vendor - TEL - Sameer Poyil on 02 February 2026, 16:44 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26938

  input parameter is not updated

Revision Comment by Vendor - TEL - Sameer Poyil on 02 February 2026, 16:44 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26939

  input parameter not updated

Revision Comment by Vendor - TEL - Sameer Poyil on 02 February 2026, 16:40 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26936

  input and output is not updated properly

Revision Comment by Sean Nash on 29 January 2026, 10:56 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26817

  Update function name to match actual name.  Remove references
  to standby mode - function should work in any mode.

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:04
  > done.

Revision Comment by Sean Nash on 29 January 2026, 10:57 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26818

  Not an override command.  We want to update
  bubbleDetectionEnabled[] for the venous sensor (index 0) to the
  given T/F state.

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:04
  > updated.

Revision Comment by Sean Nash on 29 January 2026, 13:05 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26842

  I would make another local variable (BOOL) above and set it per
  trinary operation and then pass the BOOL to the function.
  I think we want to avoid complex logic or function calls as a
  function parameter per our coding standards.

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 13:49
  > done.

    Reply by Sean Nash on 29 January 2026, 13:53
    > Please keep local declarations together up top.

      Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 14:02
      > done.

Revision Comment by Sean Nash on 29 January 2026, 10:58 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26819

  Check msg payload length, set result to TRUE and set enable
  only if length is correct.

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:04
  > done.

----------------------------------------
File: firmware/App/Monitors/Bubbles.h
Revision Comment by Vendor - TEL - Sameer Poyil on 02 February 2026, 16:33 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26933

  structure packing required

Revision Comment by Sean Nash on 29 January 2026, 10:52 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26813

  testEnableVenousBubbleAlarm?

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:04
  > done.

----------------------------------------
File: firmware/App/Services/Messaging.c
Revision Comment by Sean Nash on 29 January 2026, 10:53 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26814

  MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM?

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:05
  > done.

----------------------------------------
File: MsgDefs.h
Revision Comment by Sean Nash on 29 January 2026, 11:00 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1#c26820

  MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

  Reply by Vendor - TEL - Jashwant Gantyada on 29 January 2026, 12:02
  > done


---

ID: LEAHI-TD-FIRMWARE-LDT-2749-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-2749-1

Title: LEAHI-TD-FIRMWARE-LDT-2749_Ability to Enable Air Bubble Alarm in Standby Mode
Statement of Objectives:


State: Review

Author: Vendor - TEL - Jashwant Gantyada
Moderator: Vendor - TEL - Jashwant Gantyada
Reviewers: (8 active, 1 completed*)
     Sean Nash   (*)
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Varshini Nagabooshanam
     Vinayakam Mani
     Michael Garthwaite
     Raghu Kallala
     Vendor - TEL - Sivvanarayana Kurapati
     Daniel Ho
     Vendor - TEL - Sameer Poyil