This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-4013-1.

Review Summary: No summary


----------------------------------------
File: TDDefs.h
Revision Comment by Sean Nash on 20 May 2026, 10:59 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29222

  Add fluid bolus state

Revision Comment by Sean Nash on 20 May 2026, 10:59 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29223

  Add fluid bolus state

Revision Comment by Sean Nash on 20 May 2026, 10:58 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29221

  FLUID_BOLUS_CMD_EVENT

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by Sean Nash on 20 May 2026, 11:06 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29225

  Should always exec your bolus sm.

----------------------------------------
File: firmware/App/Modes/StateTxBloodPrime.c
Revision Comment by Sean Nash on 20 May 2026, 11:20 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29229

  Move up with rest

Revision Comment by Sean Nash on 20 May 2026, 11:24 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29230

  signal functions should return BOOL.

Revision Comment by Sean Nash on 20 May 2026, 11:24 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29231

  return FALSE on else

----------------------------------------
File: firmware/App/Services/FluidBolus.c
Revision Comment by Sean Nash on 20 May 2026, 11:41 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29235

  Use #define for array size.

Revision Comment by Sean Nash on 20 May 2026, 12:09 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29236

  maybe use target rate for both.

Revision Comment by Sean Nash on 20 May 2026, 12:13 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29237

  update total volume too?

Revision Comment by Sean Nash on 20 May 2026, 12:14 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29238

  Is this the right time to zero this volume?

Revision Comment by Sean Nash on 20 May 2026, 11:37 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29233

  only 1 return statement

Revision Comment by Sean Nash on 20 May 2026, 11:40 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29234

  Make the 6 a #define

----------------------------------------
File: firmware/App/Services/FluidBolus.h
Revision Comment by Sean Nash on 20 May 2026, 11:35 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29232

  remove comma

----------------------------------------
File: firmware/App/Services/Messaging.c
Revision Comment by Sean Nash on 20 May 2026, 11:09 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29226

  Not needed.

Revision Comment by Sean Nash on 20 May 2026, 11:17 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29228

  Move this function to your service.

Revision Comment by Sean Nash on 20 May 2026, 11:16 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29227

  Add HDF state too

----------------------------------------
File: AlarmMgmt.c
Revision Comment by Sean Nash on 20 May 2026, 11:01 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1#c29224

  Keep 2 blank lines before banner


---

ID: LEAHI-TD-FIRMWARE-LDT-4013-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-1

Title: LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
Statement of Objectives:


State: Review

Author: Vendor - TEL - Praneeth Bunne
Moderator: Vendor - TEL - Praneeth Bunne
Reviewers: (10 active, 0 completed*)
     Zoltan Miskolci
     Sean Nash
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Michael Garthwaite
     Raghu Kallala
     Dara Navaei
     Behrouz NematiPour
     Stephen Quong