This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-4013-2.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/StateTxPaused.c
Revision Comment by Vendor - TEL - Arpita Srivastava on 12 June 2026, 15:50 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29890

  pauseBolusResumeState is input

Revision Comment by Sean Nash on 12 June 2026, 09:32 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29845

  Should we be looking at tubing set type instead of modality
  here?

----------------------------------------
File: firmware/App/Services/StateServices/FluidBolus.c
Revision Comment by Sean Nash on 12 June 2026, 09:27 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29843

  Shouldn't we be checking tubing set type instead of modality
  here?

Revision Comment by Sean Nash on 12 June 2026, 09:28 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29844

  Can we not determine this now?  Why TODO?

----------------------------------------
File: firmware/App/Services/StateServices/TubeSetInstall.c
Revision Comment by Sean Nash on 12 June 2026, 15:06 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29886

  Either no comment or // comment for function prototypes since
  doxygen captures function details from function headers.

Revision Comment by Vendor - TEL - Arpita Srivastava on 12 June 2026, 15:45 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29888

  Replace // to ///< for line 56 to 60

  Reply by Sean Nash on 12 June 2026, 23:04
  > Arpita, we don't want to use doxygen style comments for
  > function prototypes since we cover functions with the
  > function headers.  so this is the proper type of comments.

Revision Comment by Sean Nash on 12 June 2026, 09:22 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29839

  Initialize to UNKNOWN type.  Remove TODO.

Revision Comment by Vendor - TEL - Arpita Srivastava on 12 June 2026, 15:47 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29889

  add alarm

Revision Comment by Sean Nash on 12 June 2026, 09:23 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29840

  verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and
  trigger s/w fault if invalid.

----------------------------------------
File: firmware/App/Services/StateServices/TubeSetInstall.h
Revision Comment by Sean Nash on 12 June 2026, 09:17 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29836

  Use /// when above, use ///< when to the right.
  Also remove extra space before Tube

Revision Comment by Sean Nash on 12 June 2026, 09:17 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29837

  Change // to ///<

Revision Comment by Sean Nash on 12 June 2026, 15:04 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29885

  These were fine (and preferred) as // because doxygen gets
  function details from function headers in the .c file.

----------------------------------------
File: TDDefs.h
Revision Comment by Sean Nash on 12 June 2026, 09:21 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29838

  Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you
  can initialize a type variable to something before we
  install/identify the type.

----------------------------------------
File: firmware/App/Services/StateServices/TubeSetAutoEject.h
Revision Comment by Sean Nash on 12 June 2026, 15:06 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2#c29887

  Use // comments for function prototypes.


---

ID: LEAHI-TD-FIRMWARE-LDT-4013-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2

Title: LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
Statement of Objectives:


State: Review

Author: Vendor - TEL - Praneeth Bunne
Moderator: Vendor - TEL - Praneeth Bunne
Reviewers: (4 active, 1 completed*)
     Sean Nash   (*)
     Vendor - TEL - Arpita Srivastava
     Vendor - TEL - Jashwant Gantyada
     Vinayakam Mani
     Dara Navaei