This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-4029-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModePreTreat.c
Revision Comment by Sean Nash on 09 July 2026, 13:08 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30397

  Move up one row to alphabetize.

Revision Comment by Sean Nash on 09 July 2026, 13:11 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30399

  Why are we signaling syringe load confirmed here?

----------------------------------------
File: firmware/App/Modes/StatePreTxHeparinSetup.c
Revision Comment by Sean Nash on 09 July 2026, 13:22 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30405

  Don't put comments on function prototypes.  Doxygen gets
  details of functions from the function header.

Revision Comment by Sean Nash on 09 July 2026, 13:16 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30402

  Where is this being called? Should be called from pre-treatment
  init I think.

Revision Comment by Sean Nash on 09 July 2026, 13:24 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30406

  This is called from preload state.  Not needed here I think.

Revision Comment by Sean Nash on 09 July 2026, 13:20 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30404

  Why (void)?

Revision Comment by Sean Nash on 09 July 2026, 13:26 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30407

  Do we really need these setup functions for each state?  They
  all look very simple - just 1 or 2 lines of code.

Revision Comment by Sean Nash on 09 July 2026, 13:28 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30408

  Syringe pump should already be stopped if preload is done.  Do
  we need to call this here?

Revision Comment by Sean Nash on 09 July 2026, 13:31 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30409

  I believe the SyringePump controller will trigger this alarm at
  end of seek operation.

----------------------------------------
File: firmware/App/Modes/StatePreTxHeparinSetup.h
Revision Comment by Sean Nash on 09 July 2026, 13:11 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30398

  Do these states need to be public?

Revision Comment by Sean Nash on 09 July 2026, 13:13 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30400

  Confirmation signal sounds like a message handler from UI.
  Message handlers must accept a message as parameter and return
  BOOL.  They must also be added to the message handler table in
  Messaging.c.

----------------------------------------
File: AlarmDefs.h
Revision Comment by Sean Nash on 09 July 2026, 14:07 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1#c30410

  What alarm is this?  It doesn't look like you've added a new
  alarm.  This is one of the reserved (unused) alarms that UI s/w
  might use.


---

ID: LEAHI-TD-FIRMWARE-LDT-4029-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4029-1

Title: LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
Statement of Objectives:


State: Review

Author: Vendor - TEL - Vijay Pamula
Moderator: Vendor - TEL - Vijay Pamula
Reviewers: (4 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Sean Nash
     Vinayakam Mani
     Dara Navaei