This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-4160-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/AlarmMgmtTD.c
Revision Comment by Vendor - TEL - Arpita Srivastava on 18 June 2026, 10:50 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4160-1#c29981

  mesage payload is not an input. We correctly mentioned it in
  the param.
  Input should be none as we are not reading any global or static
  variable declared at file level.

Revision Comment by Vendor - TEL - Arpita Srivastava on 18 June 2026, 10:51 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4160-1#c29982

  Output should be none as we are not updating any global or
  static variable declared at file level.

Revision Comment by Vendor - TEL - Arpita Srivastava on 18 June 2026, 10:34 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4160-1#c29978

  Please convert the function to have only single point of
  return. 
  You can assign result = FALSE here.
  
  Also check for whitespace characters. Use 4 spaces instead of
  tab.

Revision Comment by Vendor - TEL - Arpita Srivastava on 18 June 2026, 10:45 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4160-1#c29980

  Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T
  )

----------------------------------------
File: firmware/App/Services/AlarmMgmtTD.h
Revision Comment by Vendor - TEL - Arpita Srivastava on 18 June 2026, 10:33 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4160-1#c29977

  Why are we adding this header here?


---

ID: LEAHI-TD-FIRMWARE-LDT-4160-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4160-1

Title: LEAHI-TD-FIRMWARE-LDT-4160_[Request] Get function for full detailed Alarm Table
Statement of Objectives:


State: Review

Author: Vendor - TEL - Santhoshkumar Reddy Alasandagutti
Moderator: Vendor - TEL - Santhoshkumar Reddy Alasandagutti
Reviewers: (4 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Sean Nash
     Vinayakam Mani
     Dara Navaei