This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-4329-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/TxParams.c
Revision Comment by Sean Nash on 08 June 2026, 15:01 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1#c29641

  Can you move this down with the other vitals functions?

Revision Comment by Sean Nash on 08 June 2026, 15:03 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1#c29642

  Remove blank line.

Revision Comment by Sean Nash on 08 June 2026, 15:04 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1#c29643

  It doesn't look like these memsets are necessary.  Consider
  removing them.

Revision Comment by Sean Nash on 08 June 2026, 15:07 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1#c29644

  These should be moved down to an "else" in the if statement
  below (payload length check).

Revision Comment by Sean Nash on 08 June 2026, 15:27 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1#c29645

  Make a local BOOL variable and assign it TRUE or FALSE with a
  ternary operator and then return that local BOOl variable.

Revision Comment by Sean Nash on 08 June 2026, 15:30 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1#c29646

  60 should be coming from somewhere.  Is there not a treatment
  parameter for vitals measurement interval?  I think we do
  (TREATMENT_PARAM_BP_MEAS_INTERVAL).


---

ID: LEAHI-TD-FIRMWARE-LDT-4329-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4329-1

Title: LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
Statement of Objectives:


State: Review

Author: Vendor - TEL - Vijay Pamula
Moderator: Vendor - TEL - Vijay Pamula
Reviewers: (4 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Sean Nash
     Vinayakam Mani
     Dara Navaei