This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-473-1. Review Summary: No summary ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by Sean Nash on 02 December 2025, 09:29 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25394 TDDefs.h is already included in ModePreTreat.h. There is no "TD_Defs.h". Remove this line. Revision Comment by Sean Nash on 02 December 2025, 09:32 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25398 No need to initialize here as it is initialized in init function. Also, need to add a doxygen comment to the right of this line. Revision Comment by Sean Nash on 02 December 2025, 09:31 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25397 Remove extra blank line. Revision Comment by Sean Nash on 05 December 2025, 09:17 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25576 Why was this moved to header file? Reply by Vendor - TEL - Varshini Nagabooshanam on 05 December 2025, 12:11 > By mistake, I forget to remove Revision Comment by Sean Nash on 02 December 2025, 09:31 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25396 Remove extra blank line. Revision Comment by Sean Nash on 02 December 2025, 09:30 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25395 I don't see this function resetting Tx params. Probably a good idea to do that, so add call to reset. Revision Comment by Sean Nash on 02 December 2025, 09:34 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25399 What is this condition here for? Revision Comment by Sean Nash on 02 December 2025, 09:43 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25406 This is not how we typically spec details in function headers. Should be inputs and outputs at a minimum (see other function headers for example) and optionally alarms or messages sent or notes. We can keep these details if you like, but they should be part of the brief above. Revision Comment by Sean Nash on 02 December 2025, 09:38 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25402 Remove this blank line. Revision Comment by Sean Nash on 02 December 2025, 09:39 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25403 I don't think we need to check for rejected here. If we rejected params, UI will have to send us new params until we accept them. Revision Comment by Sean Nash on 02 December 2025, 09:41 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25405 We probably want to go to patient connection state (or whatever the next state is) eventually, but we haven't implemented any other states in pre-treatment yet. Comment this line out with a TODO comment to restore when the state is implemented. And, for now, add a call to request treatment mode. Revision Comment by Sean Nash on 02 December 2025, 09:40 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25404 We don't need an else here. We already set state to Rx state in declaration above. Revision Comment by Sean Nash on 02 December 2025, 09:36 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25400 Add blank line before return. ---------------------------------------- File: firmware/App/Modes/ModePreTreat.h Revision Comment by Sean Nash on 05 December 2025, 09:14 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25575 Doesn't make sense to have a static function prototyped in the header file. Static suggests the function is private. Prototyping in header file suggests function is public. I suspect this function should be private, so keep that static but move this prototype inside the .c file. Reply by Vendor - TEL - Varshini Nagabooshanam on 05 December 2025, 12:07 > handleRxState should stay private. I removed the prototype > from the header and kept a static prototype in ModePreTreat.c > only, so the function remains internal to this unit. ---------------------------------------- File: firmware/App/Modes/ModeTxParams.c Revision Comment by Sean Nash on 09 December 2025, 09:33 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25656 Need to delete this unit (ModeTxParams.c/.h). Also need to remove the mode from the modes enumeration and from OperationModes.c. Revision Comment by Sean Nash on 02 December 2025, 09:47 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25407 Accidental change here? We should be deleting the ModeTxParams.c and .h files anyway. Reply by Vendor - TEL - Varshini Nagabooshanam on 02 December 2025, 10:21 > Thanks for catching that. Yes, this was an accidental change > on my part. I’ll revert it and proceed with deleting > ModeTxParams.c and the related header files as suggested. ---------------------------------------- File: firmware/App/Services/TxParams.c Revision Comment by Sean Nash on 02 December 2025, 09:56 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25415 Remove extra blank line. Revision Comment by Sean Nash on 02 December 2025, 13:13 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25426 I think we need 2 public get functions that takes a dialyzer type (enum) parameter and return a blood volume or dialysate volume from this look-up table. Reply by Vendor - TEL - Varshini Nagabooshanam on 05 December 2025, 12:08 > Updated Revision Comment by Sean Nash on 02 December 2025, 09:57 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25416 Flag for rejection not needed? Revision Comment by Sean Nash on 02 December 2025, 09:58 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25417 validTreatParamsReceived is an input. Revision Comment by Sean Nash on 02 December 2025, 09:58 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25418 treatParamsConfirmed is an input. Revision Comment by Sean Nash on 02 December 2025, 09:59 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25419 Get function for rejected is not needed? Reply by Vendor - TEL - Varshini Nagabooshanam on 05 December 2025, 12:09 > Removed Revision Comment by Sean Nash on 02 December 2025, 13:10 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25425 Missing param line in function header. Revision Comment by Sean Nash on 02 December 2025, 13:10 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25424 Missing param line in function header. Revision Comment by Sean Nash on 08 December 2025, 11:11 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25612 I don't see any get functions. I think we need to copy from ModeTxParams.c. Let's make sure we've copied all needed functions from ModeTxParams.c and then don't forget to delete ModeTxParams.c/.h. Revision Comment by Sean Nash on 02 December 2025, 13:07 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25423 Missing param line in function header. Revision Comment by Sean Nash on 08 December 2025, 11:14 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25614 Add a blank line between declaration and if statement. Reply by Vendor - TEL - Varshini Nagabooshanam on 08 December 2025, 13:11 > Added Revision Comment by Sean Nash on 08 December 2025, 11:14 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25615 Missing return statement. Reply by Vendor - TEL - Varshini Nagabooshanam on 08 December 2025, 13:11 > Updated Revision Comment by Sean Nash on 08 December 2025, 11:12 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25613 I don't see an isTreatmentParamInRange function. I think we need to copy from the ModeTxParams.c. Reply by Vendor - TEL - Varshini Nagabooshanam on 08 December 2025, 13:11 > Added Revision Comment by Sean Nash on 08 December 2025, 10:53 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25610 Add one more blank line above test support banner. Revision Comment by Sean Nash on 08 December 2025, 10:54 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25611 Message handler functions must have a single parameter (message). The payload of the message will have the param and value in it and this function needs to parse them out of the payload. Also need to check payload length first. We need a new message ID in MsgDefs.h for Dialin to send us this message and we need to add an entry in the message/handler table in Messaging.c. Revision Comment by Sean Nash on 09 December 2025, 09:57 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25658 I don't see these Lower/Upper Range Limit functions declared in the header file. Revision Comment by Sean Nash on 09 December 2025, 09:58 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25659 I didn't see this in header file. ---------------------------------------- File: firmware/App/Services/TxParams.h Revision Comment by Sean Nash on 02 December 2025, 09:50 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25411 Typically, we just match the unit file name here - so would be ___TX_PARAMS_H___ Reply by Sean Nash on 05 December 2025, 09:20 > I guess my point was, we don't need the "APP_SERVICES" part > in the name. Reply by Vendor - TEL - Varshini Nagabooshanam on 05 December 2025, 12:12 > Removed and Updated Revision Comment by Sean Nash on 02 December 2025, 09:51 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25412 Remove extra blank line. Revision Comment by Sean Nash on 02 December 2025, 09:52 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25413 This unit is not a mode. It is replacing a mode with a service. Change to "Treatment parameters unit provides validation and confirmation handling for treatment parameters from the UI." Revision Comment by Sean Nash on 02 December 2025, 09:54 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25414 Not sure that we need a get function (or even a flag) for rejection. Recommend removing this function. Revision Comment by Sean Nash on 03 December 2025, 08:56 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25461 Do we need a Dialin Tx param set message and message handling function (like HD in Denali had)? Reply by Vendor - TEL - Varshini Nagabooshanam on 05 December 2025, 12:11 > Updated Revision Comment by Sean Nash on 09 December 2025, 09:31 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1#c25655 I don't think we need this signal function since this is not a mode anymore. Is this function being called somewhere? --- ID: LEAHI-TD-FIRMWARE-LDT-473-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-1 Title: LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation Statement of Objectives: State: Review Author: Vendor - TEL - Varshini Nagabooshanam Moderator: Vendor - TEL - Varshini Nagabooshanam Reviewers: (10 active, 0 completed*) Vendor - TEL - Jashwant Gantyada Vendor - TEL - Arpita Srivastava Sean Nash Vinayakam Mani Raghu Kallala Michael Garthwaite Dara Navaei Vendor - TEL - Sivvanarayana Kurapati Daniel Ho Vendor - TEL - Sameer Poyil