This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-473-3.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/TxParams.c
Revision Comment by Sean Nash on 06 April 2026, 10:56 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3#c28234

  F suffix.

Revision Comment by Sean Nash on 06 April 2026, 10:57 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3#c28235

  Can we just remove this?

Revision Comment by Sean Nash on 06 April 2026, 10:57 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3#c28236

  Can we just remove this?

----------------------------------------
File: firmware/App/Services/TxParams.h
Revision Comment by Sean Nash on 06 April 2026, 11:01 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3#c28237

  Align comments.

----------------------------------------
File: MessagePayloads.h
Revision Comment by Sean Nash on 06 April 2026, 10:52 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3#c28233

  Is bicarbonate also a conversion factor?

  Reply by Raghu Kallala on 06 April 2026, 12:42
  > No we are not getting conv factor from UI on it
  > I will have to confirm with Nick to see if we will get the
  > bicarbConvFactor

    Reply by Sean Nash on 06 April 2026, 13:37
    > Is it an enum/index like Denali then?

----------------------------------------
File: TDDefs.h
Revision Comment by Sean Nash on 06 April 2026, 10:49 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3#c28232

  Can we just remove the old enum now?


---

ID: LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3

Title: LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
Statement of Objectives:


State: Review

Author: Raghu Kallala
Moderator: Raghu Kallala
Reviewers: (3 active, 0 completed*)
     Sean Nash
     Vinayakam Mani
     Dara Navaei