This is a list of all comments for LEAHI-TD-FIRMWARE-LDT-5613-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/StateServices/DrySelfTests.c
Revision Comment by Michael Garthwaite on 21 August 2026, 09:53 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31638

  Need the TDDef.h changes that include the enum naming updates

Revision Comment by Sean Nash on 21 August 2026, 09:40 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31637

  Where are we transitioning to prime?

Revision Comment by Sean Nash on 21 August 2026, 09:00 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31617

  Add alarms to header.

Revision Comment by Sean Nash on 21 August 2026, 08:58 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31614

  Remove extra blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:00 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31616

  Add alarms to header.

Revision Comment by Sean Nash on 21 August 2026, 09:00 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31615

  Remove extra blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:00 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31618

  Add alarms to header.

Revision Comment by Sean Nash on 21 August 2026, 09:01 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31619

  Remove extra blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:02 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31620

  Add alarms to header.

Revision Comment by Sean Nash on 21 August 2026, 09:02 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31621

  Remove extra blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:02 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31622

  Add alarms to header.

Revision Comment by Sean Nash on 21 August 2026, 09:03 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31623

  Remove extra blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:03 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31624

  Add alarms to header.

Revision Comment by Sean Nash on 21 August 2026, 09:03 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31625

  Remove extra blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:04 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31626

  Remove extra blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:35 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31630

  Should reset happen when transitioning out of this state (into
  next state)?  I think we want to allow time for pressure to
  stabilize while open to atmosphere after we open these valves
  before we reset the offsets.

Revision Comment by Sean Nash on 21 August 2026, 09:34 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31629

  Remove extra blank line.

Revision Comment by Michael Garthwaite on 21 August 2026, 09:19 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31627

  How come some transitions get an event and others dont? what is
  the intention?

  Reply by Vendor - TEL - Varshini Nagabooshanam on 21 August 2026, 10:26
  > Those transitions to send the pressure result event. That was
  > carried over from the previous implementation. Since the
  > state changes are already reported through the common
  > sub-state/operation-status events, I'll remove the pressure
  > result event from those individual transitions for
  > consistency.

Revision Comment by Sean Nash on 21 August 2026, 09:36 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31631

  Remove blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:36 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31632

  Remove blank line.

Revision Comment by Michael Garthwaite on 21 August 2026, 09:33 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31628

  keep the space

Revision Comment by Sean Nash on 21 August 2026, 09:38 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31633

  Remove blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:38 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31634

  Remove blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:38 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31635

  Remove blank line.

Revision Comment by Sean Nash on 21 August 2026, 09:39 
https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1#c31636

  Remove blank line.


---

ID: LEAHI-TD-FIRMWARE-LDT-5613-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-5613-1

Title: LEAHI-TD-FIRMWARE-LDT-5613_Disposable Tube Self-Test - FW Implementation - 7/4:
Statement of Objectives:


State: Review

Author: Vendor - TEL - Varshini Nagabooshanam
Moderator: Vendor - TEL - Varshini Nagabooshanam
Reviewers: (5 active, 0 completed*)
     Vendor - TEL - Arpita Srivastava
     Sean Nash
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei