This is a list of all comments for LEAHI-TESTSUITES-LDT-1218-1. Review Summary: No summary General Comment by Nicholas Ramirez on 20 October 2025, 09:08 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24732 The test suite is missing an update to the suite.conf file that adds your test case to the test suite. Please push the file with the addition of your test case Reply by Vendor - TEL - Sivvanarayana Kurapati on 21 October 2025, 10:03 > Added suite.conf file. ---------------------------------------- File: suite_leahi/shared/scripts/names.py Revision Comment by Nicholas Ramirez on 14 October 2025, 09:18 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24636 Please make keep all existing object as they are required for the other test cases. Reply by Vendor - TEL - Sivvanarayana Kurapati on 15 October 2025, 10:16 > added existing objects to names.py file. Reply by Nicholas Ramirez on 15 October 2025, 10:24 > RESOLVED Revision Comment by Nicholas Ramirez on 16 October 2025, 09:53 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24673 Please remove o_Overlay and o_treatmentHome as they are not used Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:18 > Removed o_Overlay and o_treatmentHome objects. Revision Comment by Nicholas Ramirez on 15 October 2025, 10:23 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24647 Remove visible parameter and please align spacing between each how it was before along with the new objects Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:18 > Removed visible parameter and aligned all objects. Revision Comment by Nicholas Ramirez on 14 October 2025, 09:19 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24637 when adding new items please organize and align as done initially Reply by Vendor - TEL - Sivvanarayana Kurapati on 15 October 2025, 10:17 > Aligned all items. Reply by Nicholas Ramirez on 15 October 2025, 10:26 > align each parameter as well please Revision Comment by Nicholas Ramirez on 16 October 2025, 09:58 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24675 Remove the following as I do not see these being used anywhere mainTreatmentScreen_arterialRangeBar_RangeBar mainTreatmentScreen_arterialRangeBar_RangeBar_marker mainTreatmentScreen_venousRangeBar_RangeBar mainTreatmentScreen_venousRangeBar_RangeBar_marker mainTreatmentScreen_tempRangeBar_RangeBar mainTreatmentScreen_tempRangeBar_RangeBar_marker Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:19 > Removed all the unused objects. Revision Comment by Nicholas Ramirez on 16 October 2025, 09:59 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24677 venous_RangeBar Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:20 > Updated as suggested. Revision Comment by Nicholas Ramirez on 16 October 2025, 09:58 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24676 should be tmp_RangeBar Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:20 > Updated as suggested. Revision Comment by Nicholas Ramirez on 23 October 2025, 08:45 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24778 For this lets not get 2 of the same object. For this if the "text" property that is going to be tested get the parent object instead and use that to test.. try: {code} treatmentTimeNotificationBarSmall = {"container": mainTreatmentScreen, "objectName": "notification", "type": "NotificationBarSmall"} {code} then use that "text" property of that parent object to test Revision Comment by Nicholas Ramirez on 16 October 2025, 10:01 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24678 dial_tmp_value Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:20 > Updated as suggested. Revision Comment by Nicholas Ramirez on 16 October 2025, 10:02 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24679 dialyste_tmp_title_Text Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:20 > Updated as suggested. ---------------------------------------- File: suite_leahi/tst_main_treatment_pressure/test.py Revision Comment by Nicholas Ramirez on 16 October 2025, 10:47 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24685 rename test case to tst_main_treatment.. The name looks like this is only testing pressure when we test all the other items as well Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:21 > Renamed the test case as tst_main_treatment Reply by Nicholas Ramirez on 16 October 2025, 12:14 > Thank you. can you remove the obsolete test case from the > test suite as well Revision Comment by Nicholas Ramirez on 15 October 2025, 10:27 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24650 you can remove the top portion as its not correct. This will get generated later Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:20 > removed the top portion. Revision Comment by Nicholas Ramirez on 16 October 2025, 08:55 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24654 remove duplicate import Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:21 > Removed Revision Comment by Nicholas Ramirez on 14 October 2025, 09:19 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24638 is this a python lib or is this made by us? Reply by Nicholas Ramirez on 15 October 2025, 08:05 > The configuration is from Denali. Please lets port in what we > are using into a new one as part of this test suite Reply by Vendor - TEL - Sivvanarayana Kurapati on 15 October 2025, 10:13 > Added new configuration file utility.py for Leahi. Reply by Nicholas Ramirez on 15 October 2025, 10:31 > RESOLVED Revision Comment by Nicholas Ramirez on 16 October 2025, 09:28 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24659 Remove this import as its not being used Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:21 > removed the unused import Revision Comment by Nicholas Ramirez on 16 October 2025, 09:28 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24660 Remove this import as its not being used Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:22 > removed the unused import Revision Comment by Nicholas Ramirez on 16 October 2025, 09:29 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24661 in_range_color and out_of_range_color are not being used so please remove Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:22 > removed the unused variables. Revision Comment by Nicholas Ramirez on 16 October 2025, 09:34 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24663 Remove if not being used Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:22 > removed Revision Comment by Nicholas Ramirez on 16 October 2025, 09:44 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24671 Please align all as following: {code}        { "arterial_pressure" : 100, "arterial_limit_low" : -300, "arterial_limit_high" : 120,           "venous_pressure" : 140, "venous_limit_low" : -100, "venous_limit_high" : 250,          "pressure_limit_state" : 2, "tmp_pressure" : 250 , "tmp_limit_low" : -400 , "tmp_limit_high" : 200 },{code} Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:23 > Aligned Revision Comment by Nicholas Ramirez on 16 October 2025, 09:18 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24655 remove commented out line Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:22 > removed Revision Comment by Nicholas Ramirez on 16 October 2025, 09:35 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24665 align indentations Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:23 > Aligned Revision Comment by Nicholas Ramirez on 16 October 2025, 09:23 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24656 Please remove all the waits. It is not needed and just makes the test run longer. The quish.waitForObject should be your wait by giving it a timeout. If the object can not be found then add a longer timeout. e.g. arterial_rangeBar = utility.get_object_from_names(names.arterial_RangeBar, error_message="arterial rangeBar object is missing", timeout_ms=1000) Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:23 > Removed all waits. Revision Comment by Nicholas Ramirez on 16 October 2025, 09:35 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24666 align indentations Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:23 > Aligned Revision Comment by Nicholas Ramirez on 15 October 2025, 10:47 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24653 I know in the solution infusion i used this but this button is going to be removed so can we do instead: td_interface.td_operation_mode( TDOpModes.MODE_TREA.value, 0 ) td_interface.td_tx_state( TDTreatmentStates.TREATMENT_DIALYSIS_STATE.value , 0 , 0 , 0 , 0 , 0 , 0 , 0 , 0 , 0 ) Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:24 > Updated as suggested Revision Comment by Nicholas Ramirez on 16 October 2025, 09:36 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24667 align indentations Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:24 > Aligned. ---------------------------------------- File: suite_leahi/shared/scripts/configuration/utility.py Revision Comment by Nicholas Ramirez on 15 October 2025, 10:27 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24651 Remove top comment portion Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:16 > Updated. Revision Comment by Nicholas Ramirez on 16 October 2025, 10:06 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24681 Please remove all the imports not being used Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:17 > Removed all unused imports. Revision Comment by Nicholas Ramirez on 16 October 2025, 10:35 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24683 If this is specific to only your test case then move this in the test case Reply by Vendor - TEL - Sivvanarayana Kurapati on 16 October 2025, 11:17 > Removed the pressure_text_obj method. ---------------------------------------- File: suite_leahi/tst_main_treatment/test.py Revision Comment by Nicholas Ramirez on 24 October 2025, 11:41 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24800 1. Please add the comment block as discussed 2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1220 Reply by Vendor - TEL - Sivvanarayana Kurapati on 27 October 2025, 11:00 > Addressed points 1 and 2. Revision Comment by Nicholas Ramirez on 16 October 2025, 12:29 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24715 the variable name is not "temp" it is "tmp" for Trancememberance. Please fix all object names that are "temp" and update to "tmp" uppdate comments from "temperature" to "Trancememberance" Revision Comment by Nicholas Ramirez on 16 October 2025, 12:33 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24716 update all temp -> tmp and Temperature - > Trancememberance Revision Comment by Nicholas Ramirez on 16 October 2025, 12:20 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24713 remove all the waitForGUI Reply by Vendor - TEL - Sivvanarayana Kurapati on 17 October 2025, 10:19 > Removed all waitForGUI commands. Revision Comment by Nicholas Ramirez on 16 October 2025, 12:22 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24714 add changing the the opmode first too.. td.td_operation_mode( TDOpModes.MODE_TREA.value, 0 ) Reply by Vendor - TEL - Sivvanarayana Kurapati on 17 October 2025, 10:19 > Added the opmode as suggested. Revision Comment by Behrouz NematiPour on 27 October 2025, 12:14 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24853 The application should be called by -q switch; otherwise, if you don't pet it (ACK), it will display alarm 100. How did you overcome that issue? Reply by Behrouz NematiPour on 27 October 2025, 12:18 > It is so important that the simulator should never run in > parallel with your tests. Reply by Vendor - TEL - Sivvanarayana Kurapati on 28 October 2025, 11:00 > We ensured that simulator was closed while executing the > script. Reply by Vendor - TEL - Sivvanarayana Kurapati on 28 October 2025, 10:57 > Added -q switch for startApplication method as requested, but > we never faced any alarm issue. Revision Comment by Behrouz NematiPour on 27 October 2025, 12:19 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24855 It was a good idea to create the get_object_from_names function as a wrapper for the waitForObjectExists. If it is created as a wrapper for this function call, shouldn't we use that? If you do not plan to use it (or have any issues), please remove the get_object_from_names function. Reply by Vendor - TEL - Sivvanarayana Kurapati on 28 October 2025, 11:00 > Updated get_object_from_names function as a wrapper for the > waitForObjectExists. Revision Comment by Behrouz NematiPour on 27 October 2025, 12:26 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24856 Seems there is a missing test.startSection() , test.endSection() for the Pressures here Reply by Vendor - TEL - Sivvanarayana Kurapati on 28 October 2025, 10:56 > Added test.startSection() and test.endSection() for the > Pressures. Revision Comment by Nicholas Ramirez on 20 October 2025, 09:02 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1#c24731 can we add 2 tests.. One when treatment is paused to test the message showing "Treatment Paused" and test when timer is finished to test "Treatment Complete" message Reply by Vendor - TEL - Sivvanarayana Kurapati on 21 October 2025, 10:02 > Added 2 tests for "Treatment Paused" and "Treatment > Complete". --- ID: LEAHI-TESTSUITES-LDT-1218-1 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-1218-1 Title: LEAHI-TESTSUITES-LDT-1218_Main Treatment Screen - SW - 02 - Screen Integration (MSG,QML) - Q&R Statement of Objectives: State: Closed Summary: Author: Vendor - TEL - Sivvanarayana Kurapati Moderator: Behrouz NematiPour Reviewers: (5 active, 1 completed*) Nicholas Ramirez (*) Sean Nash jpaguio Tiffany Mejia Michael Garthwaite Dara Navaei