This is a list of all comments for LEAHI-TESTSUITES-LDT-2174-1. Review Summary: No summary ---------------------------------------- File: suite_leahi/shared/scripts/names.py Revision Comment by Nicholas Ramirez on 05 November 2025, 10:10 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c24990 Please remove all object that are not used for treatment parameters Reply by Nicholas Ramirez on 06 November 2025, 15:55 > please keep the saline bolus ones that are already in > staging. Remove the main treatment objects that were added in > a different branch/story. Anything in staging that existed > before must still exist Reply by Vendor - TEL - Divya Sree Nidamamidi on 07 November 2025, 21:50 > Removed all the objects which are not used in the treatment > parameter and kept objects which are in staging Revision Comment by Nicholas Ramirez on 06 November 2025, 16:33 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25020 remove text properties in all object and get the text programmatically then test Reply by Vendor - TEL - Divya Sree Nidamamidi on 07 November 2025, 22:01 > Removed the text properties in the object Revision Comment by Nicholas Ramirez on 26 November 2025, 10:30 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25315 remove visible property Reply by Vendor - TEL - Divya Sree Nidamamidi on 27 November 2025, 03:00 > Removed the Visible property in the objects Revision Comment by Nicholas Ramirez on 06 November 2025, 16:30 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25019 o_PreTreatmentCreate_bicarbonateConcentrateComboBox_BaseComboBox is not being used Reply by Vendor - TEL - Divya Sree Nidamamidi on 07 November 2025, 21:55 > Removed the object Which is not being used Revision Comment by Nicholas Ramirez on 02 December 2025, 14:23 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25433 type o_PreTreatmentButton Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 01:41 > Updated the object name Revision Comment by Nicholas Ramirez on 24 November 2025, 09:36 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25256 please align parameters Reply by Vendor - TEL - Divya Sree Nidamamidi on 24 November 2025, 22:40 > Aligned the parameters ---------------------------------------- File: suite_leahi/tst_create_treatment/test.py Revision Comment by Nicholas Ramirez on 26 November 2025, 10:33 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25316 These steps should outline the sections in the report https://diality.atlassian.net/browse/LDT-2176. Please sync them up so they match the flow Reply by Vendor - TEL - Divya Sree Nidamamidi on 27 November 2025, 02:52 > Added the sections in the report Reply by Nicholas Ramirez on 02 December 2025, 14:01 > please upload new report to view changes Reply by Vendor - TEL - Divya Sree Nidamamidi on 04 December 2025, 03:27 > Report has been updated in the jira Revision Comment by Nicholas Ramirez on 06 November 2025, 15:59 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25012 For testing the patient ID just test 2 different scenarios. 1. Test with a ptient ID (ideally with the full character limit) then enter all parameters then validate - Can test the validator only able to enter character that are acceptable.. 2. Test with NO patient ID then enter all parameters then validate. No need to test 10 different patient IDs just those scenarios listed Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 November 2025, 21:44 > Modified the conditions as per your suggestion Revision Comment by Nicholas Ramirez on 06 November 2025, 16:15 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25014 Add test when all parameters are filled: 1. Change Duration -> Verify Heparin Stop Time "active" property is set to off 2. Change Heparin Dispensising Rate from 0.2 to OFF -> Verify Heparing Stop Time is set to OFF 3. Change Heparin Dispensising Rate from OFF to 0.2 -> Verify Heparin Stop Time "active" property is set to off 4. When Duration is set to a value -> Verify the max Heparin Stop Time is the Duration value that is set Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 November 2025, 01:03 > Added the test cases as per suggestion Reply by Nicholas Ramirez on 02 December 2025, 14:00 > Please update report on JIRA everytime there is a change to > the test cases Reply by Vendor - TEL - Divya Sree Nidamamidi on 04 December 2025, 03:28 > Report has been updated in the jira Revision Comment by Nicholas Ramirez on 05 December 2025, 11:44 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25583 the QR code should not be visible. This test is not valid and incorrect because this should fail as we only get QR code once we validate all this checks if that object is there which it is there but not visible. We should be testing the visible property of the QR code section. This also needs to be moved after the FW td_Treatment_Parameters_Validation to pass Reply by Vendor - TEL - Divya Sree Nidamamidi on 08 December 2025, 03:53 > Check the QR code visible property Revision Comment by Nicholas Ramirez on 05 December 2025, 11:55 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25584 This should say Validate. Can we change message here and add a test to test the button text. Before validation should test it says validate and then after fw validates the button should say confirm and test text and then mouse click it Reply by Vendor - TEL - Divya Sree Nidamamidi on 08 December 2025, 03:54 > Verify the text of confirm and validate button Revision Comment by Nicholas Ramirez on 02 December 2025, 14:23 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25432 1. at this point we need to verify after all parameters are populated then the names.o_PreTreatmentButton is now enabled. 2. User needs to first press the button for the FW to respond Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 08:23 > The steps have been added to check populated values Reply by Nicholas Ramirez on 04 December 2025, 09:25 > The way we verify is that the o_PreTreatmentButton is only > enabled when they are so testing that it is first enabled > then mouse click the button then from fw send the > td.td_Treatment_Parameters_Validation Reply by Vendor - TEL - Divya Sree Nidamamidi on 05 December 2025, 00:46 > Steps have been updated -> After click on the button then > from fw send the td_Treatment_Parameters_Validation Revision Comment by Nicholas Ramirez on 02 December 2025, 14:35 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25434 #1. Change Duration -> Verify Heparin Stop Time "active" property is set to off 1. First set Duration, then Bolus Volume, then dispensing rate and then Hep Stop time 2. Change Duration. 3. Verify the "isActive" property of o_PreTreatmentCreate_heparinStopTimeControl_ValueAdjuster is set to False Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 08:13 > The steps have been modified as per suggestion Revision Comment by Nicholas Ramirez on 02 December 2025, 14:41 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25435 #2. Change Heparin Dispensising Rate from 0.2 to OFF -> Verify Heparing Stop Time is set to OFF 1. First give a value to duration, hep bolus value, and dispensing rate, and hep stop time. (none should be set to OFF) 2. Set Dispensing Rate to off 3. Verify hepstop time is set to off Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 08:17 > The steps have been modified as per suggestion Revision Comment by Nicholas Ramirez on 02 December 2025, 14:49 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25436 #3. Change Heparin Dispensising Rate from OFF to 0.2 -> Verify Heparin Stop Time "active" property is set to off verify the proeprty "isActive" property of o_PreTreatmentCreate_heparinStopTimeControl_ValueAdjuster is set to False isntead Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 08:17 > The steps have been modified as per suggestion Reply by Nicholas Ramirez on 05 December 2025, 12:07 > test the active property > test.compare(heprain_Stop_time.isActive,False, "Heprain > stop time active property is set to False") Reply by Vendor - TEL - Divya Sree Nidamamidi on 08 December 2025, 03:53 > Verify the active property of heprain stop time Revision Comment by Nicholas Ramirez on 02 December 2025, 14:52 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25437 we also want to verify the right arrow is not editable telling us this is the make hjep stop time can go Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 08:18 > Added the step to check right arrow is disabled Revision Comment by Nicholas Ramirez on 05 December 2025, 11:43 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25582 another mouseClick(waitForObject(confirmButton)) after fw validates parameter is needed Reply by Vendor - TEL - Divya Sree Nidamamidi on 08 December 2025, 03:55 > Added the mouse click Revision Comment by Nicholas Ramirez on 11 December 2025, 16:21 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25760 remove and add delay i waitForObjectExists if needed Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 December 2025, 22:25 > Remove the delay Revision Comment by Nicholas Ramirez on 11 December 2025, 16:21 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25761 remove and add delay i waitForObjectExists if needed Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 December 2025, 22:26 > Removed the waitForGUI Revision Comment by Nicholas Ramirez on 06 November 2025, 16:27 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25018 before validating from FW. Add mouse click of the button then do the FW action. Same when confirming mouse click the button then press the confirm button Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 November 2025, 01:05 > Added mouseclick action before validating from FW Revision Comment by Nicholas Ramirez on 03 December 2025, 10:14 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25475 ive noticed this common method being used in other test cases. If its a general method that is used throughout please move outside in a shared file and call from there. Please update other repositories that use this as well. Reply by Vendor - TEL - Divya Sree Nidamamidi on 04 December 2025, 05:37 > Common methods are moved to utility.py file Revision Comment by Nicholas Ramirez on 02 December 2025, 14:54 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25438 can you help explain what this method does exactly? This takes a very long time. Can we simply just test the min and max with arrows then min and max with slider. This seems to go back and forth for each item. Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 01:10 > The value will be updated based on the target value provided > by the user. > To adjust the minimum and maximum values, use the left and > right arrows to update them accordingly. Reply by Nicholas Ramirez on 03 December 2025, 10:16 > This is a common method used in another test case please > move outside in a common shared file Reply by Vendor - TEL - Divya Sree Nidamamidi on 04 December 2025, 05:24 > Common method is moved to Utility.py file Revision Comment by Nicholas Ramirez on 06 November 2025, 16:23 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25016 Also test the slider functionality as well as the left and right arrows Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 November 2025, 01:06 > Added function to test slider function Revision Comment by Nicholas Ramirez on 03 December 2025, 10:15 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25476 this looks like a genaral method that can be moved to a shared file to be used elsewhere as well Reply by Vendor - TEL - Divya Sree Nidamamidi on 04 December 2025, 05:35 > Method is moved to utility.py file Revision Comment by Nicholas Ramirez on 02 December 2025, 14:17 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25430 remove all snoozes Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 08:25 > To check slider functionality it required some wait time so > added waitForGUI method Revision Comment by Nicholas Ramirez on 02 December 2025, 14:18 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25431 reduce timeout to 1000 Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 December 2025, 08:24 > Updated the step with timeout 1000 Revision Comment by Nicholas Ramirez on 02 December 2025, 14:14 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25429 why 10 second wait? We shouldnt need any additional delays. If you need a delay or wait for an object we should better be using waitForObject() Reply by Vendor - TEL - Divya Sree Nidamamidi on 05 December 2025, 01:01 > Removed the wait function Revision Comment by Nicholas Ramirez on 26 November 2025, 10:37 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25317 There may be a test.endSection() missing somewhere as the report shows a section not sectioned out. Please update regenerate report and review and reupload. Reply by Vendor - TEL - Divya Sree Nidamamidi on 27 November 2025, 02:59 > Added test.endsection in the report ---------------------------------------- File: suite_leahi/shared/scripts/configuration/utility.py Revision Comment by Nicholas Ramirez on 04 December 2025, 08:55 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25510 rename to set_property_text() Reply by Vendor - TEL - Divya Sree Nidamamidi on 04 December 2025, 21:52 > Renamed the function as per your suggestion Reply by Nicholas Ramirez on 05 December 2025, 11:36 > for consistency with all the other branches please use > setObjectText isntead. Reply by Vendor - TEL - Divya Sree Nidamamidi on 07 December 2025, 23:03 > Rename the method name to set_Object_Text Reply by Nicholas Ramirez on 10 December 2025, 09:22 > in staging the function is named setObjectText. Please > update to match to avoid conflicts Reply by Vendor - TEL - Divya Sree Nidamamidi on 10 December 2025, 21:43 > Renamed the function setObjectText to match the > staging and to avoid conflicts Revision Comment by Nicholas Ramirez on 04 December 2025, 08:54 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25509 remove this and use set_parameter_type() Reply by Vendor - TEL - Divya Sree Nidamamidi on 05 December 2025, 00:47 > Removed this function and using this method Revision Comment by Nicholas Ramirez on 05 December 2025, 11:35 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25579 add comment block to all functions that are missing Reply by Vendor - TEL - Divya Sree Nidamamidi on 07 December 2025, 23:59 > Comment block is added to all the functions Revision Comment by Nicholas Ramirez on 11 December 2025, 16:20 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25759 remove commented out lines Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 December 2025, 22:26 > Removed the commented lines Revision Comment by Nicholas Ramirez on 11 December 2025, 16:18 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1#c25758 used setObjectText() instead Reply by Vendor - TEL - Divya Sree Nidamamidi on 11 December 2025, 22:27 > Removed the function and using setObjectText --- ID: LEAHI-TESTSUITES-LDT-2174-1 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2174-1 Title: LEAHI-TESTSUITES-LDT-2174_Treatment Parameters (Create Rx) - SW - 02 - (New Design) - Q&R Statement of Objectives: State: Review Author: Vendor - TEL - Divya Sree Nidamamidi Moderator: Nicholas Ramirez Reviewers: (5 active, 0 completed*) Dara Navaei Behrouz NematiPour Vendor - TEL - Shivaprasad Basavaraju Daniel Ho Stephen Quong