This is a list of all comments for LEAHI-TESTSUITES-LDT-2971-1. Review Summary: No summary ---------------------------------------- File: suite_leahi/shared/scripts/configuration/utility.py Revision Comment by Behrouz NematiPour on 30 January 2026, 09:52 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26875 Why do you need this? Is any editor used other than Squish? We need to make sure it is running in the Squish IDE and with its tools on the build server. Preferably, remove it to be consistent. Revision Comment by Nicholas Ramirez on 30 January 2026, 10:06 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26879 please move these into the config.py to be consistent with other test cases Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 February 2026, 00:42 > Moved all the constants to config.py file Revision Comment by Behrouz NematiPour on 30 January 2026, 09:57 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26876 Why do you need try-catch? Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 February 2026, 00:43 > try catch is avoided as per suggestion Revision Comment by Behrouz NematiPour on 30 January 2026, 09:58 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26877 As a general note, avoid try-catch. Your code should be prepared for exceptions, not to be surprised. Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 February 2026, 00:42 > try catch is removed Revision Comment by Nicholas Ramirez on 19 January 2026, 14:12 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26421 variable name has been update to: vTransmembranePressureLimitWindowRejectReason Reply by Vendor - TEL - Divya Sree Nidamamidi on 20 January 2026, 04:02 > Variable name has been updated Revision Comment by Nicholas Ramirez on 30 January 2026, 10:09 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26880 remove commented out line Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 February 2026, 00:41 > Removed the line Revision Comment by Nicholas Ramirez on 30 January 2026, 10:11 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26882 should this method be moved to navigation.py? Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 February 2026, 00:40 > Method is moved to navigation.py file Revision Comment by Behrouz NematiPour on 30 January 2026, 10:13 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26884 Please add a docstring for this function. And the naming seems like to be better like: {code} navigation_pageIndicator_step(vStep_name) {code} Reply by Vendor - TEL - Divya Sree Nidamamidi on 03 February 2026, 00:40 > Method name is changed and added docstring and method is > available in navigation.py file ---------------------------------------- File: suite_leahi/shared/scripts/names.py Revision Comment by Nicholas Ramirez on 19 January 2026, 11:19 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26412 remove if not being used Reply by Vendor - TEL - Divya Sree Nidamamidi on 20 January 2026, 04:02 > Removed the object Revision Comment by Behrouz NematiPour on 30 January 2026, 10:02 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26878 When appropriate, align the code. Reply by Vendor - TEL - Divya Sree Nidamamidi on 02 February 2026, 22:45 > code is aligned Revision Comment by Nicholas Ramirez on 19 January 2026, 11:20 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26413 remove if not being used Reply by Vendor - TEL - Divya Sree Nidamamidi on 20 January 2026, 04:03 > Create treatment button object is using in the test script Revision Comment by Nicholas Ramirez on 19 January 2026, 11:21 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26414 remove if not being used Reply by Vendor - TEL - Divya Sree Nidamamidi on 20 January 2026, 04:03 > Removed the object ---------------------------------------- File: suite_leahi/tst_heparin/test.py Revision Comment by Nicholas Ramirez on 23 January 2026, 15:51 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26631 fix numbering of test steps and update to match update test report Reply by Vendor - TEL - Divya Sree Nidamamidi on 26 January 2026, 06:05 > Modified as per suggestion Revision Comment by Nicholas Ramirez on 23 January 2026, 15:51 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26630 typo should be parameter Reply by Vendor - TEL - Divya Sree Nidamamidi on 26 January 2026, 06:05 > Updated Revision Comment by Nicholas Ramirez on 26 January 2026, 09:20 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26649 this may not work all the time the number of pre treatment steps are not a exact number of steps the steps are created dyniamically. Steps depend on: - advanced / standard mode - water sample featured/defreatured Keep this in mind and let come up with a way to navigate through the steps. Something like getting the "StepNavitgationTitleBar" componenet and accessing the "stepNames" property will give you a string list of the pre treatment steps. This is generating every time we enter pretreatment upon the conditions the test steps are made dynamically. Reply by Vendor - TEL - Divya Sree Nidamamidi on 29 January 2026, 03:00 > Modified the step to get all elements in the list dynamically > and performing the action based on user input Revision Comment by Behrouz NematiPour on 30 January 2026, 10:10 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26881 The translatable strings shall be defined in a global space. Generally, please make sure this is handled everywhere. Reply by Vendor - TEL - Divya Sree Nidamamidi on 02 February 2026, 22:38 > All strings are placed in config.py Revision Comment by Nicholas Ramirez on 19 January 2026, 14:12 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26422 variable name has been update to: vTransmembranePressureLimitWindowRejectReason Reply by Vendor - TEL - Divya Sree Nidamamidi on 20 January 2026, 04:02 > Variable name has been updated Revision Comment by Behrouz NematiPour on 30 January 2026, 10:12 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26883 Same (translation) Reply by Vendor - TEL - Divya Sree Nidamamidi on 02 February 2026, 22:39 > All strings are placed in config.py Revision Comment by Nicholas Ramirez on 26 January 2026, 09:51 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26650 should this be MODE_TREA ? Reply by Vendor - TEL - Divya Sree Nidamamidi on 26 January 2026, 22:40 > With new ui change after click on confirm no need to change > the mode Is this ok Can you please confirm Revision Comment by Nicholas Ramirez on 19 January 2026, 14:14 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26423 remove first test as it is done in the next test checking setting heparin to OFF.. The first test skips create rx where the second actually sets heparin to OFF and that is the test we want to keep in. Remove lines 143 - 154 Reply by Vendor - TEL - Divya Sree Nidamamidi on 20 January 2026, 04:02 > Removed the line Revision Comment by Nicholas Ramirez on 29 January 2026, 14:09 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26854 after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item) Reply by Vendor - TEL - Divya Sree Nidamamidi on 29 January 2026, 22:07 > Added the line Revision Comment by Nicholas Ramirez on 26 January 2026, 09:52 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26651 my test is failing here due to not clicking on the heparin tab. Are you seeing the same issue? Reply by Vendor - TEL - Divya Sree Nidamamidi on 26 January 2026, 22:32 > I am able to click on Heparin button Revision Comment by Nicholas Ramirez on 20 January 2026, 09:48 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26446 Please update with new steps from latest Staging build.. MODE_TPAR is now obsolete and to enter pre treatment to get to the create rx user must enter Pretreatment opmode. Reply by Vendor - TEL - Divya Sree Nidamamidi on 26 January 2026, 06:05 > Updated as per new modification Revision Comment by Nicholas Ramirez on 29 January 2026, 14:09 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1#c26855 after changing states to TREATMENT_DIALYSIS_STATE can you add the following line after waitForObject(names.o_listView_Item) Reply by Vendor - TEL - Divya Sree Nidamamidi on 29 January 2026, 22:06 > Added the line --- ID: LEAHI-TESTSUITES-LDT-2971-1 https://devapps.diality.us/cru/LEAHI-TESTSUITES-LDT-2971-1 Title: LEAHI-TESTSUITES-LDT-2971_Heparin - SW - 02 - Q&R Statement of Objectives: State: Review Author: Vendor - TEL - Divya Sree Nidamamidi Moderator: Nicholas Ramirez Reviewers: (7 active, 0 completed*) Tiffany Mejia Dara Navaei Behrouz NematiPour Vendor - TEL - Sivvanarayana Kurapati Vendor - TEL - Shivaprasad Basavaraju Daniel Ho Stephen Quong