This is a list of all comments for RO-LDT-1242-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Controllers/PermeateTank.c
Revision Comment by Sean Nash on 22 August 2025, 14:09 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23853

  Add comments to right of #defines.

  Reply by Michael Garthwaite on 03 September 2025, 10:15
  > fixed thanks!

Revision Comment by Sean Nash on 22 August 2025, 14:57 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23854

  6 seconds seems too brief to me.  Is this just a placeholder?

  Reply by Michael Garthwaite on 03 September 2025, 10:15
  > just a placeholder for now ( until SA updates ). bumped it to
  > 10 seconds in the meantime

Revision Comment by Sean Nash on 28 August 2025, 09:58 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23948

  I think tank control has priority over recovery configs.

  Reply by Michael Garthwaite on 03 September 2025, 10:13
  > removed comment.

----------------------------------------
File: AlarmDefs.h
Revision Comment by Sean Nash on 29 August 2025, 13:54 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23988

  I don't think alarms will work with gaps in this enum.  Other
  table(s) will complain I think.  Lookups will find wrong alarm,
  etc...

  Reply by Michael Garthwaite on 03 September 2025, 09:27
  > it was place holder until blood leak alarms are were in
  > staging. its in order now.

Revision Comment by Raghu Kallala on 04 September 2025, 08:19 
https://devapps.diality.us/cru/RO-LDT-1242-1#c24036

  fault -> FALSE

Revision Comment by Sean Nash on 22 August 2025, 14:09 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23852

  I see a couple faults down here at rank 110 - seems high for a
  fault.  Should be 10 I think.

  Reply by Michael Garthwaite on 03 September 2025, 10:20
  > updated pre-gen alarms that fault to rank 10

    Reply by Sean Nash on 03 September 2025, 12:43
    > Or maybe 110 was correct and fault property should be FALSE
    > and DD fault property should be TRUE?  This doesn't look
    > like a TD fault.  All other faults are DD faults.

      Reply by Michael Garthwaite on 04 September 2025, 08:39
      > reverted commit. Back to 110 ranking and changed
      > properties for DD fault = TRUE

----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Sean Nash on 28 August 2025, 09:55 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23943

  Align comments.

Revision Comment by Sean Nash on 28 August 2025, 09:55 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23944

  Remove extra blank line.

  Reply by Michael Garthwaite on 03 September 2025, 10:14
  > fixed thanks!

Revision Comment by Sean Nash on 28 August 2025, 09:56 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23945

  Add comment to right.

  Reply by Michael Garthwaite on 03 September 2025, 10:14
  > fixed thanks!

Revision Comment by Sean Nash on 28 August 2025, 09:56 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23946

  Align "=".

  Reply by Michael Garthwaite on 03 September 2025, 10:14
  > fixed thanks!

Revision Comment by Sean Nash on 28 August 2025, 09:56 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23947

  Add blank line after declarations.

  Reply by Michael Garthwaite on 03 September 2025, 10:13
  > fixed thanks!

----------------------------------------
File: firmware/App/Modes/FlushPermeate.c
Revision Comment by Sean Nash on 28 August 2025, 09:59 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23949

  Align comment.

  Reply by Michael Garthwaite on 03 September 2025, 10:13
  > fixed thanks!

----------------------------------------
File: firmware/App/Modes/ModePreGenPermeate.c
Revision Comment by Sean Nash on 29 August 2025, 14:02 
https://devapps.diality.us/cru/RO-LDT-1242-1#c23991

  Add comment to right.

  Reply by Michael Garthwaite on 03 September 2025, 10:12
  > fixed thanks!


---

ID: RO-LDT-1242-1 https://devapps.diality.us/cru/RO-LDT-1242-1

Title: RO-LDT-1242_Iofp Finalize Permeate Tank
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (6 active, 2 completed*)
     Sean Nash   (*)
     Raghu Kallala   (*)
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour
     Daniel Ho