This is a list of all comments for RO-LDT-332-1.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeWaterPreGen.c
Revision Comment by Sean Nash on 21 April 2025, 09:47 
https://devapps.diality.us/cru/RO-LDT-332-1#c21897

  Needs init, transition, and exec functions at a minimum.  Needs
  to handle DD msg to transition to gen water mode too.

  Reply by Michael Garthwaite on 24 April 2025, 11:17
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:37 
https://devapps.diality.us/cru/RO-LDT-332-1#c22003

  preGenWState is an input.

  Reply by Michael Garthwaite on 24 April 2025, 14:49
  > Fixed. Thanks!

Revision Comment by Vinayakam Mani on 24 April 2025, 12:08 
https://devapps.diality.us/cru/RO-LDT-332-1#c21990

  Remove blank line 93 and 108.

  Reply by Michael Garthwaite on 24 April 2025, 14:49
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:35 
https://devapps.diality.us/cru/RO-LDT-332-1#c22001

  Inputs should be "none".

  Reply by Michael Garthwaite on 24 April 2025, 14:49
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:37 
https://devapps.diality.us/cru/RO-LDT-332-1#c22002

  I think these should be // TODOs.  We're just not doing
  anything yet.

  Reply by Michael Garthwaite on 24 April 2025, 14:49
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:30 
https://devapps.diality.us/cru/RO-LDT-332-1#c21993

  Add a blank line between declarations and code.

  Reply by Michael Garthwaite on 24 April 2025, 14:46
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:31 
https://devapps.diality.us/cru/RO-LDT-332-1#c21994

  pendingStartGenRequest is an input.

  Reply by Michael Garthwaite on 24 April 2025, 14:46
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:31 
https://devapps.diality.us/cru/RO-LDT-332-1#c21995

  preGenWState is not an output.

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:32 
https://devapps.diality.us/cru/RO-LDT-332-1#c21997

  DD should be FP.
  preGenWExecState is an output.
  genDialysateDataPublicationTimerCounter is an output.

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:32 
https://devapps.diality.us/cru/RO-LDT-332-1#c21996

  \Sent should be \b Sent

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:34 
https://devapps.diality.us/cru/RO-LDT-332-1#c21998

  Looks weird aligning "=" with broadcast call inbetween.

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:34 
https://devapps.diality.us/cru/RO-LDT-332-1#c21999

  standbyState should be preGenWState.

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:35 
https://devapps.diality.us/cru/RO-LDT-332-1#c22000

  Should be pendingStartGenRequest.

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Fixed. Thanks!

Revision Comment by Vinayakam Mani on 24 April 2025, 12:04 
https://devapps.diality.us/cru/RO-LDT-332-1#c21989

  Have you added this function in message list ( MsgDefs.h and
  messaging.c)?

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Added. Thanks!

----------------------------------------
File: firmware/App/Modes/ModeWaterPreGen.h
Revision Comment by Sean Nash on 21 April 2025, 09:55 
https://devapps.diality.us/cru/RO-LDT-332-1#c21905

  Add doxygen group.  Add function prototypes for init,
  transition and exec functions.

  Reply by Michael Garthwaite on 24 April 2025, 11:18
  > Fixed. Thanks!

Revision Comment by Sean Nash on 24 April 2025, 12:26 
https://devapps.diality.us/cru/RO-LDT-332-1#c21992

  Remove extra blank line.

  Reply by Michael Garthwaite on 24 April 2025, 14:45
  > Fixed. Thanks!

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Sean Nash on 21 April 2025, 09:48 
https://devapps.diality.us/cru/RO-LDT-332-1#c21898

  Alphabetize.

  Reply by Michael Garthwaite on 24 April 2025, 11:18
  > Fixed. Thanks!

Revision Comment by Sean Nash on 21 April 2025, 09:48 
https://devapps.diality.us/cru/RO-LDT-332-1#c21899

  Add init for pre gen.

  Reply by Michael Garthwaite on 24 April 2025, 11:18
  > Fixed. Thanks!

Revision Comment by Sean Nash on 21 April 2025, 09:49 
https://devapps.diality.us/cru/RO-LDT-332-1#c21900

  Add a condition that we not have a Dialin user logged into FP.
  If FP Dialin tester is logged in, we don't want to enforce
  legal mode transitions because we want to allow the set mode
  command to take us anywhere from any mode.

Revision Comment by Sean Nash on 21 April 2025, 09:51 
https://devapps.diality.us/cru/RO-LDT-332-1#c21901

  Add case for pre gen.

Revision Comment by Sean Nash on 21 April 2025, 09:51 
https://devapps.diality.us/cru/RO-LDT-332-1#c21902

  Add case for pre gen.

  Reply by Michael Garthwaite on 24 April 2025, 11:21
  > Fixed. Thanks!

----------------------------------------
File: firmware/App/Services/AlarmMgmtRO.c
Revision Comment by Sean Nash on 21 April 2025, 09:52 
https://devapps.diality.us/cru/RO-LDT-332-1#c21903

  Add a #define for this unit (i.e. #define __ALARM_MGMT_RO_C__)

  Reply by Michael Garthwaite on 24 April 2025, 11:17
  > Fixed. Thanks!

----------------------------------------
File: firmware/App/Services/DDInterface.c
Revision Comment by Sean Nash on 21 April 2025, 09:53 
https://devapps.diality.us/cru/RO-LDT-332-1#c21904

  Alphabetize.

  Reply by Michael Garthwaite on 24 April 2025, 11:17
  > Fixed. Thanks!

Revision Comment by Vinayakam Mani on 24 April 2025, 11:54 
https://devapps.diality.us/cru/RO-LDT-332-1#c21986

  Remove Extra line?

  Reply by Michael Garthwaite on 24 April 2025, 14:52
  > Fixed. Thanks!

Revision Comment by Vinayakam Mani on 24 April 2025, 11:55 
https://devapps.diality.us/cru/RO-LDT-332-1#c21987

  Let DD interface send a signal to pre-gen mode and pre-gen mode
  state machine handling switching to standby mode (after
  stopping actuators etc.).  Please follow the same for below
  function as well.

  Reply by Michael Garthwaite on 24 April 2025, 15:25
  > Fixed. Thanks. Functions in their respective mode files

----------------------------------------
File: RODefs.h
Revision Comment by Vinayakam Mani on 24 April 2025, 11:59 
https://devapps.diality.us/cru/RO-LDT-332-1#c21988

  Is there a recirculation mode when there is no water generation
  (per system team state machine)? or recirculation handled part
  of sub state of Gen water mode (I guess the name of mode (GENW)
  sounds always generating water, better to have recirculation as
  a mode instead of sub state?)

  Reply by Michael Garthwaite on 24 April 2025, 14:48
  > PRS is stating that it would be a sub state of water
  > generation mode. Its also unsure if it will be required at
  > the moment. With it being not too defined, I didnt think it
  > was a good idea to implement it in this epic

----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Sean Nash on 24 April 2025, 12:25 
https://devapps.diality.us/cru/RO-LDT-332-1#c21991

  If not aligning "=", don't add extra spacing.


---

ID: RO-LDT-332-1 https://devapps.diality.us/cru/RO-LDT-332-1

Title: RO-LDT-332_Basic Dialysis Treatment FP
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (4 active, 2 completed*)
     Sean Nash   (*)
     Vinayakam Mani   (*)
     Tiffany Mejia
     Dara Navaei
     Behrouz NematiPour
     Daniel Ho