This is a list of all comments for RO-LDT-566-4.

Review Summary: No summary


----------------------------------------
File: firmware/App/Services/SystemCommFP.c
Revision Comment by Sean Nash on 12 August 2025, 13:48 
https://devapps.diality.us/cru/RO-LDT-566-4#c23650

  When commenting out problematic alarms (temporarily), can we at
  least send an event w/ same 2 datas for logging purposes so we
  can investigate later?

----------------------------------------
File: firmware/App/Controllers/Valves.h
Revision Comment by Sean Nash on 19 August 2025, 08:52 
https://devapps.diality.us/cru/RO-LDT-566-4#c23821

  Where did these move to?

----------------------------------------
File: firmware/App/Modes/FlushPermeate.c
Revision Comment by Sean Nash on 19 August 2025, 08:55 
https://devapps.diality.us/cru/RO-LDT-566-4#c23822

  Align comment.

----------------------------------------
File: firmware/App/Controllers/ROPump.c
Revision Comment by Sean Nash on 19 August 2025, 08:37 
https://devapps.diality.us/cru/RO-LDT-566-4#c23812

  Realign comments.

Revision Comment by Sean Nash on 19 August 2025, 08:38 
https://devapps.diality.us/cru/RO-LDT-566-4#c23813

  Are we going to change back to duty cycle % as control signal
  output?

Revision Comment by Sean Nash on 19 August 2025, 08:39 
https://devapps.diality.us/cru/RO-LDT-566-4#c23814

  Remove extra blank line.

Revision Comment by Sean Nash on 19 August 2025, 08:45 
https://devapps.diality.us/cru/RO-LDT-566-4#c23818

  Add comment to right.
  And it looks like this flag only relates to flow control - so
  variable name and comment should reflect that.

Revision Comment by Sean Nash on 19 August 2025, 08:45 
https://devapps.diality.us/cru/RO-LDT-566-4#c23817

  Align "=".

Revision Comment by Sean Nash on 19 August 2025, 08:40 
https://devapps.diality.us/cru/RO-LDT-566-4#c23815

  Add blank line after declarations.

Revision Comment by Sean Nash on 19 August 2025, 08:44 
https://devapps.diality.us/cru/RO-LDT-566-4#c23816

  Should this be an "else if"?

Revision Comment by Sean Nash on 19 August 2025, 08:48 
https://devapps.diality.us/cru/RO-LDT-566-4#c23819

  This "if" is not necessary.  Just assign to TRUE regardless.

Revision Comment by Sean Nash on 19 August 2025, 08:49 
https://devapps.diality.us/cru/RO-LDT-566-4#c23820

  These broadcast changes look like temporary test changes.
  Restore before merging this branch to staging.


---

ID: RO-LDT-566-4 https://devapps.diality.us/cru/RO-LDT-566-4

Title: RO-LDT-566_Water Treatment And Degassing FP 2
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (7 active, 0 completed*)
     Sean Nash
     Nicholas Ramirez
     Tiffany Mejia
     Vinayakam Mani
     Dara Navaei
     Behrouz NematiPour
     Daniel Ho