This is a list of all comments for SCRIPTS-DEN-16686-1.

Review Summary: No summary


----------------------------------------
File: local/run.coco.sh
Revision Comment by Behrouz NematiPour on 08 March 2024, 11:27 
https://devapps.diality.us/cru/SCRIPTS-DEN-16686-1#c19594

  Generally, as has been decided the current code should be
  untouched and just adding some extra functionality.
  Therefore, some block of code shall be seen to be added not the
  entire script.
  please keep your modifications only to what is changed and try
  to do not change the entire code.
  
  The code changes should be so surgical in very focused space
  not everywhere.
  
  Thanks

  Reply by msuleiman on 08 March 2024, 16:22
  > Done

Revision Comment by Behrouz NematiPour on 08 March 2024, 11:22 
https://devapps.diality.us/cru/SCRIPTS-DEN-16686-1#c19590

  please return the comments back in this script.
  these two lines are examples of actual run.
  The rest is commented by group.

  Reply by msuleiman on 08 March 2024, 16:22
  > Done

Revision Comment by Behrouz NematiPour on 08 March 2024, 11:25 
https://devapps.diality.us/cru/SCRIPTS-DEN-16686-1#c19593

  used 2 empty line space in this script.
  so please return them back.

  Reply by msuleiman on 08 March 2024, 16:23
  > Done

Revision Comment by Behrouz NematiPour on 08 March 2024, 11:23 
https://devapps.diality.us/cru/SCRIPTS-DEN-16686-1#c19591

  please don't use # leading lines.
  it fills the code with unnecessary comment line.s

  Reply by msuleiman on 08 March 2024, 16:23
  > Done

Revision Comment by Behrouz NematiPour on 08 March 2024, 11:24 
https://devapps.diality.us/cru/SCRIPTS-DEN-16686-1#c19592

  keep this and the similar ones.

  Reply by msuleiman on 08 March 2024, 16:23
  > Done

Revision Comment by Behrouz NematiPour on 08 March 2024, 11:34 
https://devapps.diality.us/cru/SCRIPTS-DEN-16686-1#c19595

  these comments are redundant and are Linux commands comments.
  please remove this and similar ones.

  Reply by msuleiman on 08 March 2024, 16:23
  > Done


---

ID: SCRIPTS-DEN-16686-1 https://devapps.diality.us/cru/SCRIPTS-DEN-16686-1

Title: SCRIPTS-DEN-16686_UI MS S117 Integration
Statement of Objectives:


State: Closed

Summary: 

Author: msuleiman
Moderator: Behrouz NematiPour
Reviewers: (5 active, 0 completed*)
     Sean Nash
     Tiffany Mejia
     Vinayakam Mani
     Michael Garthwaite
     Dara Navaei