This is a list of all comments for SRVC-DEN-7335-1.

Review Summary: No summary


----------------------------------------
File: fwcontroller/main/dg.py
Revision Comment by pmontazemi on 21 April 2021, 10:46 
https://devapps.diality.us/cru/SRVC-DEN-7335-1#c9532

  Remove extra line.

  Reply by pmontazemi on 21 April 2021, 13:09
  > RESOLVED.

----------------------------------------
File: fwcontroller/submodule/submodule_control.py
Revision Comment by pmontazemi on 21 April 2021, 10:48 
https://devapps.diality.us/cru/SRVC-DEN-7335-1#c9533

  Would the end-user know the type of parameter to be sent, or
  does it make sense to make that choice for them automatically?
  Think that not all end-users are SW savvy (manufacturing,
  service, etc.)

  Reply by plucia on 21 April 2021, 10:51
  > Agreed - I don't want them to have to guess the type. At the
  > time the dropdown was really a backup option in case the type
  > hints approach wasn't feasible. Currently in a difference
  > branch I'm in the process of upgrading the service app to
  > provide type hints for each command to make it easier for the
  > user.

    Reply by pmontazemi on 21 April 2021, 13:08
    > RESOLVED.


---

ID: SRVC-DEN-7335-1 https://devapps.diality.us/cru/SRVC-DEN-7335-1

Title: SRVC-DEN-7335_DIAL-76 Data Logging
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Reviewers: (0 active, 3 completed*)
     Sean Nash   (*)
     Behrouz NematiPour   (*)
     pmontazemi   (*)