This is a list of all comments for TD-LDT-1886-7. Review Summary: No summary ---------------------------------------- File: firmware/App/Controllers/AirTrap.h Revision Comment by Sean Nash on 29 September 2025, 09:14 https://devapps.diality.us/cru/TD-LDT-1886-7#c24458 Add doxygen comment to right. Reply by Dara Navaei on 07 November 2025, 08:39 > Done ---------------------------------------- File: firmware/App/Controllers/Valves.c Revision Comment by Sean Nash on 29 September 2025, 09:29 https://devapps.diality.us/cru/TD-LDT-1886-7#c24461 Remove extra blank line. Reply by Dara Navaei on 07 November 2025, 08:39 > Done Revision Comment by Vendor - TEL - Sameer Poyil on 10 November 2025, 10:01 https://devapps.diality.us/cru/TD-LDT-1886-7#c25053 documentation error- is it transition start time ? Revision Comment by Sean Nash on 29 September 2025, 09:35 https://devapps.diality.us/cru/TD-LDT-1886-7#c24462 Why is this "if" needed? For loop will not go beyond NUM_OF_VALVES. Revision Comment by Sean Nash on 29 September 2025, 09:36 https://devapps.diality.us/cru/TD-LDT-1886-7#c24463 Not needed. Revision Comment by Sean Nash on 23 October 2025, 15:24 https://devapps.diality.us/cru/TD-LDT-1886-7#c24790 I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing). Revision Comment by Sean Nash on 29 September 2025, 09:39 https://devapps.diality.us/cru/TD-LDT-1886-7#c24464 I think we still want a s/w fault if we get here. If stack gets corrupted, we can still get here. Reply by Dara Navaei on 08 November 2025, 16:04 > Done Revision Comment by Sean Nash on 23 October 2025, 15:25 https://devapps.diality.us/cru/TD-LDT-1886-7#c24791 I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing). Revision Comment by Sean Nash on 29 September 2025, 09:40 https://devapps.diality.us/cru/TD-LDT-1886-7#c24465 Please add a s/w fault here. Reply by Dara Navaei on 08 November 2025, 16:04 > Done Revision Comment by Sean Nash on 23 October 2025, 15:25 https://devapps.diality.us/cru/TD-LDT-1886-7#c24792 I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing). Revision Comment by Sean Nash on 29 September 2025, 09:40 https://devapps.diality.us/cru/TD-LDT-1886-7#c24466 Please add s/w fault here. Reply by Dara Navaei on 08 November 2025, 16:03 > Done Revision Comment by Sean Nash on 29 September 2025, 09:44 https://devapps.diality.us/cru/TD-LDT-1886-7#c24468 Why are you removing this check? Reply by Dara Navaei on 08 November 2025, 16:03 > The checks are back in a generic function. Revision Comment by Sean Nash on 29 September 2025, 09:52 https://devapps.diality.us/cru/TD-LDT-1886-7#c24471 posA = posC + ( ( curPos - posC ) / 2 ); Reply by Dara Navaei on 23 October 2025, 14:17 > Done Revision Comment by Sean Nash on 29 September 2025, 09:46 https://devapps.diality.us/cru/TD-LDT-1886-7#c24469 Should we set hasValveBeenReset to FALSE here? Reply by Dara Navaei on 08 November 2025, 15:16 > Done Revision Comment by Sean Nash on 29 September 2025, 09:43 https://devapps.diality.us/cru/TD-LDT-1886-7#c24467 Publish posD too. Reply by Dara Navaei on 23 October 2025, 14:40 > Done ---------------------------------------- File: firmware/App/Drivers/GLXferPump.h Revision Comment by Sean Nash on 29 September 2025, 10:09 https://devapps.diality.us/cru/TD-LDT-1886-7#c24474 Too strong for filling. Maybe 60? Reply by Dara Navaei on 07 November 2025, 08:40 > Done ---------------------------------------- File: firmware/App/TDCommon.h Revision Comment by Sean Nash on 29 September 2025, 10:16 https://devapps.diality.us/cru/TD-LDT-1886-7#c24478 Did we remove support for this NO_PINCH_VALVES build switch? If so, remove the switch. Reply by Dara Navaei on 20 October 2025, 17:26 > Done ---------------------------------------- File: firmware/App/Drivers/RotaryValve.c Revision Comment by Sean Nash on 29 September 2025, 10:14 https://devapps.diality.us/cru/TD-LDT-1886-7#c24476 Why is this removed? Reply by Dara Navaei on 23 October 2025, 14:07 > The valves are initialized in the valves driver in the first > state. Revision Comment by Sean Nash on 29 September 2025, 10:15 https://devapps.diality.us/cru/TD-LDT-1886-7#c24477 Why would we not initialize FPGA control? Is it too soon? Reply by Dara Navaei on 23 October 2025, 14:08 > They are initialized in the valves driver. Reply by Sean Nash on 23 October 2025, 15:27 > Ok, but then I think the valves controller should be > calling a function in this driver to accomplish this kind > of thing since it's a driver level activity. Reply by Dara Navaei on 08 November 2025, 15:25 > Done Revision Comment by Sean Nash on 10 November 2025, 09:39 https://devapps.diality.us/cru/TD-LDT-1886-7#c25042 I don't see this input used in function. Revision Comment by Sean Nash on 10 November 2025, 09:39 https://devapps.diality.us/cru/TD-LDT-1886-7#c25043 None? Reply by Dara Navaei on 10 November 2025, 09:40 > Done Revision Comment by Sean Nash on 10 November 2025, 09:40 https://devapps.diality.us/cru/TD-LDT-1886-7#c25044 None? Reply by Dara Navaei on 10 November 2025, 09:40 > Done ---------------------------------------- File: firmware/App/Drivers/RotaryValve.h Revision Comment by Sean Nash on 29 September 2025, 10:11 https://devapps.diality.us/cru/TD-LDT-1886-7#c24475 1760 is now the expected nominal count for full travel? If 1760 is center of bell curve and 1700 is minimum, then 1820 should be max (not 1900)? Reply by Dara Navaei on 23 October 2025, 14:10 > 1760 is a nominal value. The driver will keep adding steps if > 1760 worked for the first time. These values are suggested by > the hardware team. ---------------------------------------- File: firmware/App/Controllers/Valves.h Revision Comment by Sean Nash on 29 September 2025, 09:28 https://devapps.diality.us/cru/TD-LDT-1886-7#c24459 Partial Close? Revision Comment by Sean Nash on 29 September 2025, 09:29 https://devapps.diality.us/cru/TD-LDT-1886-7#c24460 Add a posD. ---------------------------------------- File: firmware/App/Controllers/BloodFlow.c Revision Comment by Sean Nash on 16 October 2025, 12:58 https://devapps.diality.us/cru/TD-LDT-1886-7#c24720 Replace current with torque. Reply by Dara Navaei on 20 October 2025, 17:05 > Remove the variable. Revision Comment by Sean Nash on 16 October 2025, 12:59 https://devapps.diality.us/cru/TD-LDT-1886-7#c24721 BloodFlow.c should have a public get function for torque like other overrides. Reply by Dara Navaei on 20 October 2025, 17:11 > Done ---------------------------------------- File: firmware/App/Controllers/BloodFlow.h Revision Comment by Sean Nash on 16 October 2025, 12:56 https://devapps.diality.us/cru/TD-LDT-1886-7#c24719 Replace measured current with measured torque. Reply by Dara Navaei on 20 October 2025, 17:13 > Done ---------------------------------------- File: firmware/App/Modes/ModePreTreat.c Revision Comment by Sean Nash on 29 September 2025, 10:19 https://devapps.diality.us/cru/TD-LDT-1886-7#c24482 Add defs and data banners. Reply by Dara Navaei on 20 October 2025, 17:20 > Done. This is a temporary variable and it will be removed. Revision Comment by Sean Nash on 29 September 2025, 10:19 https://devapps.diality.us/cru/TD-LDT-1886-7#c24483 Add function headers. Reply by Dara Navaei on 20 October 2025, 17:24 > Done Revision Comment by Sean Nash on 29 September 2025, 10:20 https://devapps.diality.us/cru/TD-LDT-1886-7#c24484 Add blank line before return. Reply by Dara Navaei on 20 October 2025, 17:19 > Done Revision Comment by Sean Nash on 29 September 2025, 10:19 https://devapps.diality.us/cru/TD-LDT-1886-7#c24481 Remove extra blank line. Reply by Dara Navaei on 20 October 2025, 17:19 > Done ---------------------------------------- File: firmware/App/Modes/ModePreTreat.h Revision Comment by Sean Nash on 29 September 2025, 10:18 https://devapps.diality.us/cru/TD-LDT-1886-7#c24480 Remove 2 of these extra blank lines. Reply by Dara Navaei on 20 October 2025, 17:25 > Done ---------------------------------------- File: firmware/App/Modes/ModeTreatment.c Revision Comment by Sean Nash on 29 September 2025, 10:18 https://devapps.diality.us/cru/TD-LDT-1886-7#c24479 I don't think we want to keep this change. Reply by Dara Navaei on 20 October 2025, 17:26 > Do you mean to delete this function? Reply by Sean Nash on 03 November 2025, 16:50 > I mean, don't you think Sarina/Eliza still want this test > config option? Why did you comment it out? Reply by Dara Navaei on 07 November 2025, 08:43 > The test configuration has not been imported yet. I > commented it out as a placeholder. Reply by Sean Nash on 10 November 2025, 09:43 > Then put an #if 0 around this if and add a TODO comment > to implement the test configuration. Reply by Dara Navaei on 10 November 2025, 09:58 > Done ---------------------------------------- File: firmware/App/Drivers/PressureSensor.c Revision Comment by Sean Nash on 03 November 2025, 16:39 https://devapps.diality.us/cru/TD-LDT-1886-7#c24974 Make 10000 a #define. Reply by Dara Navaei on 07 November 2025, 08:42 > Done --- ID: TD-LDT-1886-7 https://devapps.diality.us/cru/TD-LDT-1886-7 Title: LEAHI-TD-LDT-1886_Blood Set Auto-Load and Auto-Eject - TD Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (6 active, 3 completed*) Vendor - TEL - Jashwant Gantyada (*) Sean Nash (*) Vendor - TEL - Sameer Poyil (*) Vendor - TEL - Arpita Srivastava Vendor - TEL - Varshini Nagabooshanam Vinayakam Mani Michael Garthwaite Vendor - TEL - Sivvanarayana Kurapati Daniel Ho