This is a list of all comments for TD-LDT-802-1. Review Summary: No summary ---------------------------------------- File: .gitignore Revision Comment by Sean Nash on 27 July 2025, 22:10 https://devapps.diality.us/cru/TD-LDT-802-1#c23168 Why is this file deleted? Reply by Dara Navaei on 28 July 2025, 08:53 > This was in the wrong place. ---------------------------------------- File: firmware/App/Modes/ModeFault.c Revision Comment by Sean Nash on 27 July 2025, 22:14 https://devapps.diality.us/cru/TD-LDT-802-1#c23169 Add a comment that we are consuming and ignoring stop button press events here. Reply by Dara Navaei on 28 July 2025, 09:43 > Done Revision Comment by Sean Nash on 27 July 2025, 22:15 https://devapps.diality.us/cru/TD-LDT-802-1#c23170 Why de-energized state? Reply by Dara Navaei on 28 July 2025, 09:43 > I changed it back to energized state. Revision Comment by Sean Nash on 27 July 2025, 22:17 https://devapps.diality.us/cru/TD-LDT-802-1#c23171 Do we need a way to abort an ejector operation if it is in progress when fault triggered? Reply by Dara Navaei on 28 July 2025, 13:09 > Added an abort ejector request. ---------------------------------------- File: firmware/App/Modes/StateTxPaused.c Revision Comment by Sean Nash on 27 July 2025, 22:18 https://devapps.diality.us/cru/TD-LDT-802-1#c23172 I thought we were going to leave BLD state out for now? Reply by Dara Navaei on 28 July 2025, 09:20 > I brought the code in but they are not called. Revision Comment by Sean Nash on 27 July 2025, 22:24 https://devapps.diality.us/cru/TD-LDT-802-1#c23174 Do we need to require door closed in the 2 states where blood pump is running (blood recirculating)? And do we need to allow door open in the other state where only dialysate recircs (no BP running so ok to open door)? Seems like better place for all of this is in transitionToTxPausedState(). Reply by Dara Navaei on 28 July 2025, 09:59 > I added the door require function. Revision Comment by Sean Nash on 27 July 2025, 22:26 https://devapps.diality.us/cru/TD-LDT-802-1#c23175 Why not leave these un-commented? Reply by Dara Navaei on 28 July 2025, 09:13 > The alarms have not been reserved until the we complete the > alarms table. Reply by Sean Nash on 28 July 2025, 11:10 > Will we add these alarms to table in this branch? Reply by Dara Navaei on 01 August 2025, 11:52 > Done Revision Comment by Sean Nash on 27 July 2025, 22:23 https://devapps.diality.us/cru/TD-LDT-802-1#c23173 Vectorcast won't be able to reach inside this if statement. It's dead code for now. Maybe better to just comment it out. Reply by Dara Navaei on 28 July 2025, 09:41 > I tried to have the code as close as possible to the actual > code. We can comment out if the VectorCAST ran into an issue. Revision Comment by Sean Nash on 27 July 2025, 22:28 https://devapps.diality.us/cru/TD-LDT-802-1#c23176 Add blank line between declarations and code. Reply by Dara Navaei on 28 July 2025, 09:11 > Done Revision Comment by Sean Nash on 27 July 2025, 22:30 https://devapps.diality.us/cru/TD-LDT-802-1#c23177 I think dialyzer should always be bypassed (all sub-states) on transition into TxPaused state (main transition function at top of unit) just once - then we wouldn't need to worry about it in this function. Also, similarly, UF should always be set to zero rate in Tx Paused. Reply by Dara Navaei on 28 July 2025, 09:12 > This is repeated here to make sure all the actuators are set > in this function for completeness. Revision Comment by Sean Nash on 28 July 2025, 13:57 https://devapps.diality.us/cru/TD-LDT-802-1#c23194 Should be TRUE since BP is running. Reply by Dara Navaei on 28 July 2025, 14:03 > Done ---------------------------------------- File: firmware/App/Controllers/Ejector.c Revision Comment by Sean Nash on 28 July 2025, 13:50 https://devapps.diality.us/cru/TD-LDT-802-1#c23191 I think we should only stop pump and go to abort state if an operation is in progress. Look at current state to see if we need to abort anything. Reply by Dara Navaei on 01 August 2025, 11:42 > Done Revision Comment by Sean Nash on 28 July 2025, 13:51 https://devapps.diality.us/cru/TD-LDT-802-1#c23192 Move this above switch statement. Reply by Dara Navaei on 28 July 2025, 14:04 > Done Revision Comment by Sean Nash on 28 July 2025, 13:52 https://devapps.diality.us/cru/TD-LDT-802-1#c23193 Is this intended to be a terminal state? If so, add comment here noting that. If not, we need a way to exit this state and recover (handling here should look a lot like start state handler where we would act on a homing request which would take us to homing state). Reply by Dara Navaei on 28 July 2025, 14:29 > I made the state as non-terminal. ---------------------------------------- File: firmware/App/Controllers/Ejector.h Revision Comment by Sean Nash on 28 July 2025, 13:48 https://devapps.diality.us/cru/TD-LDT-802-1#c23190 Rename to "abortEjectorOperation". Reply by Dara Navaei on 28 July 2025, 14:06 > Done ---------------------------------------- File: AlarmDefs.h Revision Comment by Sean Nash on 31 July 2025, 14:44 https://devapps.diality.us/cru/TD-LDT-802-1#c23330 Dialysate temperature alarms should be TRUE for auto resume. Reply by Dara Navaei on 01 August 2025, 11:12 > Done ---------------------------------------- File: AlarmMgmt.c Revision Comment by Sean Nash on 31 July 2025, 14:46 https://devapps.diality.us/cru/TD-LDT-802-1#c23331 This should not be necessary. Already included by AlarmMgmt.h which includes TDCommon.h which includes Common.h which includes AlarmMgmtTD.h. Reply by Dara Navaei on 01 August 2025, 10:52 > Done ---------------------------------------- File: firmware/App/Services/AlarmMgmtTD.c Revision Comment by Sean Nash on 01 August 2025, 14:27 https://devapps.diality.us/cru/TD-LDT-802-1#c23385 Status should only be TRUE if msg accepted and signal sent. Move into if statement above. Reply by Dara Navaei on 01 August 2025, 14:29 > Done Revision Comment by Sean Nash on 01 August 2025, 14:27 https://devapps.diality.us/cru/TD-LDT-802-1#c23386 I don't think we need this. Reply by Dara Navaei on 01 August 2025, 14:29 > Done Revision Comment by Sean Nash on 31 July 2025, 14:55 https://devapps.diality.us/cru/TD-LDT-802-1#c23332 Use alarmStatus structure to check whether alarm resume is allowed. proprs only looks at the passed alarm. Reply by Dara Navaei on 01 August 2025, 10:52 > Done ---------------------------------------- File: firmware/App/Controllers/AirTrap.c Revision Comment by Sean Nash on 01 August 2025, 14:20 https://devapps.diality.us/cru/TD-LDT-802-1#c23382 Remove blank line. Reply by Dara Navaei on 01 August 2025, 14:23 > Done --- ID: TD-LDT-802-1 https://devapps.diality.us/cru/TD-LDT-802-1 Title: TD-LDT-802_Stop State TD Statement of Objectives: State: Closed Summary: Author: Dara Navaei Moderator: Dara Navaei Reviewers: (3 active, 2 completed*) Sean Nash (*) Michael Garthwaite (*) jpaguio Vinayakam Mani Daniel Ho