This is a list of all comments for TD-LDT-94-3.

Review Summary: No summary


----------------------------------------
File: firmware/App/Modes/ModeStandby.c
Revision Comment by Vinayakam Mani on 21 April 2025, 13:25 
https://devapps.diality.us/cru/TD-LDT-94-3#c21914

  you may need to remove these variables:" disinfectCancelReqID,
  homingInitiated"?

  Reply by Sean Nash on 21 April 2025, 17:16
  > Fixed.

Revision Comment by Vinayakam Mani on 21 April 2025, 13:26 
https://devapps.diality.us/cru/TD-LDT-94-3#c21915

  DD. also remove dialysate pumps reference below.

  Reply by Sean Nash on 21 April 2025, 17:15
  > Fixed.

Revision Comment by Vinayakam Mani on 21 April 2025, 13:29 
https://devapps.diality.us/cru/TD-LDT-94-3#c21916

  Remove/update comment as required.

  Reply by Sean Nash on 21 April 2025, 17:14
  > Fixed.

----------------------------------------
File: firmware/App/Modes/OperationModes.c
Revision Comment by Vinayakam Mani on 21 April 2025, 14:44 
https://devapps.diality.us/cru/TD-LDT-94-3#c21925

  Move to Init routine.

  Reply by Sean Nash on 22 April 2025, 08:41
  > Done.

Revision Comment by Vinayakam Mani on 21 April 2025, 14:52 
https://devapps.diality.us/cru/TD-LDT-94-3#c21926

  TD

  Reply by Sean Nash on 21 April 2025, 16:39
  > Fixed.

----------------------------------------
File: firmware/App/Modes/ModeTreatment.c
Revision Comment by Vinayakam Mani on 21 April 2025, 13:37 
https://devapps.diality.us/cru/TD-LDT-94-3#c21917

  Move below to maintain alphabetical order?

  Reply by Sean Nash on 21 April 2025, 17:13
  > Removed.  Not necessary.

Revision Comment by Vinayakam Mani on 21 April 2025, 13:39 
https://devapps.diality.us/cru/TD-LDT-94-3#c21918

  Just ultrafiltration (remove saline)?

  Reply by Sean Nash on 21 April 2025, 17:12
  > Fixed.

Revision Comment by Vinayakam Mani on 21 April 2025, 13:41 
https://devapps.diality.us/cru/TD-LDT-94-3#c21919

  Do you want to move these initializations as part of Init
  routine?

  Reply by Sean Nash on 21 April 2025, 17:11
  > Yes.  Done.

Revision Comment by Vinayakam Mani on 21 April 2025, 14:00 
https://devapps.diality.us/cru/TD-LDT-94-3#c21920

  signalEndTreatment?

  Reply by Sean Nash on 21 April 2025, 17:02
  > Fixed.

Revision Comment by Vinayakam Mani on 21 April 2025, 14:02 
https://devapps.diality.us/cru/TD-LDT-94-3#c21921

  Please add alarm.

  Reply by Sean Nash on 21 April 2025, 17:02
  > Done.

----------------------------------------
File: firmware/App/Modes/ModeTxParams.c
Revision Comment by Vinayakam Mani on 21 April 2025, 14:20 
https://devapps.diality.us/cru/TD-LDT-94-3#c21922

  min:50?

  Reply by Sean Nash on 21 April 2025, 16:58
  > Fixed.

Revision Comment by Michael Garthwaite on 22 April 2025, 09:19 
https://devapps.diality.us/cru/TD-LDT-94-3#c21958

  this init is already being called in operationmode.c's init
  function. Do we need the redundancy?

  Reply by Sean Nash on 22 April 2025, 09:31
  > OperationModes.c init function is only at power up.  This
  > call to init treatment mode is intended to re-init treatment
  > mode before each treatment starts.

    Reply by Michael Garthwaite on 22 April 2025, 09:39
    > RESOLVED.

Revision Comment by Michael Garthwaite on 22 April 2025, 09:21 
https://devapps.diality.us/cru/TD-LDT-94-3#c21959

  Shouldn't these bools be set to a specific value?

  Reply by Sean Nash on 22 April 2025, 09:34
  > These get set (lines 485 and 488) before they are used (line
  > 491).  No need to initialize before then.

    Reply by Michael Garthwaite on 22 April 2025, 09:39
    > RESOLVED.

Revision Comment by Vinayakam Mani on 21 April 2025, 14:34 
https://devapps.diality.us/cru/TD-LDT-94-3#c21923

  Add events/alarms ( throughout the file)

  Reply by Sean Nash on 21 April 2025, 16:54
  > Done.

Revision Comment by Vinayakam Mani on 21 April 2025, 14:34 
https://devapps.diality.us/cru/TD-LDT-94-3#c21924

  update as required (few functions Inputs and outputs are either
  empty or none, please fill in as applicable)

  Reply by Sean Nash on 21 April 2025, 16:53
  > Fixed.

----------------------------------------
File: firmware/App/Modes/StateTxDialysis.c
Revision Comment by Vinayakam Mani on 21 April 2025, 15:13 
https://devapps.diality.us/cru/TD-LDT-94-3#c21930

  Please add message sent.

  Reply by Sean Nash on 21 April 2025, 16:31
  > Done.

Revision Comment by Vinayakam Mani on 21 April 2025, 15:00 
https://devapps.diality.us/cru/TD-LDT-94-3#c21927

  Add alarm/event.

  Reply by Sean Nash on 21 April 2025, 16:38
  > Done.

Revision Comment by Vinayakam Mani on 21 April 2025, 15:06 
https://devapps.diality.us/cru/TD-LDT-94-3#c21928

  Update I/O. please revisit across the file.

  Reply by Sean Nash on 21 April 2025, 16:37
  > Done.

----------------------------------------
File: firmware/App/Modes/StateTxPaused.c
Revision Comment by Vinayakam Mani on 21 April 2025, 15:11 
https://devapps.diality.us/cru/TD-LDT-94-3#c21929

  Please add alarm/events.

  Reply by Sean Nash on 21 April 2025, 16:34
  > Done.


---

ID: TD-LDT-94-3 https://devapps.diality.us/cru/TD-LDT-94-3

Title: TD-LDT-94_Main Treatment Screen Implement
Statement of Objectives:


State: Closed

Summary: 

Author: Sean Nash
Moderator: Sean Nash
Reviewers: (6 active, 2 completed*)
     Vinayakam Mani   (*)
     Michael Garthwaite   (*)
     Tiffany Mejia
     jpaguio
     Raghu Kallala
     Dara Navaei
     Behrouz NematiPour
     Daniel Ho