This is a list of all comments for TESTSUITES-DEN-3724-1.

Review Summary: No summary

General Comment by Behrouz NematiPour on 07 October 2020, 15:33 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5378

  This is supposed to be part of the code review of the actual
  code which has been tested, so it can be seen clearly what has
  been tested and to what extend.
  Please add it to the code review of the implemented code.

  Reply by plucia on 14 October 2020, 14:19
  > Done. It is linked to that review now. See above "Linked
  > reviews: UI-DEN-3605-4"

    Reply by Behrouz NematiPour on 15 October 2020, 11:08
    > RESOLVED


----------------------------------------
File: tools/run_tests.sh
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:40 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5387

  What is this file used for?
  Please put comments.

  Reply by plucia on 14 October 2020, 15:09
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:07
    > RESOLVED

----------------------------------------
File: tst_AlarmStatusData/test.py
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:38 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5385

  Why this is added?
  The unit test for that feature was working and all the tests
  and coverage passed.
  Why it has been modified?
  Please remove it.

  Reply by plucia on 14 October 2020, 15:08
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:04
    > RESOLVED

----------------------------------------
File: tst_DGOperationMode/test.py
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:35 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5379

  Why this is added?
  The unit test for that feature was working and all the tests
  and coverage passed.
  Why it has been modified?
  Please remove it.

  Reply by plucia on 14 October 2020, 15:08
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:08
    > RESOLVED

----------------------------------------
File: tst_DGROPumpData/test.py
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:36 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5380

  Why this is added?
  The unit test for that feature was working and all the tests
  and coverage passed.
  Why it has been modified?
  Please remove it.

  Reply by plucia on 14 October 2020, 15:08
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:08
    > RESOLVED

----------------------------------------
File: tst_HDOperationModeData/test.py
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:36 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5381

  Why this is added?
  The unit test for that feature was working and all the tests
  and coverage passed.
  Why it has been modified?
  Please remove it.

  Reply by plucia on 14 October 2020, 15:08
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:07
    > RESOLVED

----------------------------------------
File: tst_TreatmentSalineData/test.py
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:37 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5382

  Why this is added?
  The unit test for that feature was working and all the tests
  and coverage passed.
  Why it has been modified?
  Please remove it.

  Reply by plucia on 14 October 2020, 15:08
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:07
    > RESOLVED

Revision Comment by Behrouz NematiPour on 07 October 2020, 15:37 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5383

  Why this is added?
  The unit test for that feature was working and all the tests
  and coverage passed.
  Why it has been modified?
  Please remove it.

  Reply by plucia on 14 October 2020, 15:17
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:07
    > RESOLVED

----------------------------------------
File: tst_Treatment_Ultrafiltration/test.py
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:37 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5384

  Why this is added?
  The unit test for that feature was working and all the tests
  and coverage passed.
  Why it has been modified?
  Please remove it.

  Reply by plucia on 14 October 2020, 15:08
  > Done

    Reply by Behrouz NematiPour on 15 October 2020, 11:07
    > RESOLVED

----------------------------------------
File: tools/setup_env.sh
Revision Comment by Behrouz NematiPour on 07 October 2020, 15:38 
https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1#c5386

  Why it has been tested against a branch other than master.
  It has to be master all the time.
  why intermediate code is tested?

  Reply by plucia on 14 October 2020, 15:15
  > It was master locally, but Crucible didn't seem to pick it up
  > until I added another commit.
  > It shows as master here now as well.
  > Done.

    Reply by Behrouz NematiPour on 15 October 2020, 11:04
    > RESOLVED


---

ID: TESTSUITES-DEN-3724-1 https://devapps.diality.us/cru/TESTSUITES-DEN-3724-1

Title: TESTSUITES-DEN-3724_Create Treatment
Statement of Objectives:


State: Closed

Summary: 

Author: plucia
Reviewers: (0 active, 2 completed*)
     Behrouz NematiPour   (*)
     pmontazemi   (*)