This is a list of all comments for UI-BUG-S62-1.

Review Summary: No summary


----------------------------------------
File: sources/model/hd/alarm/MAlarmMapping.cpp
Revision Comment by Dara Navaei on 18 January 2022, 20:57 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11764

  Isn't is safer to have a break at the end of each case?

  Reply by Behrouz NematiPour on 19 January 2022, 09:28
  > There has to be and there is.
  > It is just a long line and those little ones are at the end.

    Reply by Dara Navaei on 19 January 2022, 09:32
    > RESOLVED.

----------------------------------------
File: sources/bluetooth/BluetoothInterface.cpp
Revision Comment by Michael Garthwaite on 26 January 2022, 13:34 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11771

  The declaration in the header file has const for all 3
  parameters.

  Reply by Behrouz NematiPour on 01 February 2022, 15:09
  > matched.

    Reply by Michael Garthwaite on 02 February 2022, 09:57
    > RESOLVED.

----------------------------------------
File: sources/model/ui/data/MUIBloodPressureData.cpp
Revision Comment by Dara Navaei on 18 January 2022, 20:59 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11765

  It seems you have multiple else statements that do the same, is
  that right? If yes, why multiple elses?

  Reply by Behrouz NematiPour on 19 January 2022, 09:30
  > That is a very good point.
  > No one ever mentioned that.
  > 
  > Let me investigate, why I had all these repeated else.
  > Could be for performance not to check next, but there is
  > another way for that too.
  > If I can't find a quick answer for that let me create a case
  > for that since it is everywhere.

  Reply by Behrouz NematiPour on 01 February 2022, 14:53
  > Couldn't find time to investigate more on this,
  > So created a task for later code cleanup and refactoring.
  > http://dvm-linux02:8080/browse/DEN-12031

    Reply by Dara Navaei on 01 February 2022, 20:55
    > RESOLVED.

----------------------------------------
File: resources/images/Logo d-Qt-mod1.png
Revision Comment by Sean Nash on 26 January 2022, 13:53 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11772

  File name does not appear to match image.

  Reply by Behrouz NematiPour on 01 February 2022, 15:08
  > The file is removed.

    Reply by Sean Nash on 02 February 2022, 11:05
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
Revision Comment by Sean Nash on 26 January 2022, 14:02 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11774

  When will we do this?

  Reply by Behrouz NematiPour on 01 February 2022, 14:39
  > It's just code clean-up notes, ToDos with low priority and
  > will be addressed when gets priority.

    Reply by Sean Nash on 02 February 2022, 11:06
    > RESOLVED.

Revision Comment by Sean Nash on 26 January 2022, 14:03 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11775

  Why is this commented out?

  Reply by Behrouz NematiPour on 01 February 2022, 15:06
  > The Arterial and Venous sliders are RangeSlider and are
  > handled differently.
  > The extra code is removed.

    Reply by Sean Nash on 02 February 2022, 11:06
    > RESOLVED.

Revision Comment by Sean Nash on 26 January 2022, 14:04 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11776

  Why commented out?

  Reply by Behrouz NematiPour on 01 February 2022, 15:07
  > The Arterial and Venous sliders are RangeSlider and are
  > handled differently.
  > The extra code is removed.

    Reply by Sean Nash on 02 February 2022, 11:06
    > RESOLVED.

Revision Comment by Sean Nash on 26 January 2022, 14:05 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11777

  Why commented out?

  Reply by Behrouz NematiPour on 01 February 2022, 15:08
  > The Arterial and Venous sliders are RangeSlider and are
  > handled differently.
  > The extra code is removed.

    Reply by Sean Nash on 02 February 2022, 11:07
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/components/SliderCreateTreatment.qml
Revision Comment by Michael Garthwaite on 26 January 2022, 14:11 
https://devapps.diality.us/cru/UI-BUG-S62-1#c11778

  What is the purpose of this alias?

  Reply by Michael Garthwaite on 26 January 2022, 14:14
  > Disregard. Found where it is used.

    Reply by Michael Garthwaite on 26 January 2022, 14:14
    > RESOLVED.


---

ID: UI-BUG-S62-1 https://devapps.diality.us/cru/UI-BUG-S62-1

Title: UI-BUG-S62
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei