This is a list of all comments for UI-BUG-S63-2.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/components/Slider.qml
Revision Comment by Sean Nash on 08 February 2022, 08:38 
https://devapps.diality.us/cru/UI-BUG-S63-2#c11863

  Thickness?

  Reply by Behrouz NematiPour on 14 February 2022, 12:30
  > Thanks,
  > Updated.

    Reply by Sean Nash on 15 February 2022, 10:16
    > RESOLVED.

Revision Comment by Dara Navaei on 15 February 2022, 10:22 
https://devapps.diality.us/cru/UI-BUG-S63-2#c11884

  To make sure the addition is done first, should you put ( width
  + minimum ) ?

  Reply by Behrouz NematiPour on 15 February 2022, 10:32
  > Actually, this is correct.
  > And it should not have parenthesis like you said, otherwise
  > it becomes incorrect.
  > if I write it like :
  > {code} ( ( x * ( maximum - minimum ) ) / width ) + minimum
  > {code}
  > then too many /redundant parentheses make it confusing.

    Reply by Dara Navaei on 15 February 2022, 10:35
    > RESOLVED.

Revision Comment by Sean Nash on 08 February 2022, 08:40 
https://devapps.diality.us/cru/UI-BUG-S63-2#c11864

  Lines above are formatted to align terms of equation.  This
  line is not.

  Reply by Behrouz NematiPour on 14 February 2022, 12:30
  > Thanks,
  > Aligned.

    Reply by Sean Nash on 15 February 2022, 10:15
    > RESOLVED.

Revision Comment by Sean Nash on 08 February 2022, 08:40 
https://devapps.diality.us/cru/UI-BUG-S63-2#c11865

  Why commented out?

  Reply by Behrouz NematiPour on 14 February 2022, 12:20
  > This is part of an ongoing investigation on how to fix the
  > slider touch margin issue.
  > I am still working on it.
  > It worked somehow for the slider with lower resolution but
  > for sliders, with a high resolution, it causes a handler jump
  > which makes it less user-friendly.
  > Added clarifying comment.

    Reply by Sean Nash on 15 February 2022, 10:15
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/pages/treatment/TreatmentStack.qml
Revision Comment by Sean Nash on 08 February 2022, 08:42 
https://devapps.diality.us/cru/UI-BUG-S63-2#c11866

  If not needed, why not just delete this line?

  Reply by Behrouz NematiPour on 14 February 2022, 11:40
  > This is the Trends screen.
  > It is needed since it has not been implemented yet has been
  > commented out.

    Reply by Sean Nash on 15 February 2022, 10:14
    > RESOLVED.


---

ID: UI-BUG-S63-2 https://devapps.diality.us/cru/UI-BUG-S63-2

Title: UI-BUG-S63
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 3 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei   (*)