This is a list of all comments for UI-DEN-10206-1. Review Summary: No summary ---------------------------------------- File: resources/settings/Messages/Unhandled.conf Revision Comment by Sean Nash on 01 November 2021, 10:41 https://devapps.diality.us/cru/UI-DEN-10206-1#c11036 Can we move this file to common folder so that f/w team can make updates as needed when adding new messages? Reply by Behrouz NematiPour on 01 November 2021, 15:13 > Totally agree. > I just created a task for that to follow up DEN-10979. > After giving it some thought it needs some dev-ops > modifications which will be followed up in that task later. Reply by Sean Nash on 01 November 2021, 16:47 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/MainHome.qml Revision Comment by Sean Nash on 01 November 2021, 13:15 https://devapps.diality.us/cru/UI-DEN-10206-1#c11050 Should we add a TODO here so we don't forget? Reply by Behrouz NematiPour on 01 November 2021, 14:47 > Updated Reply by Sean Nash on 01 November 2021, 15:08 > RESOLVED. ---------------------------------------- File: sources/view/hd/alarm/VAlarmStatus.cpp Revision Comment by pmontazemi on 03 November 2021, 15:34 https://devapps.diality.us/cru/UI-DEN-10206-1#c11095 Align "));" with the other lines. Reply by Behrouz NematiPour on 04 November 2021, 13:42 > Updated in the latest branch, _[The > Link|http://dvm-linux02:7990/projects/UI/repos/application/commits/e8262d170bb94046ddb767074a31530bdf4a2319#sources/view/hd/alarm/VAlarmStatus.cpp]_ > is attached. Reply by pmontazemi on 05 November 2021, 10:43 > RESOLVED. ---------------------------------------- File: sources/view/hd/data/posttreatment/VPostTreatmentStatesData.cpp Revision Comment by Sean Nash on 01 November 2021, 13:16 https://devapps.diality.us/cru/UI-DEN-10206-1#c11051 Should we have a TODO or FIXME here? Reply by Behrouz NematiPour on 01 November 2021, 13:17 > There is no todo or fix for this. > It is a hint for developers to be careful when using this in > debugging since it affects the performance. > Added more clarification. Reply by Sean Nash on 01 November 2021, 13:21 > RESOLVED. ---------------------------------------- File: sources/view/settings/VDateTime.cpp Revision Comment by Sean Nash on 01 November 2021, 13:17 https://devapps.diality.us/cru/UI-DEN-10206-1#c11052 Missing function header. Reply by Behrouz NematiPour on 01 November 2021, 14:45 > updated. Reply by Sean Nash on 01 November 2021, 15:09 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 13:17 https://devapps.diality.us/cru/UI-DEN-10206-1#c11053 Magic numbers. Reply by Behrouz NematiPour on 01 November 2021, 14:46 > Updated Reply by Sean Nash on 01 November 2021, 15:09 > RESOLVED. ---------------------------------------- File: sources/device/DeviceView.cpp Revision Comment by Sean Nash on 01 November 2021, 11:29 https://devapps.diality.us/cru/UI-DEN-10206-1#c11044 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:48 > This function header is autogenerated by Doxygen getting the > comments from the macros. Reply by Sean Nash on 01 November 2021, 15:08 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:29 https://devapps.diality.us/cru/UI-DEN-10206-1#c11045 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:49 > This function header is autogenerated by Doxygen getting the > comments from the macros. > Please look into the updated DeviceGlobals.h Reply by Sean Nash on 01 November 2021, 15:08 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:29 https://devapps.diality.us/cru/UI-DEN-10206-1#c11046 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:49 > This function header is autogenerated by Doxygen getting the > comments from the macros. > Please look into the updated DeviceGlobals.h Reply by Sean Nash on 01 November 2021, 15:08 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:29 https://devapps.diality.us/cru/UI-DEN-10206-1#c11047 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:50 > This function header is autogenerated by Doxygen getting the > comments from the macros. > Please look into the updated DeviceGlobals.h Reply by Sean Nash on 01 November 2021, 15:08 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:29 https://devapps.diality.us/cru/UI-DEN-10206-1#c11048 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:50 > This function header is autogenerated by Doxygen getting the > comments from the macros. > Please look into the updated DeviceGlobals.h Reply by Sean Nash on 01 November 2021, 15:08 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:29 https://devapps.diality.us/cru/UI-DEN-10206-1#c11049 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:59 > This function header is autogenerated by Doxygen getting the > comments from the macros. > Please look into the updated DeviceGlobals.h Reply by Sean Nash on 01 November 2021, 15:08 > RESOLVED. ---------------------------------------- File: sources/view/settings/VBluetooth.cpp Revision Comment by pmontazemi on 03 November 2021, 15:35 https://devapps.diality.us/cru/UI-DEN-10206-1#c11096 feedback in one word (in comment) Reply by Behrouz NematiPour on 04 November 2021, 13:41 > Updated in the latest branch, _[The > Link|http://dvm-linux02:7990/projects/UI/repos/application/commits/e8262d170bb94046ddb767074a31530bdf4a2319#sources/view/settings/VBluetooth.cpp]_ > is attached. Reply by pmontazemi on 05 November 2021, 10:43 > RESOLVED. ---------------------------------------- File: sources/canbus/MessageDispatcher.cpp Revision Comment by Sean Nash on 01 November 2021, 11:20 https://devapps.diality.us/cru/UI-DEN-10206-1#c11037 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 15:16 > updated. Reply by Sean Nash on 01 November 2021, 16:44 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:20 https://devapps.diality.us/cru/UI-DEN-10206-1#c11038 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 15:16 > updated Reply by Sean Nash on 01 November 2021, 16:44 > RESOLVED. ---------------------------------------- File: sources/device/DeviceController.cpp Revision Comment by Sean Nash on 01 November 2021, 11:28 https://devapps.diality.us/cru/UI-DEN-10206-1#c11042 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:56 > This function header is autogenerated by Doxygen getting the > comments from the macros. > Please look into the updated DeviceGlobals.h Reply by Sean Nash on 01 November 2021, 15:06 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:28 https://devapps.diality.us/cru/UI-DEN-10206-1#c11043 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:56 > This function header is autogenerated by Doxygen getting the > comments from the macros. > Please look into the updated DeviceGlobals.h Reply by Sean Nash on 01 November 2021, 15:06 > RESOLVED. ---------------------------------------- File: sources/device/DeviceController.h Revision Comment by pmontazemi on 03 November 2021, 15:29 https://devapps.diality.us/cru/UI-DEN-10206-1#c11091 Class header missing. Reply by Behrouz NematiPour on 04 November 2021, 13:44 > Updated in the latest branch. _[The > Link|http://dvm-linux02:7990/projects/UI/repos/application/commits/e8262d170bb94046ddb767074a31530bdf4a2319#sources/device/DeviceController.h]_ > is attached. Reply by pmontazemi on 05 November 2021, 10:40 > RESOLVED. ---------------------------------------- File: sources/device/DeviceGlobals.h Revision Comment by pmontazemi on 03 November 2021, 15:31 https://devapps.diality.us/cru/UI-DEN-10206-1#c11092 Remove extra line. Reply by Behrouz NematiPour on 06 November 2021, 18:00 > Has been removed in the latest branch. _[The > Link|http://dvm-linux02:7990/projects/UI/repos/application/commits/4e0e7152e881c936b006d0fbebf74cdafc7c9867]_ > attached. Reply by pmontazemi on 08 November 2021, 08:41 > RESOLVED. ---------------------------------------- File: sources/device/DeviceModels.h Revision Comment by pmontazemi on 03 November 2021, 15:32 https://devapps.diality.us/cru/UI-DEN-10206-1#c11093 Rephrase: "Merge the two modes as they have much in common in this case." Reply by Behrouz NematiPour on 04 November 2021, 13:43 > Updated in the latest branch. _[The > Link|http://dvm-linux02:7990/projects/UI/repos/application/commits/e8262d170bb94046ddb767074a31530bdf4a2319#sources/device/DeviceModels.h]_ > is attached. Reply by pmontazemi on 05 November 2021, 10:42 > RESOLVED. Revision Comment by pmontazemi on 03 November 2021, 15:32 https://devapps.diality.us/cru/UI-DEN-10206-1#c11094 Class header missing. Reply by Behrouz NematiPour on 04 November 2021, 13:43 > Updated in the latest branch. _[The > Link|http://dvm-linux02:7990/projects/UI/repos/application/commits/e8262d170bb94046ddb767074a31530bdf4a2319#sources/device/DeviceModels.h]_ > is attached. Reply by pmontazemi on 05 November 2021, 10:42 > RESOLVED. ---------------------------------------- File: sources/cloudsync/CloudSyncController.cpp Revision Comment by Sean Nash on 01 November 2021, 11:25 https://devapps.diality.us/cru/UI-DEN-10206-1#c11039 No details? Reply by Behrouz NematiPour on 01 November 2021, 14:55 > Updated Reply by Sean Nash on 01 November 2021, 15:03 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:26 https://devapps.diality.us/cru/UI-DEN-10206-1#c11040 Is outBuff still needed? Delete? Reply by Behrouz NematiPour on 01 November 2021, 14:55 > removed Reply by Sean Nash on 01 November 2021, 15:03 > RESOLVED. Revision Comment by Sean Nash on 01 November 2021, 11:26 https://devapps.diality.us/cru/UI-DEN-10206-1#c11041 Function needs header. Reply by Behrouz NematiPour on 01 November 2021, 14:56 > updated Reply by Sean Nash on 01 November 2021, 15:03 > RESOLVED. --- ID: UI-DEN-10206-1 https://devapps.diality.us/cru/UI-DEN-10206-1 Title: UI-DEN-10206_BCuff Known Bugs Only Pair With One BCuff At A Time Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (0 active, 2 completed*) Sean Nash (*) pmontazemi (*)