This is a list of all comments for UI-DEN-10602-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreate.qml
Revision Comment by Sean Nash on 29 November 2021, 08:46 
https://devapps.diality.us/cru/UI-DEN-10602-1#c11456

  Why commented out?

  Reply by Behrouz NematiPour on 29 November 2021, 10:47
  > The code was old and not up to our standard.
  > It was in the middle of a huge improvement and test.
  > It has been completely removed from the screen and moved to
  > the component to avoid redundant code copy/paste.

    Reply by Sean Nash on 29 November 2021, 12:25
    > RESOLVED.

Revision Comment by Sean Nash on 29 November 2021, 08:47 
https://devapps.diality.us/cru/UI-DEN-10602-1#c11457

  Why commented out?

  Reply by Behrouz NematiPour on 29 November 2021, 10:46
  > The code was old and not up to our standard.
  > It was in the middle of a huge improvement and test.
  > It has been completely removed from the screen and moved to
  > the component to avoid redundant code copy/paste.

    Reply by Sean Nash on 29 November 2021, 12:25
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/pages/pretreatment/create/PreTreatmentCreateStack.qml
Revision Comment by Michael Garthwaite on 17 December 2021, 16:00 
https://devapps.diality.us/cru/UI-DEN-10602-1#c11552

  Some functions and variables in this file use PatientID instead
  of PtientID, was this spelling intentional?

  Reply by Behrouz NematiPour on 17 December 2021, 18:45
  > Fixed.
  > Thanks for your attention to the details.

    Reply by Michael Garthwaite on 21 December 2021, 11:29
    > RESOLVED

----------------------------------------
File: scripts/setup.sh
Revision Comment by Behrouz NematiPour on 13 December 2021, 16:12 
https://devapps.diality.us/cru/UI-DEN-10602-1#c11516

  it is a test for the code review demo

  Reply by Behrouz NematiPour on 13 December 2021, 16:13
  > that is fine because...

    Reply by Behrouz NematiPour on 13 December 2021, 16:15
    > RESOLVED

----------------------------------------
File: sources/cloudsync/CloudSyncController.cpp
Revision Comment by Sean Nash on 13 December 2021, 16:33 
https://devapps.diality.us/cru/UI-DEN-10602-1#c11520

  Needs function header?

  Reply by Behrouz NematiPour on 14 December 2021, 10:36
  > Added

    Reply by Sean Nash on 30 December 2021, 09:36
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/components/StackItem.qml
Revision Comment by Sean Nash on 29 November 2021, 08:44 
https://devapps.diality.us/cru/UI-DEN-10602-1#c11455

  Looks like the rest of this function is dead code.  Why are we
  returning here?

  Reply by Behrouz NematiPour on 29 November 2021, 10:43
  > This is a debug code that will be enabled to trace the screen
  > stack.
  > if was only a return, changed to an if to make it conditional
  > for later use.

    Reply by Sean Nash on 29 November 2021, 12:26
    > RESOLVED.


---

ID: UI-DEN-10602-1 https://devapps.diality.us/cru/UI-DEN-10602-1

Title: UI-DEN-10602_UI DEV Add PatientID PreTreatment
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei