This is a list of all comments for UI-DEN-12716-2.

Review Summary: No summary


----------------------------------------
File: scripts/run.sh
Revision Comment by Sean Nash on 01 July 2022, 10:55 
https://devapps.diality.us/cru/UI-DEN-12716-2#c13247

  Why must this be removed later?

  Reply by Behrouz NematiPour on 01 July 2022, 11:45
  > At the moment I added that switch I assumed it should only be
  > used for V&V and SysV testing.

    Reply by Sean Nash on 06 July 2022, 09:33
    > If this is to log Dialin messages, we should always do that
    > (no switch).  If a Dialin command is given/responded to, we
    > definitely want to know about that - so want to see it in
    > the log.  Dialin commands are always one-shot type
    > messages, so will not impact log size.

      Reply by Behrouz NematiPour on 11 July 2022, 09:58
      > Sure Sean, if that is the decision, will do it soon and
      > create a case for that.
      > I also believe some other CL Switches need to be removed,
      > which were only implemented for our testing at the time
      > (CANBus).
      > 
      > Issue DEN-13441 - MR: Make the Dialin log permanent with
      > no switch [CL switches review/removal] has been
      > successfully created

        Reply by Sean Nash on 12 July 2022, 11:51
        > RESOLVED.

----------------------------------------
File: sources/gui/qml/components/ExportButton.qml
Revision Comment by Tiffany Mejia on 01 July 2022, 16:09 
https://devapps.diality.us/cru/UI-DEN-12716-2#c13255

  Where would this value change?

  Reply by Behrouz NematiPour on 01 July 2022, 16:46
  > http://dvm-linux02:8060/cru/UI-DEN-12716-2#CFR-30978
  > in PostTreatmentReview.qml@40

    Reply by Tiffany Mejia on 06 July 2022, 09:03
    > RESOLVED

----------------------------------------
File: scripts/setup.sh
Revision Comment by Sean Nash on 01 July 2022, 10:57 
https://devapps.diality.us/cru/UI-DEN-12716-2#c13248

  All systems will be setup for Pacific time zone?

  Reply by Behrouz NematiPour on 01 July 2022, 11:39
  > This is the requirement.
  > PRS 417: The HD Device manufacturing default timezone shall
  > be (UTC-08:00) Pacific Time.

    Reply by Sean Nash on 06 July 2022, 09:31
    > RESOLVED.

----------------------------------------
File: sources/_wip_/fileCopy/main.cpp
Revision Comment by Sean Nash on 01 July 2022, 10:59 
https://devapps.diality.us/cru/UI-DEN-12716-2#c13249

  Why is main.cpp all commented out?

  Reply by Behrouz NematiPour on 01 July 2022, 11:43
  > This code is going to be used later in the Log Export for
  > slow transfer  & confirmation for the USB port slow transfer
  > issue.
  > I kept it in the application repo to keep it safe.
  > Commented out to not affect the coverage.

    Reply by Sean Nash on 06 July 2022, 09:31
    > RESOLVED.


---

ID: UI-DEN-12716-2 https://devapps.diality.us/cru/UI-DEN-12716-2

Title: UI-DEN-12716_UI BN S70
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 3 completed*)
     Sean Nash   (*)
     Tiffany Mejia   (*)
     Michael Garthwaite   (*)
     Dara Navaei