This is a list of all comments for UI-DEN-13962-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/pages/treatment/TreatmentHome.qml
Revision Comment by Sean Nash on 04 November 2022, 15:21 
https://devapps.diality.us/cru/UI-DEN-13962-1#c14773

  Why is there 2 spaces between . and field name?

  Reply by Behrouz NematiPour on 05 November 2022, 11:59
  > to align arterial(8 characters) and venous(6 characters)
  > vertically, and to make it easier to compare the variables,
  > to avoid missing a parameter.

  Reply by Behrouz NematiPour on 07 November 2022, 11:44
  > removed spaces.

    Reply by Sean Nash on 07 November 2022, 11:52
    > RESOLVED in CODE WALKTHROUGH.


---

ID: UI-DEN-13962-1 https://devapps.diality.us/cru/UI-DEN-13962-1

Title: UI-DEN-13962_UI BN S82
Statement of Objectives:
commit : [ffc5c436|http://192.168.10.132:7990/projects/UI/repos/application/commits/ffc5c436] - DEN-13962: UI: Update pressure limits to match treatment params and UI screen
 - Fixed the issue with the sliders not updating the ranges and the pressure adjustment was not able to be adjusted.

commit : [e8df7fe7|http://192.168.10.132:7990/projects/UI/repos/application/commits/e8df7fe7] - DEN-13962: UI: Update pressure limits to match treatment params and UI screen
 - removed the QML duplicate definitions of arterial/venous
 - added monitoring values and used them in monitoring components of arterial/venous.

commit : [5e03d3f2|http://192.168.10.132:7990/projects/UI/repos/application/commits/5e03d3f2] - DEN-13962: UI: Update pressure limits to match treatment params and UI screen
 - Completely restructure the vTreatmentCreate class and removed all the constant ranges properties from that to the VTreatmentRanges.
 - Now reading all the constant ranges values from the DataList.conf from the ui.config repository.
 - Used the RANGESET property type for the ranges in the VTreatmentRanges class to have by default properties for min,max, res(olution),def(ault) properties.
 - Added an ability to slider to hide the handler when needed (Pre-Treatment)
 - Hide the Slider handler when slider switch is off
 - Added various PROPERTYs, like IDBASED, RAGESET, VALUESET
 - Modified the MPreTreatmentAdjustRequest, duration parameter to treatmentDuration for clarifying.
 - Modified the Settings class to able to parse a comment on the Group line.
 - Updated the ConfirmTreatmentTable to hold the required labels and added translate function for them. removed the call for get names for performance, since those never change.
 - Made the SettingsData connection, standard in the VSettings class.


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 3 completed*)
     Sean Nash   (*)
     Tiffany Mejia   (*)
     jishii   (*)
     Michael Garthwaite