This is a list of all comments for UI-DEN-14294-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/pages/settings/SettingsExportLogs.qml
Revision Comment by Sean Nash on 19 December 2022, 13:47 
https://devapps.diality.us/cru/UI-DEN-14294-1#c15256

  Align function bodies.

  Reply by Sean Nash on 20 December 2022, 08:29
  > RESOLVED.

----------------------------------------
File: sources/cloudsync/CloudSyncController.cpp
Revision Comment by Sean Nash on 20 December 2022, 08:33 
https://devapps.diality.us/cru/UI-DEN-14294-1#c15404

  I don't see ending bracket for this if.  Does this even build?

  Reply by Behrouz NematiPour on 20 December 2022, 13:47
  > Fixed the indentation

    Reply by Sean Nash on 20 December 2022, 14:05
    > RESOLVED.

----------------------------------------
File: sources/device/DeviceController.h
Revision Comment by Sean Nash on 19 December 2022, 13:34 
https://devapps.diality.us/cru/UI-DEN-14294-1#c15252

  Align "=".

  Reply by Sean Nash on 20 December 2022, 08:30
  > RESOLVED.

----------------------------------------
File: sources/gui/qml/PowerItem.qml
Revision Comment by Michael Garthwaite on 19 December 2022, 15:23 
https://devapps.diality.us/cru/UI-DEN-14294-1#c15283

  The body of this function looks all commented out. Is this
  function necessary?

  Reply by Behrouz NematiPour on 19 December 2022, 16:13
  > This function is a slot to debug the behavior of the power
  > dialog for now
  > The entire qml file may later be removed.
  > We had some conversations to combine the power message into
  > confirmation and remove the power qml, models, and so on.

    Reply by Michael Garthwaite on 21 December 2022, 15:03
    > RESOLVED

----------------------------------------
File: sources/model/settings/MSettings.h
Revision Comment by Sean Nash on 19 December 2022, 13:54 
https://devapps.diality.us/cru/UI-DEN-14294-1#c15263

  Why commented out?

  Reply by Behrouz NematiPour on 19 December 2022, 16:18
  > Seems like as part of modern C++ the equal operator is no
  > longer needed.
  > I need to investigate more to completely remove it.

    Reply by Sean Nash on 19 December 2022, 17:02
    > RESOLVED.


---

ID: UI-DEN-14294-1 https://devapps.diality.us/cru/UI-DEN-14294-1

Title: UI-DEN-14294_UI BN S84
Statement of Objectives:
These Code review comments have been addressed and the branch has been already merged into develop and staging.

State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (3 active, 2 completed*)
     Tiffany Mejia   (*)
     jishii   (*)
     Sean Nash
     Michael Garthwaite
     Dara Navaei